Skip to content

Fix 'From' Dropdown Layout Shift #63350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luacmartins merged 2 commits into from
Jun 3, 2025
Merged

Fix 'From' Dropdown Layout Shift #63350

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d250c6a
fix layout shift for user selection list
JS00001 Jun 3, 2025
5b4451e
cleanup to use w100
JS00001 Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/styles/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5792,8 +5792,9 @@ const styles = (theme: ThemeColors) =>
// the listHeight, the max height of the popover, or 90% of the window height, such that we never overflow the screen
// and never expand over the max height
const height = Math.min(ESTIMATED_LIST_HEIGHT, CONST.POPOVER_DROPDOWN_MAX_HEIGHT, windowHeight * 0.9);
const width = shouldUseNarrowLayout ? sizing.w100 : {width: CONST.POPOVER_DROPDOWN_WIDTH};

return {height};
return {height, ...width};
},

earlyDiscountButton: {
Expand Down