[Better Expense Report View] Fix the misalignment of the columns in the Report View caused by the Comments column - #63022
Closed
JakubKorytko wants to merge 1 commit into
Conversation
JakubKorytko
force-pushed
the
korytko/fix-misaligned-rows-due-to-chat-bubble
branch
from
May 29, 2025 09:47
1601c51 to
9ba22e2
Compare
JakubKorytko
marked this pull request as ready for review
May 29, 2025 09:55
melvin-bot
Bot
requested review from
MarioExpensify
and removed request for
a team
May 29, 2025 09:56
|
@MarioExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Member
Author
|
Please do not review it yet, as we are still discussing it. #62605 (comment) |
49 tasks
Member
Author
|
Closing this one, reason: #62605 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixes for issues mentioned in #62605 (comment) discussion:
We want to show the comments column (and the reserved space for it) only if there are comments for any of the expenses.Not anymore.Fixed Issues
$ N/A
PROPOSAL: N/A
Tests
Offline tests
Same as tests.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Web.mov
MacOS: Desktop