fix: error in time modal picker by nkdengineer · Pull Request #62631 · Expensify/App

nkdengineer · 2025-05-23T04:03:01Z

Explanation of Change

Fixed Issues

$ #61595
PROPOSAL: #61595 (comment)

Tests

Press + in Workspace chat
Create expense
Select Per diem
Select a country
Verify that: User able to continue to next step without any errors

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

abdr.mov

Android: mWeb Chrome

android-mweb.mov

iOS: Native

Screen_Recording_2025-06-09_at_01.16.36.mov

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

wbe.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2025-05-23T04:03:10Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

nkdengineer · 2025-05-25T17:51:41Z

I am a little stuck on the Android and iOS Native builds, will add later

melvin-bot · 2025-05-25T17:51:48Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shubham1206agra · 2025-05-26T02:09:12Z

+        shouldHideClearButton = false,
+    }: DateInputWithPickerProps,
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+    ref: ForwardedRef<View>,


@nkdengineer Why can't we use this ref as textInputRef?

@shubham1206agra The component has two refs:

A forwarded ref (ref: ForwardedRef) that's passed from the parent component - the purpose here is just to fix the error

A local textInputRef that's used to reference the TextInput component

So we can't use textInputRef in here

No, replace the local ref with forwardedRef. What is the issue exactly?

@shubham1206agra as you can see in here, we are using forwardRef and it needs 2 params is props and ref

App/src/components/DatePicker/index.tsx

Line 161 in 37a592e

export default forwardRef(DatePicker);

App/src/components/DatePicker/index.tsx

Lines 16 to 32 in b2f5d0b

function DatePicker({

defaultValue,

disabled,

errorText,

inputID,

label,

minDate = setYear(new Date(), CONST.CALENDAR_PICKER.MIN_YEAR),

maxDate = setYear(new Date(), CONST.CALENDAR_PICKER.MAX_YEAR),

onInputChange,

onTouched = () => {},

placeholder,

value,

shouldSaveDraft = false,

formID,

autoFocus = false,

shouldHideClearButton = false,

}: DateInputWithPickerProps) {

I mean remove the localRef and use forwardedRef instead

LocalRef uses useRef, it has current property and forwardedRef don't have this property so we can't replace the local ref with forwardedRef.

ref={mergeRefs(ref, textInputRef)}

@nkdengineer Use it like this.

thanks @shubham1206agra, i updated

shubham1206agra · 2025-05-27T12:35:43Z

@nkdengineer Bump here

nkdengineer · 2025-05-27T16:10:17Z

@shubham1206agra i updated

shubham1206agra · 2025-06-05T09:58:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
xIf a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

NA

Android: mWeb Chrome

NA

iOS: HybridApp

NA

iOS: mWeb Safari

NA

MacOS: Chrome / Safari

Screen.Recording.2025-06-05.at.3.08.38.PM.mov

MacOS: Desktop

Screen.Recording.2025-06-05.at.3.25.55.PM.mov

OSBotify · 2025-06-07T01:15:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-06-09T16:54:30Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.1.63-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-06-10T22:40:46Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.1.63-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: error in time modal picker

1aa45a3

fix lint

fd51acd

nkdengineer marked this pull request as ready for review May 25, 2025 17:51

nkdengineer requested a review from a team as a code owner May 25, 2025 17:51

melvin-bot Bot requested review from shubham1206agra and removed request for a team May 25, 2025 17:51

shubham1206agra reviewed May 26, 2025

View reviewed changes

Merge branch 'main' into fix/61595

37a592e

nkdengineer added 4 commits May 29, 2025 15:23

Merge branch 'main' into fix/61595

a804b25

Merge branch 'main' into fix/61595

5a524ac

Merge branch 'main' into fix/61595

33981a9

Use mergeRefs

bbbe423

shubham1206agra approved these changes Jun 5, 2025

View reviewed changes

melvin-bot Bot requested a review from jasperhuangg June 5, 2025 09:59

jasperhuangg approved these changes Jun 7, 2025

View reviewed changes

jasperhuangg merged commit e1766ef into Expensify:main Jun 7, 2025

github-actions Bot mentioned this pull request Jun 9, 2025

Deploy Checklist: New Expensify 2025-06-09 #63762

Closed

77 tasks

melvin-bot Bot mentioned this pull request Jun 10, 2025

[Due for payment 2025-06-17] [$250] Console error: Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()? #61595

Closed

16 tasks

	function DatePicker({
	defaultValue,
	disabled,
	errorText,
	inputID,
	label,
	minDate = setYear(new Date(), CONST.CALENDAR_PICKER.MIN_YEAR),
	maxDate = setYear(new Date(), CONST.CALENDAR_PICKER.MAX_YEAR),
	onInputChange,
	onTouched = () => {},
	placeholder,
	value,
	shouldSaveDraft = false,
	formID,
	autoFocus = false,
	shouldHideClearButton = false,
	}: DateInputWithPickerProps) {

Uh oh!

Conversation

nkdengineer commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 23, 2025

Uh oh!

nkdengineer commented May 25, 2025

Uh oh!

melvin-bot Bot commented May 25, 2025

Uh oh!

shubham1206agra May 26, 2025

Choose a reason for hiding this comment

Uh oh!

nkdengineer May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shubham1206agra May 27, 2025

Choose a reason for hiding this comment

Uh oh!

nkdengineer May 28, 2025

Choose a reason for hiding this comment

Uh oh!

shubham1206agra May 28, 2025

Choose a reason for hiding this comment

Uh oh!

nkdengineer Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

shubham1206agra Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

nkdengineer Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

shubham1206agra commented May 27, 2025

Uh oh!

nkdengineer commented May 27, 2025

Uh oh!

shubham1206agra commented Jun 5, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

OSBotify commented Jun 7, 2025

Uh oh!

github-actions Bot commented Jun 9, 2025

Uh oh!

github-actions Bot commented Jun 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nkdengineer commented May 23, 2025 •

edited

Loading

nkdengineer May 27, 2025 •

edited

Loading