feat: implement distance rate name edit page by mkzie2 · Pull Request #62535 · Expensify/App

mkzie2 · 2025-05-22T00:34:51Z

Explanation of Change

This PR implements the distance rate name edit page.

This PR eliminates the concept of Default rate:

First rate created automatically by the system when the workspace is created is called Default rate. New rates created by user are called New rate (New rate 1, New rate 2...)
Rates are sorted by creation order (first created appears first)
You can delete, rename or modify the system-created rate (the rate with Default rate name)
The fallback (default) rate when creating expense is the earliest created rate that exists (i.e. the first one shown in rates list)
When distance rates feature is not enabled, the rate being used when creating expenses is also the earliest created rate that exists (i.e. the first one shown in rates list)

Fixed Issues

$ #62099
PROPOSAL: #62099 (comment)

Tests

Test 1: Create new rates

As workspace admin navigate to workspace settings
Open Distance rates and add rates (enable Distance rates feature if needed)
Verify the first rate is named Default rate
Verify new rates created by user are named New rate i (e.g., New rate, New rate 1, New rate 2...)
Verify rate list sorts rates by creation order (first created appears first)
Verify rate list shows rate name as primary text and rate value as secondary text

Test 2: Edit rate name

Press a rate
Verify rate "Name" push row shows
Press "Name"
Clear all input > "Save"
Verify error says "Rate name is required"
Input a lengthy text with > 50 characters > "Save"
Verify error says "Character limit exceeded"
Input an existing rate name > "Save"
Verify error says "A distance rate with this name already exists"
Input a valid rate name > "Save"
Verify rate name is updated
Try to rename the Default rate - $0.70
Verify the Default rate name is editable

Test 3: Delete rate

Try to delete all rates
Verify you cannot delete the rate if it is the only one in the list

Test 4: Fallback rate when creating expenses

Try to create a distance expense in that workspace
Verify in confirmation step, the default rate shown is also the earliest created rate that still exists (the rate that is shown first in rates list)
Disable Distance rates feature for the workspace
Repeat step 1 - 2

Verify that no errors appear in the JS console

Offline tests

QA Steps

See Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screen.Recording.2025-05-22.at.07.56.55-compressed.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-05-22.at.07.49.34.mov

MacOS: Desktop

Screen.Recording.2025-05-22.at.07.51.35.mov

melvin-bot · 2025-05-22T00:52:30Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2025-05-27T13:19:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-07-26.at.2.32.15.AM.mov

Android: mWeb Chrome

Screen.Recording.2025-07-26.at.2.44.27.AM.mov

iOS: HybridApp

Screen.Recording.2025-07-26.at.1.25.53.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-07-26.at.1.23.26.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-07-26.at.1.19.02.AM.mov

MacOS: Desktop

Screen.Recording.2025-07-26.at.2.37.50.AM.mov

ishpaul777 · 2025-05-27T13:19:21Z

will start reviewing today

ishpaul777 · 2025-05-28T20:17:16Z

@mkzie2 can you make sure "Default Rate" is not renamable and, Thanks!

ishpaul777 · 2025-05-30T15:08:20Z

@mkzie2 bump!

mkzie2 · 2025-06-02T08:55:07Z

@ishpaul777 Seems like they're still discussing here #62099 (comment).

mkzie2 · 2025-06-03T08:01:37Z

Based on the latest discussion, we do not need to implement this one #62535 (comment).

ishpaul777 · 2025-06-04T17:48:33Z

there is various logic around the DEFAULT_RATE name, can you please double check and remove that logic where its not needed becuase now name can be changed

ishpaul777 · 2025-06-06T12:33:36Z

@mkzie2 Any updates?

…/62099

mkzie2 · 2025-06-09T03:23:03Z

Replied here #62099 (comment)

ishpaul777 · 2025-06-12T10:16:45Z

@mkzie2 lets get a update here and ping me when its ready

mkzie2 · 2025-06-17T17:36:30Z

Discussion is ongoing in the main issue thread.

ishpaul777 · 2025-06-25T15:26:39Z

are you able to resolve all your queries, can we move forward? @mkzie2

mkzie2 · 2025-06-25T17:23:52Z

I'm still researching if the default rate change could cause regressions. Will ready for review soon.

…/62099

mkzie2 · 2025-06-26T14:00:02Z

Except for the renaming Default rate bug here #62099 (comment), everything else works fine.

mkzie2 · 2025-07-16T01:00:03Z

@ishpaul777 Fixed. Please note that we cannot rename "Default rate" for now. It's being worked on in the BE #62099 (comment).

MonilBhavsar · 2025-07-18T13:17:02Z

Mind merging main here please

ishpaul777 · 2025-07-21T11:49:14Z

@mkzie2 can you please merge main here

…/62099

mkzie2 · 2025-07-23T09:53:52Z

@ishpaul777 Updated PR. I added a few test cases in PR description to get a better overview of the changes.

mkzie2 · 2025-07-23T09:54:32Z

Spell check is not related.

MonilBhavsar · 2025-07-24T03:27:47Z

Spell check should be resolved on main.
@ishpaul777 would you be able to review this today?

…/62099

ishpaul777

code seems good! minor comments, will complete testing and checklist

ishpaul777 · 2025-07-25T12:41:02Z

+                // TODO: Confirm max length
+                // Uses the spread syntax to count the number of Unicode code points instead of the number of UTF-16 code units.


lets confirm this and remove TODO cc @MonilBhavsar

looks like current max length is 50. So we should go with it, IMO

Removed TODO. @MonilBhavsar Ready for your review.

ishpaul777 · 2025-07-25T12:51:05Z

+            errors: {
+                rateNameRequired: 'El nombre de la tasa es obligatorio',
+                existingRateName: 'Ya existe una tasa de distancia con este nombre',
+            },


is translations confirmed for all languages?

We haven't had an official process to confirm translations for all languages. If you knew it, could you share? For Spanish, I'm checking it in this thread.

Spanish confirmed.

use deepl.com and confirm translations are accurate, in the meantime i have asked internally if there is formal process

Please take a look at this https://github.com/Expensify/App?tab=readme-ov-file#generating-translations

Oh I remembered the last time I ran the script, it cost me around $20 within 15 minutes before reaching tier limit because it requests translations for all the copies. Let me try again to check if that was fixed.

Updated with generateTranslations script.

ishpaul777 · 2025-07-25T13:35:30Z

    API.write(WRITE_COMMANDS.UPDATE_POLICY_DISTANCE_RATE_VALUE, params, {optimisticData, successData, failureData});
 }

+function updatePolicyDistanceRateName(policyID: string, customUnit: CustomUnit, customUnitRates: Rate[]) {


NAB: can this updatePolicyDistanceRateName and updatePolicyDistanceRateValue be DRYed up by extracting the common logic in a util

…/62099

mkzie2 · 2025-07-29T18:04:48Z

@ishpaul777 Ready for review.

ishpaul777

LGTM! still one comment unresolved

cc @MonilBhavsar

MonilBhavsar

Thanks! Looking good!

OSBotify · 2025-07-31T05:45:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-07-31T12:16:04Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.1.88-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-08-04T19:23:12Z

🚀 Deployed to production by https://github.com/grgia in version: 9.1.88-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

parasharrajat · 2025-08-28T06:40:03Z

        return rateText.includes(normalizedSearchInput);
    }, []);
-    const sortRates = useCallback((rates: RateForList[]) => rates.sort((a, b) => (a.rate ?? 0) - (b.rate ?? 0)), []);
+    const sortRates = useCallback((rates: RateForList[]) => rates, []);


This sorting does not match with other pages and it results in changed order on reconnect. This caused #68700

Ollyws · 2025-11-11T07:29:31Z

We neglected to add a pending action for when a distance rate is added offline so we added this in #73281

thesahindia · 2026-06-08T23:58:02Z

The translation wasn't added for distance rate rename action which caused #91204.

mkzie2 added 5 commits May 22, 2025 07:34

feat: implement distance rate name edit page

b3a3426

add rate name to rate list

42eb88d

show rate value

f2dc003

fix existing name error

f0b594c

fix lint

ff9ea78

mkzie2 marked this pull request as ready for review May 22, 2025 00:52

mkzie2 requested a review from a team as a code owner May 22, 2025 00:52

melvin-bot Bot requested review from ishpaul777 and removed request for a team May 22, 2025 00:52

twisterdotcom mentioned this pull request May 27, 2025

[$250] Distance rates-Distance rates are placed randomly in the table after clearing cache #62836

Closed

8 tasks

Merge branch 'main' of github.com-mkzie2:mkzie2/App into mkzie2-issue…

f5a1808

…/62099

mkzie2 added 2 commits June 26, 2025 20:26

Merge branch 'main' of github.com-mkzie2:mkzie2/App into mkzie2-issue…

391ffa9

…/62099

remove default rate name

acfd692

mkzie2 added 2 commits June 26, 2025 21:11

generate translations

2d964c7

fix namespace imports and canBeMissing lints

ec42019

MonilBhavsar self-requested a review July 18, 2025 13:16

mkzie2 added 2 commits July 23, 2025 16:25

Merge branch 'main' of github.com-mkzie2:mkzie2/App into mkzie2-issue…

710746b

…/62099

sort the rates by creation time

8f83a60

Merge branch 'main' of github.com-mkzie2:mkzie2/App into mkzie2-issue…

1bd4411

…/62099

ishpaul777 reviewed Jul 25, 2025

View reviewed changes

mkzie2 added 5 commits July 28, 2025 13:53

Merge branch 'main' of github.com-mkzie2:mkzie2/App into mkzie2-issue…

6100f93

…/62099

extract common distance rate update logic

cd99ef4

Merge branch 'main' of github.com-mkzie2:mkzie2/App into mkzie2-issue…

49da150

…/62099

fix lint

989750d

generate translations

9b780a8

ishpaul777 reviewed Jul 29, 2025

View reviewed changes

remove TODO

b9e5b9f

MonilBhavsar approved these changes Jul 31, 2025

View reviewed changes

MonilBhavsar merged commit b06fb0d into Expensify:main Jul 31, 2025
1 check passed

github-actions Bot mentioned this pull request Jul 31, 2025

Deploy Checklist: New Expensify 2025-07-31 #67499

Closed

90 tasks

parasharrajat reviewed Aug 28, 2025

View reviewed changes

Ollyws mentioned this pull request Nov 11, 2025

[Due for payment 2025-11-07] [$250] Distance - No offline pending feedback when distance rate name is edited offline #72410

Closed

16 tasks

MelvinBot mentioned this pull request Jun 5, 2026

[Due for payment 2026-06-08] [$250] Web - Workspace - The distance rate rename action is not translated in the thread #91204

Closed

7 tasks

		// TODO: Confirm max length
		// Uses the spread syntax to count the number of Unicode code points instead of the number of UTF-16 code units.

Uh oh!

Conversation

mkzie2 commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 22, 2025

Uh oh!

ishpaul777 commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ishpaul777 commented May 27, 2025

Uh oh!

ishpaul777 commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ishpaul777 commented May 30, 2025

Uh oh!

mkzie2 commented Jun 2, 2025

Uh oh!

mkzie2 commented Jun 3, 2025

Uh oh!

ishpaul777 commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ishpaul777 commented Jun 6, 2025

Uh oh!

mkzie2 commented Jun 9, 2025

Uh oh!

ishpaul777 commented Jun 12, 2025

Uh oh!

mkzie2 commented Jun 17, 2025

Uh oh!

ishpaul777 commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkzie2 commented Jun 25, 2025

Uh oh!

mkzie2 commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkzie2 commented Jul 16, 2025

Uh oh!

MonilBhavsar commented Jul 18, 2025

Uh oh!

ishpaul777 commented Jul 21, 2025

Uh oh!

mkzie2 commented Jul 23, 2025

Uh oh!

mkzie2 commented Jul 23, 2025

Uh oh!

MonilBhavsar commented Jul 24, 2025

Uh oh!

ishpaul777 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mkzie2 commented May 22, 2025 •

edited

Loading

ishpaul777 commented May 27, 2025 •

edited

Loading

ishpaul777 commented May 28, 2025 •

edited

Loading

ishpaul777 commented Jun 4, 2025 •

edited

Loading

ishpaul777 commented Jun 25, 2025 •

edited

Loading

mkzie2 commented Jun 26, 2025 •

edited

Loading

mkzie2 Jul 28, 2025 •

edited

Loading