Skip to content

fix: linked message is not highlighted in money request report #61527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srikarparsi merged 2 commits into from
May 6, 2025
+18 −1
Merged

fix: linked message is not highlighted in money request report #61527

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33a1b16
fix: linked message is not highlighted in money request report
mkzie2 May 6, 2025
3953dca
fix lint
mkzie2 May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import type {ListRenderItemInfo} from '@react-native/virtualized-lists/Lists/VirtualizedList';
import {useRoute} from '@react-navigation/native';
import isEmpty from 'lodash/isEmpty';
import React, {useCallback, useEffect, useLayoutEffect, useMemo, useRef, useState} from 'react';
import type {NativeScrollEvent, NativeSyntheticEvent} from 'react-native';
Expand Down Expand Up @@ -26,6 +27,8 @@ import DateUtils from '@libs/DateUtils';
import {parseFSAttributes} from '@libs/Fullstory';
import getNonEmptyStringOnyxID from '@libs/getNonEmptyStringOnyxID';
import {isActionVisibleOnMoneyRequestReport} from '@libs/MoneyRequestReportUtils';
import type {PlatformStackRouteProp} from '@libs/Navigation/PlatformStackNavigation/types';
import type {ReportsSplitNavigatorParamList} from '@libs/Navigation/types';
import {
getFirstVisibleReportActionID,
getMostRecentIOURequestActionID,
Expand All @@ -44,6 +47,7 @@ import shouldDisplayNewMarkerOnReportAction from '@pages/home/report/shouldDispl
import {openReport, readNewestAction, subscribeToNewActionEvent} from '@userActions/Report';
import CONST from '@src/CONST';
import ONYXKEYS from '@src/ONYXKEYS';
import type SCREENS from '@src/SCREENS';
import type * as OnyxTypes from '@src/types/onyx';
import {useMoneyRequestReportContext} from './MoneyRequestReportContext';
import MoneyRequestReportTransactionList from './MoneyRequestReportTransactionList';
Expand Down Expand Up @@ -92,8 +96,10 @@ function MoneyRequestReportActionsList({report, policy, reportActions = [], tran
const {preferredLocale} = useLocalize();
const {isOffline, lastOfflineAt, lastOnlineAt} = useNetworkWithOfflineStatus();
const reportScrollManager = useReportScrollManager();
const route = useRoute<PlatformStackRouteProp<ReportsSplitNavigatorParamList, typeof SCREENS.REPORT>>();

const reportID = report?.reportID;
const linkedReportActionID = route?.params?.reportActionID;

const [parentReportAction] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${getNonEmptyStringOnyxID(report?.parentReportID)}`, {
canEvict: false,
Expand Down Expand Up @@ -364,10 +370,21 @@ function MoneyRequestReportActionsList({report, policy, reportActions = [], tran
shouldDisplayReplyDivider={visibleReportActions.length > 1}
isFirstVisibleReportAction={firstVisibleReportActionID === reportAction.reportActionID}
shouldHideThreadDividerLine
linkedReportActionID={linkedReportActionID}
/>
);
},
[visibleReportActions, reportActions, parentReportAction, report, transactionThreadReport, mostRecentIOUReportActionID, unreadMarkerReportActionID, firstVisibleReportActionID],
[
visibleReportActions,
reportActions,
parentReportAction,
report,
transactionThreadReport,
mostRecentIOUReportActionID,
unreadMarkerReportActionID,
firstVisibleReportActionID,
linkedReportActionID,
],
);

const scrollToBottomAndMarkReportAsRead = useCallback(() => {
Expand Down