[CP Staging] Fix bug when app freezes after selecting a report item by jmusial · Pull Request #61055 · Expensify/App

jmusial · 2025-04-29T09:25:49Z

Explanation of Change

Fixes a bug when app freezes after selecting a report on small screens.

Fixed Issues

$ https://github.com/Expensify/App/issues/60977

PROPOSAL:

N/A

Tests

For the web: visible only on narrow screen

Log in to the app
Go to Reports
On the list long press an item
Modal appears
Click select

Offline tests

Same as tests

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Amdroid_Native.mov

Android: mWeb Chrome

Android_Chrome.mov

iOS: Native

Ios_native.mov

iOS: mWeb Safari

Ios_safari.mov

MacOS: Chrome / Safari

Web.mov

MacOS: Desktop

melvin-bot · 2025-04-29T10:07:01Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2025-04-29T10:09:26Z

@s77rt
Sorry
But this is a regression from my PR
I will review this PR

ZhenjaHorbach · 2025-04-29T10:09:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

2025-04-29.10.49.57.mov

Android: mWeb Chrome

2025-04-29.10.43.16.mov

iOS: Native

2025-04-29.10.19.55.mov

iOS: mWeb Safari

2025-04-29.10.24.41.mov

MacOS: Chrome / Safari

2025-04-29.10.37.51.mov

Details

2025-04-29.10.37.51.mov

ZhenjaHorbach · 2025-04-29T10:28:41Z

@jmusial
Could you make one more thing, please ?

Update this
https://github.com/Expensify/App/pull/61055/files#diff-45b3b78b48b630c32789e00793e0c947cc46c853d057e945f0ecdd0287ebb750R550

to

shouldPreventLongPressRow={isChat || isTask}

ZhenjaHorbach · 2025-04-29T10:35:42Z

LGTM !

ZhenjaHorbach · 2025-04-29T10:36:20Z

CC: @mountiny

mountiny

Thank you

mountiny · 2025-04-29T11:14:44Z

    const isChat = type === CONST.SEARCH.DATA_TYPES.CHAT;
    const isTask = type === CONST.SEARCH.DATA_TYPES.TASK;
-    const canSelectMultiple = !isChat && !isTask && isLargeScreenWidth;
+    const canSelectMultiple = !isChat && !isTask && (!isSmallScreenWidth || selectionMode?.isEnabled === true);


Would be nice to move the isChat || isTask into a separate variable since its reused here (inverted)

…es-after-select-on-reports [CP Staging] Fix bug when app freezes after selecting a report item (cherry picked from commit b1fcf20) (CP triggered by mountiny)

OSBotify · 2025-04-29T11:27:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-29T12:25:20Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.33-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2025-04-29T19:59:19Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.35-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2025-04-29T20:54:18Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.36-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2025-04-29T22:20:19Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.37-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2025-04-30T00:48:25Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.37-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

fix bug when app freezes after selecting a report item

f7fe9af

jmusial marked this pull request as ready for review April 29, 2025 10:06

jmusial requested a review from a team as a code owner April 29, 2025 10:06

melvin-bot Bot requested review from s77rt and removed request for a team April 29, 2025 10:06

prevent long press on task report type

ea0daa4

ZhenjaHorbach approved these changes Apr 29, 2025

View reviewed changes

melvin-bot Bot requested a review from cead22 April 29, 2025 10:35

mountiny assigned jmusial Apr 29, 2025

mountiny removed the request for review from s77rt April 29, 2025 11:11

mountiny changed the title ~~Fix bug when app freezes after selecting a report item~~ [CP Staging] Fix bug when app freezes after selecting a report item Apr 29, 2025

mountiny approved these changes Apr 29, 2025

View reviewed changes

mountiny merged commit b1fcf20 into Expensify:main Apr 29, 2025

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Apr 29, 2025

github-actions Bot mentioned this pull request Apr 29, 2025

Deploy Checklist: New Expensify 2025-04-28 #60971

Closed

Julesssss mentioned this pull request Apr 30, 2025

[Due for payment 2025-05-28] Refactor checklist workflow to use Github API instead of local git #60687

Closed

melvin-bot Bot mentioned this pull request May 1, 2025

[Due for payment 2025-05-08] Reports - App freezes after tapping Select option #60977

Closed

8 tasks

jmusial deleted the bugfix/app-freezes-after-select-on-reports branch August 26, 2025 08:11

Uh oh!

Conversation

jmusial commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 29, 2025

Uh oh!

ZhenjaHorbach commented Apr 29, 2025

Uh oh!

ZhenjaHorbach commented Apr 29, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Apr 29, 2025

Uh oh!

ZhenjaHorbach commented Apr 29, 2025

Uh oh!

ZhenjaHorbach commented Apr 29, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 29, 2025

Uh oh!

github-actions Bot commented Apr 29, 2025

Uh oh!

github-actions Bot commented Apr 29, 2025

Uh oh!

github-actions Bot commented Apr 29, 2025

Uh oh!

github-actions Bot commented Apr 29, 2025

Uh oh!

github-actions Bot commented Apr 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jmusial commented Apr 29, 2025 •

edited

Loading