Clear selection on navigation by jnowakow · Pull Request #60258 · Expensify/App

jnowakow · 2025-04-15T09:17:30Z

cc @mountiny @WojtekBoman @adamgrzybowski

Explanation of Change

Fixed Issues

$ #59833
PROPOSAL: N/A

Tests

Go to Reports -> Expense Reports.
Open Report.
Select Transactions
Open RHP
Verify that selection is not cleared
Go to any other screen and return to Report view.
Verify that selection is cleared.

Verify that no errors appear in the JS console

Offline tests

Go to Reports -> Expense Reports.
Open Report.
Select Transactions
Open RHP
Verify that selection is not cleared
Go to any other screen and return to Report view.
Verify that selection is cleared.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Go to Reports -> Expense Reports.
Open Report.
Select Transactions
Open RHP
Verify that selection is not cleared
Go to any other screen and return to Report view.
Verify that selection is cleared.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2025-04-15T09:18:03Z

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2025-04-15T09:26:58Z

+        // eslint-disable-next-line react-compiler/react-compiler
+        // eslint-disable-next-line react-hooks/exhaustive-deps


For each of the eslint disable we are trying to add a comment explaining why it has to be done - can you add it here? Can you also add it the eslint disable on one line only please

github-actions · 2025-04-15T09:27:31Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

Kicu

Looks good, although 2 effects that do similar things and both need to disable eslint rules, are kinda confusing 😅

Kicu · 2025-04-15T09:29:21Z


+    const focusedRoot = useRootNavigationState((state) => findFocusedRoute(state));
+
+    useEffect(() => {


I'd drop a simple 1-line comment describing what this does.
Something like

// we clear selected state in cases of X,Y but don't want to clean it when Z

github-actions · 2025-04-15T10:09:51Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/60258-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/60258-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/60258/NewExpensify.dmg	https://60258.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

jnowakow · 2025-04-15T10:13:48Z

Okey I have to dig further because it's possible to navigate further in RHP and this breaks selection:

tarapaty.mov

cc @mountiny @Kicu

Kicu · 2025-04-15T10:38:15Z

At this point I wonder if the idea that we want to implement here is not too confusing.
We want to clean the selection state on some navigation transitions but not on the other ones. It feels to me like this will be a source of regressions, where further changes in navigation structure in future might break these checkboxes.

Is it possible to somehow simplify? IE always clean them or never clean them? any thoughts @mountiny ?

jnowakow · 2025-04-15T11:26:15Z

With great help from @WojtekBoman I found a better solution

Kicu

LGTM and seems simpler 👍 very nice

jnowakow · 2025-04-16T10:46:44Z

bump @mountiny

mountiny · 2025-04-16T19:52:58Z

Asking if @DylanDylann or @allgandalf will take it

allgandalf · 2025-04-17T11:34:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Cannot test on small screens

Android: mWeb Chrome

Cannot test on small screens

iOS: Native

Cannot test on small screens

iOS: mWeb Safari

Cannot test on small screens

MacOS: Chrome / Safari

Screen.Recording.2025-04-17.at.7.14.21.PM.mov

MacOS: Desktop

Screen.Recording.2025-04-17.at.7.35.08.PM.mov

mountiny

Nice simplification! thanks!

OSBotify · 2025-04-17T14:31:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-18T20:42:27Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.30-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-21T23:21:07Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.1.30-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Clear selection on navigation

d758ff3

jnowakow requested a review from a team as a code owner April 15, 2025 09:17

melvin-bot Bot requested review from srikarparsi and removed request for a team April 15, 2025 09:18

mountiny requested review from mountiny and removed request for srikarparsi April 15, 2025 09:25

mountiny assigned jnowakow Apr 15, 2025

mountiny reviewed Apr 15, 2025

View reviewed changes

Kicu reviewed Apr 15, 2025

View reviewed changes

Better fix

00d20d9

nkdengineer mentioned this pull request Apr 15, 2025

[Due for payment 2025-05-05] [$250] Expense Reports - "1 selected" button appears in one-expense report view in Reports and Inbox #60100

Closed

2 of 8 tasks

jnowakow requested review from Kicu and mountiny April 15, 2025 12:53

Kicu approved these changes Apr 15, 2025

View reviewed changes

mountiny requested a review from allgandalf April 16, 2025 20:08

allgandalf approved these changes Apr 17, 2025

View reviewed changes

mountiny approved these changes Apr 17, 2025

View reviewed changes

mountiny merged commit bc9e951 into Expensify:main Apr 17, 2025

github-actions Bot mentioned this pull request Apr 18, 2025

Deploy Checklist: New Expensify 2025-04-18 #60506

Closed

64 tasks done

melvin-bot Bot mentioned this pull request Apr 21, 2025

[Due for payment 2025-04-28] [Better Expense Report View] Checkbox state is not reset after switching tabs #59833

Closed

2 of 18 tasks

		// eslint-disable-next-line react-compiler/react-compiler
		// eslint-disable-next-line react-hooks/exhaustive-deps


		const focusedRoot = useRootNavigationState((state) => findFocusedRoute(state));

		useEffect(() => {

Conversation

jnowakow commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 15, 2025

Uh oh!

mountiny Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 15, 2025

Uh oh!

Kicu left a comment

Choose a reason for hiding this comment

Uh oh!

Kicu Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 15, 2025

Uh oh!

jnowakow commented Apr 15, 2025

Uh oh!

Kicu commented Apr 15, 2025

Uh oh!

jnowakow commented Apr 15, 2025

Uh oh!

Kicu left a comment

Choose a reason for hiding this comment

Uh oh!

jnowakow commented Apr 16, 2025

Uh oh!

mountiny commented Apr 16, 2025

Uh oh!

allgandalf commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 17, 2025

Uh oh!

github-actions Bot commented Apr 18, 2025

Uh oh!

github-actions Bot commented Apr 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jnowakow commented Apr 15, 2025 •

edited

Loading

allgandalf commented Apr 17, 2025 •

edited

Loading