feat: update user to member in invite text - #60006
Conversation
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Update: I fixed unit test. |
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid.mp4Android: mWeb Chromeandroid-mweb.mp4iOS: Nativeios.mp4iOS: mWeb Safariios-mweb.mp4MacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
|
@truph01 🟢 PR looks and tests well, but I had difficulties testing due to the lack of clear steps (this is important for QA team as well). Before I can Approve, please update the testing steps, simply copy/paste the markdown below: Preview
1. **On User A account**, start a new chat:
- Click **"Start a Chat" > "Room"**
- Enter a **room name**
- Choose a **workspace**
- Set **Who can post**: All members
- Set **Visibility**: Workspace
2. **User A invites User B** to the room:
- Note: User B is **not a workspace member** and **not a room member** yet.
3. **User B invites User C** to the same room:
- Note: User C is also **not a workspace member** and **not a room member**.
4. **As User B, observethe Left-Hand Navigation (LHN)**:
- After **1 member is invited**, the **preview message** should read:
`... invited 1 member`
- After **2 members are invited at the same time**, the **preview message** should read:
`... invited 2 members` |
|
@ikevin127 Thanks for the detailed test steps! I've just updated my checklist accordingly. |
There was a problem hiding this comment.
Thanks for the update!
cc @jasperhuangg take it over!
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.1.28-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.28-15 🚀
|
Explanation of Change
Fixed Issues
$ #57853
PROPOSAL: #57853 (comment)
Tests
On User A account, start a new chat:
User A invites User B to the room:
User B invites User C to the same room:
As User B, observethe Left-Hand Navigation (LHN):
... invited 1 member... invited 2 membersOffline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
On User A account, start a new chat:
User A invites User B to the room:
User B invites User C to the same room:
As User B, observethe Left-Hand Navigation (LHN):
... invited 1 member... invited 2 membersPR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-04-10.at.16.42.51.mov
Android: mWeb Chrome
Screen.Recording.2025-04-10.at.16.44.34.mov
iOS: Native
Screen.Recording.2025-04-10.at.16.46.17.mov
iOS: mWeb Safari
Screen.Recording.2025-04-10.at.16.50.10.mov
MacOS: Chrome / Safari
Screen.Recording.2025-04-10.at.16.39.56.mov
MacOS: Desktop
Screen.Recording.2025-04-10.at.16.48.42.mov