Rewrite video player & its context logic by JakubKorytko · Pull Request #59896 · Expensify/App

JakubKorytko · 2025-04-09T10:19:56Z

Explanation of Change

This PR rewrites the logic of the video player and its context, making video player work properly in the following cases (on both wide screens & narrow layouts):

Fixed Issues

$ #59774
$ #57731
PROPOSAL: N/A

Tests

[Chats (inbox)]

Open any chat
Upload video
Play video
Verify it plays correctly
Open this video in a thread
Upload a video again in the thread
Verify that both videos play correctly.
Open the second video thread
Verify that both videos play correctly here as well.

[Chats via search]

Open reports
Select chats
Find uploaded video
Verify it plays properly

[New report view]

Open reports again
Open Expense Reports
Select any report with uploaded video
Verify it plays properly here as well

[RHP]

Open reports one more time
Select expenses
Open report with a video in RHP
Verify that video plays correctly there too

After every check you should also:

Refresh page
Verify that video still plays after refresh

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android-1-compressed.mov

Android-2.mov

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Web-1.mov

Web-2-compressed.mov

MacOS: Desktop

melvin-bot · 2025-04-09T10:20:01Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2025-04-10T09:56:14Z

Discovered some problems on mobile. Discussin with the author on Slack

github-actions · 2025-04-11T13:10:49Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

github-actions · 2025-04-11T13:49:59Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/59896-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/59896-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/59896/NewExpensify.dmg	https://59896.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

Skalakid

Left some small comments, I really like how you broke this context into smaller parts. Good job!

DylanDylann · 2025-04-14T14:49:15Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-04-14.at.17.26.36.mov

Android: mWeb Chrome

Screen.Recording.2025-04-14.at.17.14.06.mov

iOS: Native

Screen.Recording.2025-04-14.at.17.16.37.mov

iOS: mWeb Safari

Screen.Recording.2025-04-14.at.17.14.45.mov

MacOS: Chrome / Safari

Screen.Recording.2025-04-14.at.17.27.39.mov

MacOS: Desktop

Screen.Recording.2025-04-14.at.17.40.40.mov

mountiny

Only one NAB, changes look good to me, thank you for refactoring this

mountiny · 2025-04-14T15:36:52Z

+
+const screensWithReportID = [SCREENS.SEARCH.REPORT_RHP, SCREENS.REPORT, SCREENS.SEARCH.MONEY_REQUEST_REPORT, SCREENS.ATTACHMENTS];
+
+function hasReportIdInRouteParams(route: SearchRoute): route is RouteWithReportIDInParams<SearchRoute> {


Suggested change

function hasReportIdInRouteParams(route: SearchRoute): route is RouteWithReportIDInParams<SearchRoute> {

function hasReportIDInRouteParams(route: SearchRoute): route is RouteWithReportIDInParams<SearchRoute> {

OSBotify · 2025-04-14T15:50:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-14T23:17:40Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.28-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-16T22:13:52Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.28-15 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Fix video in chat reports, RHP & on first load

e58060c

JakubKorytko requested a review from a team as a code owner April 9, 2025 10:19

melvin-bot Bot requested review from DylanDylann and removed request for a team April 9, 2025 10:19

Remove unnecessary conditional change

fac07e9

This comment was marked as outdated.

Sign in to view

Merge branch 'main' into korytko/video-fix-followup

9a308a3

DylanDylann reviewed Apr 10, 2025

View reviewed changes

Comment thread src/components/SelectionList/ChatListItem.tsx Outdated

JakubKorytko added 5 commits April 10, 2025 23:06

Refractor video player

b8913f3

Merge branch 'main' into korytko/video-fix-followup

65aa95a

Merge branch 'main' into korytko/video-fix-followup

b68d713

Rebuild Video Player logic

6acee66

Fix semantics

712c009

JakubKorytko changed the title ~~[Better Expense Report View] Fix video player in Reports Chats, RHP & on first page load~~ Refractor video player & its context logic Apr 11, 2025

JakubKorytko changed the title ~~Refractor video player & its context logic~~ Rewrite video player & its context logic Apr 11, 2025

mountiny assigned JakubKorytko Apr 11, 2025

mountiny requested a review from DylanDylann April 11, 2025 13:10

Skalakid reviewed Apr 11, 2025

View reviewed changes

Fix Skalakid PR comments

f53c782

DylanDylann approved these changes Apr 14, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny April 14, 2025 15:02

mountiny approved these changes Apr 14, 2025

View reviewed changes

mountiny merged commit cc0ebe5 into Expensify:main Apr 14, 2025

github-actions Bot mentioned this pull request Apr 15, 2025

Deploy Checklist: New Expensify 2025-04-15 #60222

Closed

mollfpr mentioned this pull request Apr 15, 2025

[Due for payment 2025-04-25] Attachment - Video does not play in Send attachment modal after clicking play button #60223

Closed

8 tasks

marcaaron mentioned this pull request Apr 17, 2025

Android & iOS hybrid - Login - "Welcome to Expensify" modal is missing video #60448

Closed

18 tasks

linhvovan29546 mentioned this pull request Apr 23, 2025

[$250] Android & iOS - Onboarding - Volume button is not responsive in "Welcome to Expensify" video #60652

Closed

18 tasks


		const screensWithReportID = [SCREENS.SEARCH.REPORT_RHP, SCREENS.REPORT, SCREENS.SEARCH.MONEY_REQUEST_REPORT, SCREENS.ATTACHMENTS];

		function hasReportIdInRouteParams(route: SearchRoute): route is RouteWithReportIDInParams<SearchRoute> {

Conversation

JakubKorytko commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 9, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

DylanDylann commented Apr 10, 2025

Uh oh!

github-actions Bot commented Apr 11, 2025

Uh oh!

github-actions Bot commented Apr 11, 2025

Uh oh!

Skalakid left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DylanDylann commented Apr 14, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny Apr 14, 2025

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 14, 2025

Uh oh!

github-actions Bot commented Apr 14, 2025

Uh oh!

github-actions Bot commented Apr 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JakubKorytko commented Apr 9, 2025 •

edited

Loading