fix: correct go back behaviour for workspace list page by daledah · Pull Request #59874 · Expensify/App

daledah · 2025-04-09T06:45:12Z

Explanation of Change

Fixed Issues

$ #59686
PROPOSAL: #59686 (comment)

Tests

Login using new account
Tap FAB -> Start chat -> Room
Tap Learn more
Tap App back button
Tap Learn more again
Tap device back button
Verify that: In step 5 & 7 user is redirected back to "no workspace found" page.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Login using new account
Tap FAB -> Start chat -> Room
Tap Learn more
Tap App back button
Tap Learn more again
Tap device back button
Verify that: In step 5 & 7 user is redirected back to "no workspace found" page.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-04-09.at.13.45.15.mov

Android: mWeb Chrome

Screen.Recording.2025-04-09.at.13.48.18.mov

iOS: Native

Screen.Recording.2025-04-09.at.13.48.56.mov

iOS: mWeb Safari

Screen.Recording.2025-04-09.at.13.49.21.mov

MacOS: Chrome / Safari

Screen.Recording.2025-04-09.at.13.49.50.mov

MacOS: Desktop

Screen.Recording.2025-04-09.at.13.50.10.mov

melvin-bot · 2025-04-09T07:39:15Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rushatgabhane · 2025-04-15T20:19:55Z

reviewing

rushatgabhane · 2025-04-15T20:20:08Z

@daledah could you please fix the conflicts in the meantime, ty!

daledah · 2025-04-16T07:50:58Z

@rushatgabhane I updated.

daledah · 2025-04-17T08:31:45Z

Oops just realized there's a new Lint rule.

rushatgabhane · 2025-04-17T10:23:02Z

thanks for taking care of it : )

rushatgabhane · 2025-04-17T11:25:31Z

-    const [formState] = useOnyx(ONYXKEYS.FORMS.NEW_ROOM_FORM, {initWithStoredValues: false});
-    const [session] = useOnyx(ONYXKEYS.SESSION);
-    const [activePolicyID] = useOnyx(ONYXKEYS.NVP_ACTIVE_POLICY_ID);
+    const [policies] = useOnyx(ONYXKEYS.COLLECTION.POLICY, {canBeMissing: false});


@daledah could you please set all of them to true
https://expensify.slack.com/archives/C01GTK53T8Q/p1744885971100709

Suggested change

const [policies] = useOnyx(ONYXKEYS.COLLECTION.POLICY, {canBeMissing: false});

const [policies] = useOnyx(ONYXKEYS.COLLECTION.POLICY, {canBeMissing: true});

I think from this point:

if the component calling this is the one loading the data by calling an action, then you should set this to true. If the component calling this does not load the data then you should set it to false

WorkspaceNewRoomPage doesn't "load" the data, because we don't call any APIs when opening this page, so here I think setting it to false is correct.

cool, let's make it all false then

I'll update activePolicyID. For the newRoomForm, its value can be missing when opening room page. We only set its value when submitting here:

App/src/pages/workspace/WorkspaceNewRoomPage.tsx

Line 91 in 717b77a

setNewRoomFormLoading();

Actually we set newRoomForm on mount here:

App/src/pages/workspace/WorkspaceNewRoomPage.tsx

Lines 114 to 116 in 717b77a

useEffect(() => {

clearNewRoomFormError();

}, []);

And I tried canBeMissing to false for this entry and didn't receive any alerts so I think it's safe? I'm not so sure anymore 😂

rushatgabhane

@daledah do you know what could be causing the screen flicker when going back to not found workspace page?

Screen.Recording.2025-04-17.at.13.28.50.mov

daledah · 2025-04-17T12:03:15Z

do you know what could be causing the screen flicker when going back to not found workspace page?

Not sure with this one yet, let me take a look. It happens on staging as well.

rushatgabhane · 2025-04-18T10:49:53Z

yeah it'll be great if we can fix that, the flicker isn't ideal.

btw, how to reproduct the flicker on staging?

daledah · 2025-04-21T05:22:11Z

btw, how to reproduct the flicker on staging?

The bug is not very noticeable in staging, I used an older laptop and can reproduce it.

daledah · 2025-04-22T10:51:39Z

Still looking, but I think it's a bug in the New room page itself and not related to changes in this PR.

rushatgabhane · 2025-04-24T09:25:26Z

but I think it's a bug in the New room page itself and not related to changes in this PR

could you please help me repro this? i want to confirm that it is not related to this PR, then we can merge this PR

rushatgabhane · 2025-04-24T09:25:32Z

i hope that makes sense

daledah · 2025-04-25T07:36:58Z

Reproduced in staging:

Screen.Recording.2025-04-25.at.14.34.22.mov

The effect is much more visible with slower devices.

daledah · 2025-04-25T07:38:03Z

I think it might be related to Tab Navigator in this page.

daledah · 2025-05-05T02:53:23Z

@rushatgabhane What's the next step here?

rushatgabhane · 2025-05-05T02:56:03Z

@daledah i will be approving the PR today

rushatgabhane · 2025-05-06T00:21:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

Screen.Recording.2025-05-06.at.02.24.58.mov

iOS: mWeb Safari

Screen.Recording.2025-05-06.at.02.26.12.mov

MacOS: Chrome / Safari

Screen.Recording.2025-05-06.at.02.23.13.mov

MacOS: Desktop

rushatgabhane

LGTM!

OSBotify · 2025-05-06T18:37:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-05-07T00:27:47Z

🚀 Deployed to staging by https://github.com/deetergp in version: 9.1.41-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-05-07T23:47:41Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.1.41-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

fix: correct go back behaviour for workspace list page

3dab9c5

daledah marked this pull request as ready for review April 9, 2025 07:39

daledah requested a review from a team as a code owner April 9, 2025 07:39

melvin-bot Bot requested a review from rushatgabhane April 9, 2025 07:39

melvin-bot Bot removed the request for review from a team April 9, 2025 07:39

daledah mentioned this pull request Apr 9, 2025

[Due for payment 2025-05-14] [$250] From workspaces page, tapping app's top left arrow directs to settings page #59686

Closed

3 of 8 tasks

Merge branch 'main' into fix/59686

5534415

daledah added 2 commits April 17, 2025 15:26

Merge branch 'main' into fix/59686

719b68c

fix: lint

12c9993

rushatgabhane reviewed Apr 17, 2025

View reviewed changes

rushatgabhane suggested changes Apr 17, 2025

View reviewed changes

fix: update canBeMissing value

b453f0b

Merge branch 'main' into fix/59686

78734ed

rushatgabhane approved these changes May 6, 2025

View reviewed changes

melvin-bot Bot requested a review from deetergp May 6, 2025 00:27

deetergp approved these changes May 6, 2025

View reviewed changes

deetergp merged commit 21b308e into Expensify:main May 6, 2025

github-actions Bot mentioned this pull request May 6, 2025

Deploy Checklist: New Expensify 2025-05-06 #61539

Closed

28 tasks done

jponikarchuk mentioned this pull request May 7, 2025

Room - "Learn more" button appears with a delay when navigating back by swiping to right #61560

Closed

1 of 8 tasks

	const [policies] = useOnyx(ONYXKEYS.COLLECTION.POLICY, {canBeMissing: false});
	const [policies] = useOnyx(ONYXKEYS.COLLECTION.POLICY, {canBeMissing: true});

Conversation

daledah commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 9, 2025

Uh oh!

rushatgabhane commented Apr 15, 2025

Uh oh!

rushatgabhane commented Apr 15, 2025

Uh oh!

daledah commented Apr 16, 2025

Uh oh!

daledah commented Apr 17, 2025

Uh oh!

rushatgabhane commented Apr 17, 2025

Uh oh!

rushatgabhane Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

daledah Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

rushatgabhane Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

daledah Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

daledah Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

rushatgabhane left a comment

Choose a reason for hiding this comment

Uh oh!

daledah commented Apr 17, 2025

Uh oh!

rushatgabhane commented Apr 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daledah commented Apr 21, 2025

Uh oh!

daledah commented Apr 22, 2025

Uh oh!

rushatgabhane commented Apr 24, 2025

Uh oh!

rushatgabhane commented Apr 24, 2025

Uh oh!

daledah commented Apr 25, 2025

Uh oh!

daledah commented Apr 25, 2025

Uh oh!

daledah commented May 5, 2025

Uh oh!

rushatgabhane commented May 5, 2025

Uh oh!

rushatgabhane commented May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

rushatgabhane left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented May 6, 2025

Uh oh!

github-actions Bot commented May 7, 2025

Uh oh!

github-actions Bot commented May 7, 2025

Uh oh!

Reviewers

Assignees

Labels

daledah commented Apr 9, 2025 •

edited

Loading

rushatgabhane Apr 17, 2025 •

edited

Loading

rushatgabhane commented Apr 18, 2025 •

edited

Loading

rushatgabhane commented May 6, 2025 •

edited

Loading