fix: Rules - No space between currency sign and amount in RHP field “Amount” by Krishna2323 · Pull Request #59792 · Expensify/App

Krishna2323 · 2025-04-08T08:46:14Z

Explanation of Change

Fixed Issues

$ #58942
PROPOSAL: #58942 (comment)

Tests

Create WS with KZT currency
Navigate to WS settings
Turn on Rules in More features
Go to Rules
Click on the "Receipt required amount" field
Verify the "Amount" input field has spacing between currency symbol (prefix) and input value
Verify currency symbol (prefix) and amount value is vertically aligned.

Verify that no errors appear in the JS console

Offline tests

Create WS with KZT currency
Navigate to WS settings
Turn on Rules in More features
Go to Rules
Click on the "Receipt required amount" field
Verify the "Amount" input field has spacing between currency symbol (prefix) and input value
Verify currency symbol (prefix) and amount value is vertically aligned.

QA Steps

Create WS with KZT currency
Navigate to WS settings
Turn on Rules in More features
Go to Rules
Click on the "Receipt required amount" field
Verify the "Amount" input field has spacing between currency symbol (prefix) and input value
Verify currency symbol (prefix) and amount value is vertically aligned.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_safari.mp4

iOS: mWeb Safari

ios_safari_org.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

…Amount” Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot · 2025-04-08T08:46:18Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot · 2025-04-08T12:27:51Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Krishna2323 · 2025-04-08T12:31:49Z

@Expensify/design, please take a look at the recordings 👀

The spacing and vertical alignment between currency and amount was the issue:

shawnborton · 2025-04-08T12:32:17Z

        paddingBottom: 8,
    },

+    pb2half: {


Why do we need to adjust padding bottom here?

To fix the vertical alignment:

Which thing are you adjusting though? Are you adjusting the currency symbol or the input?

Also, what happens when the currency is multiple letters/symbols?

Which thing are you adjusting though? Are you adjusting the currency symbol or the input?

I have adjusted the currency symbol by updating padding bottom from 8px to 10px.

Also, what happens when the currency is multiple letters/symbols?

Monosnap.screencast.2025-04-10.10-58-21.mp4

Interesting, I'm surprised we didn't just use flexbox here so we didn't need to do custom padding calculations.

Interesting, I'm surprised we didn't just use flexbox here so we didn't need to do custom padding calculations.

That's because we are using absolute positioning for the currency symbol so we need to calculate the padding for the amount.

Yes, what I am saying is that I am surprised that we chose that path instead of flexbox.

shawnborton · 2025-04-08T12:32:35Z

    },

+    pr0half: {
+        paddingRight: 2,


Where exactly are these half values being used? Are we sure we can't just use 4?

This was not needed, reverted.

shawnborton · 2025-04-08T12:32:42Z

    },

+    pl0half: {
+        paddingLeft: 2,


Same comment as above - why 2 and not 4?

The current padding is based on the left margin obtained from getCharacterPadding, which provides only an approximate value rather than an exact one. As a result, we previously needed additional padding. However, now that we have the exact width of the currency symbol and want to maintain the current spacing, we need to reduce the padding to 2.

Current spacing (previously it was 4px but now we need 2px to make it the same):

If we keep the previously value:

I think the previous value was totally fine personally. I don't think we need to adjust it.

Agree with that as well 👍

shawnborton · 2025-04-08T12:33:23Z

Hmm this feels like a ton of changes just to add a bit of spacing on the left? Maybe that's just me though...

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

dubielzyk-expensify · 2025-04-09T00:57:44Z

Hmm this feels like a ton of changes just to add a bit of spacing on the left? Maybe that's just me though...

There's multiple screenshots and adjustments happening above. What specifically are we referring to here?

shawnborton · 2025-04-09T06:27:25Z

I think the idea was to just create more space between the fixed currency symbol and the editable number input.

Krishna2323 · 2025-04-09T18:25:56Z

I think the idea was to just create more space between the fixed currency symbol and the editable number input.

I don't think that's a good idea, because if we just add more space, it will look weird when the currency has a single letter or symbol, and we've added space based on the longest currency code. That's why we need to get the exact width of the selected currency.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

dubielzyk-expensify · 2025-04-10T01:53:54Z

I dunno enough about the implications, but I guess my thought is that the spacing when you have a $ symbol seems fine, but the other symbol seems to almost overlap with the numbers. I don't think we need a fixed width, but some padding between the symbol and the currency is desired I think?

Krishna2323 · 2025-04-10T05:36:41Z

but some padding between the symbol and the currency is desired I think?

Yes, I have added 4px of padding as per this comment.

Monosnap.screencast.2025-04-10.10-58-21.mp4

shawnborton · 2025-04-10T07:18:09Z

Okay, can we resolve conflicts and get this prepped for another round of review? Sorry for all of the small comments but I just want to make sure we are taking the most simple approach here and not overcomplicating these inputs.

DylanDylann · 2025-04-10T10:05:39Z

        paddingBottom: 8,
    },

+    pb2half: {


Suggested change

pb2half: {

pb2_5: {

I still don't quite understand this one. Can you show me the before/after when this is and isn't applied?

Ahhh, It is not a bug, just a new idea about naming constant

@DylanDylann we need to name the variable pb2half else it would give lint error Object Literal Property name pb2_5 must match one of the following formats: camelCase, UPPER_CASE, PascalCase.

I'm still waiting to see a screenshot of before and after this addition. We didn't have this before, so I'm wondering why we need to add it now.

@shawnborton

Before

After

Got it, thanks for clarifying 👍

DylanDylann · 2025-04-10T10:21:06Z

@Krishna2323 Could you please resolve conflict?

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

DylanDylann · 2025-04-11T03:14:09Z

@Krishna2323 failed lint

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

DylanDylann · 2025-04-11T07:58:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

OSBotify · 2025-04-14T14:11:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-14T23:17:28Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 9.1.28-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-16T22:13:23Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.28-15 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

ikevin127 · 2025-04-23T00:43:47Z

-    const inputPaddingLeft = !!prefixCharacter && StyleUtils.getPaddingLeft(StyleUtils.getCharacterPadding(prefixCharacter) + styles.pl1.paddingLeft);
-    const inputPaddingRight = !!suffixCharacter && StyleUtils.getPaddingRight(StyleUtils.getCharacterPadding(suffixCharacter) + styles.pr1.paddingRight);
+    const inputPaddingLeft = !!prefixCharacter && StyleUtils.getPaddingLeft(prefixCharacterPadding + styles.pl1.paddingLeft);
+    const inputPaddingRight = !!suffixCharacter && StyleUtils.getPaddingRight(prefixCharacterPadding + styles.pr1.paddingRight);


The changes here led to the following issue:

[Due for payment 2025-04-25] Split - Individual split amount input is cut off #60240

which was addressed in a follow-up PR.

fix: Rules - No space between currency sign and amount in RHP field “…

f1068b0

…Amount” Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 added 3 commits April 8, 2025 14:45

fix padding on mobile chrome.

239a9e2

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

add different padding for amount input.

64106e7

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fix esLint.

d7bfdb6

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 marked this pull request as ready for review April 8, 2025 12:27

Krishna2323 requested review from a team as code owners April 8, 2025 12:27

melvin-bot Bot requested a review from DylanDylann April 8, 2025 12:27

melvin-bot Bot removed the request for review from a team April 8, 2025 12:27

shawnborton reviewed Apr 8, 2025

View reviewed changes

remove pr0half style.

de53308

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

minor update.

1dae707

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

DylanDylann reviewed Apr 10, 2025

View reviewed changes

Krishna2323 added 4 commits April 10, 2025 20:11

fix merge conflicts.

c99d439

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fix merge conflicts.

e613ad8

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fix merge conflicts.

63ee2bc

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Merge branch 'Expensify:main' into krishna2323/issue/58942

2461381

update variable name.

5024c36

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fix variable name.

ad76800

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

DylanDylann approved these changes Apr 11, 2025

View reviewed changes

melvin-bot Bot requested a review from madmax330 April 11, 2025 08:41

madmax330 approved these changes Apr 14, 2025

View reviewed changes

madmax330 merged commit db665c3 into Expensify:main Apr 14, 2025

github-actions Bot mentioned this pull request Apr 15, 2025

Deploy Checklist: New Expensify 2025-04-15 #60222

Closed

MariaHCD mentioned this pull request Apr 15, 2025

[Due for payment 2025-04-25] Split - Individual split amount input is cut off #60240

Closed

8 tasks

melvin-bot Bot mentioned this pull request Apr 16, 2025

[Due for payment 2025-04-23] [$250] Rules - No space between currency sign and amount in RHP field “Amount” #58942

Closed

8 tasks

ikevin127 reviewed Apr 23, 2025

View reviewed changes

Conversation

Krishna2323 commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 8, 2025

Uh oh!

melvin-bot Bot commented Apr 8, 2025

Uh oh!

Krishna2323 commented Apr 8, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Current spacing (previously it was 4px but now we need 2px to make it the same):

If we keep the previously value:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shawnborton commented Apr 8, 2025

Uh oh!

dubielzyk-expensify commented Apr 9, 2025

Uh oh!

shawnborton commented Apr 9, 2025

Uh oh!

Krishna2323 commented Apr 9, 2025

Uh oh!

dubielzyk-expensify commented Apr 10, 2025

Uh oh!

Krishna2323 commented Apr 10, 2025

Uh oh!

shawnborton commented Apr 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Before

After

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Apr 10, 2025

Uh oh!

DylanDylann commented Apr 11, 2025

Krishna2323 commented Apr 8, 2025 •

edited

Loading

DylanDylann commented Apr 11, 2025 •

edited

Loading