fix: show skeleton on search router by daledah · Pull Request #59789 · Expensify/App

daledah · 2025-04-08T07:44:07Z

Explanation of Change

Fixed Issues

$ #59253
PROPOSAL: #59253 (comment)

Tests

Login
Open search router
Verify that: Skeleton loading state appears

Verify that no errors appear in the JS console

Offline tests

QA Steps

Login
Open search router
Verify that: Skeleton loading state appears

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-04-08.at.13.52.44.mov

Android: mWeb Chrome

Screen.Recording.2025-04-08.at.13.53.17.mov

iOS: Native

Screen.Recording.2025-04-08.at.13.54.44.mov

iOS: mWeb Safari

Screen.Recording.2025-04-08.at.13.55.09.mov

MacOS: Chrome / Safari

Screen.Recording.2025-04-08.at.13.55.35.mp4

MacOS: Desktop

Screen.Recording.2025-04-08.at.13.56.29.mov

melvin-bot · 2025-04-08T08:39:18Z

@dannymcclain @Pujan92 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Pujan92 · 2025-04-08T10:06:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

am1.webm

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.-.2025-04-09.at.17.42.06.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.-.2025-04-09.at.17.44.14.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-04-09.at.16.11.14.mov

MacOS: Desktop

shawnborton · 2025-04-08T12:27:14Z

What speed are we using for the search router skeletons? Is it the same value we're using for chats? We recently made it slower, so just want to make sure we're aligned here. Thanks!

dannymcclain · 2025-04-08T13:05:50Z

What speed are we using for the search router skeletons? Is it the same value we're using for chats? We recently made it slower, so just want to make sure we're aligned here. Thanks!

+1. I also think this might be a nice place to use the static (non-animated) skeletons... just :my-2-cents:.

shawnborton · 2025-04-08T13:11:07Z

I don't mind that they are animated because it's actually loading and not offline. But I just want the speeds to be the same!

Pujan92 · 2025-04-08T19:12:52Z

What speed are we using for the search router skeletons? Is it the same value we're using for chats? We recently made it slower, so just want to make sure we're aligned here. Thanks!

No, it is using the common SelectionList component and chat is the different one. So for this, we don't have any speed set yet. It is the same with all other SelectionList components(eg. new chat)

Screen.Recording.2025-04-09.at.00.41.25.mov

dubielzyk-expensify · 2025-04-09T04:08:35Z

With Design that we should make sure the timing is the same even though it's using different components

Pujan92 · 2025-04-09T05:26:44Z

With Design that we should make sure the timing is the same even though it's using different components

Sure, @daledah could you also make this change by adding a new prop ~ loaderSpeed which needs to be applied for the search list loader?

shawnborton · 2025-04-09T06:32:16Z

Yup, that's exactly what I was thinking - basically pass in that same timing we are using elsewhere.

daledah · 2025-04-09T08:42:13Z

@Pujan92 I updated.

shawnborton · 2025-04-09T08:55:16Z

Let us know when you have an updated video to review, thanks!

shawnborton · 2025-04-09T08:55:32Z

And looks like we have some conflicts too.

daledah · 2025-04-09T10:30:47Z

@Pujan92 I updated.

Pujan92 · 2025-04-09T10:56:43Z

Let us know when you have an updated video to review, thanks!

@shawnborton plz review this video

Screen.Recording.2025-04-09.at.16.11.14.mov

shawnborton · 2025-04-09T15:01:04Z

Nice, I think that looks correct to me - cc @Expensify/design for the extra eyes too 👀

dannymcclain · 2025-04-09T15:02:03Z

Looking good to me

Pujan92

LGTM!

shawnborton · 2025-04-10T08:20:49Z

Nice, let's get this into final review please!

Pujan92 · 2025-04-10T15:47:10Z

latest Const change looks good to me.

Pujan92 · 2025-04-11T14:08:36Z

@shawnborton If it looks good the design team then can you plz approve so that the internal engineer gets assigned to review

shawnborton · 2025-04-11T14:33:43Z

Approved on my end

melvin-bot · 2025-04-11T14:33:55Z

@dannymcclain @jjcoffee One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2025-04-11T14:35:22Z

Hmm not sure why it assigned the way it did. @Pujan92 how do we normally get an internal engineer assigned?

shawnborton · 2025-04-11T14:36:00Z

Going to assign @mountiny since he was assigned to the original issue.

mountiny

Thank you all

OSBotify · 2025-04-14T12:41:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-14T23:17:25Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.28-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-16T22:13:19Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.28-15 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

sosek108 · 2025-06-04T08:12:17Z


    useEffect(() => {
-        if (!shouldInitialize || areOptionsInitialized) {
+        if (!shouldInitialize || areOptionsInitialized || isLoadingApp) {


this change causes #62335

fix: show skeleton on search router

6103391

daledah marked this pull request as ready for review April 8, 2025 08:39

daledah requested a review from a team as a code owner April 8, 2025 08:39

melvin-bot Bot requested review from Pujan92 and dannymcclain April 8, 2025 08:39

melvin-bot Bot removed the request for review from a team April 8, 2025 08:39

daledah mentioned this pull request Apr 8, 2025

[Due for payment 2025-04-23] [$250] Web - Options list does not displayed a skeleton loading state #59253

Closed

1 of 8 tasks

dannymcclain requested review from a team and removed request for dannymcclain April 8, 2025 13:04

mountiny assigned daledah Apr 8, 2025

Pujan92 reviewed Apr 8, 2025

View reviewed changes

Comment thread src/components/SelectionList/types.ts Outdated

daledah added 2 commits April 9, 2025 15:36

Merge branch 'main' into fix/59253

6fb2296

refactor: prop name, change skeleton speed

37d6b3d

Pujan92 reviewed Apr 9, 2025

View reviewed changes

Comment thread src/components/Skeletons/ItemListSkeletonView.tsx Outdated

daledah added 2 commits April 9, 2025 17:28

fix: add speed prop to SelectionList

d398896

Merge branch 'main' into fix/59253

9e4f9a4

shawnborton reviewed Apr 9, 2025

View reviewed changes

Comment thread src/components/Search/SearchAutocompleteList.tsx Outdated

Pujan92 approved these changes Apr 9, 2025

View reviewed changes

daledah added 2 commits April 10, 2025 15:11

Merge branch 'main' into fix/59253

e51a2c6

refactor: save animation speed as const

76d8fb9

shawnborton approved these changes Apr 11, 2025

View reviewed changes

shawnborton requested a review from a team April 11, 2025 14:33

melvin-bot Bot requested review from dannymcclain and jjcoffee and removed request for a team April 11, 2025 14:33

shawnborton requested review from mountiny and removed request for dannymcclain and jjcoffee April 11, 2025 14:35

mountiny approved these changes Apr 14, 2025

View reviewed changes

mountiny merged commit 8dd296b into Expensify:main Apr 14, 2025

github-actions Bot mentioned this pull request Apr 15, 2025

Deploy Checklist: New Expensify 2025-04-15 #60222

Closed

sosek108 mentioned this pull request Jun 3, 2025

[Due for payment 2025-08-26] [$250] Recent search history missing when opening search switcher before app reconnects #62335

Closed

2 of 16 tasks

sosek108 reviewed Jun 4, 2025

View reviewed changes

Conversation

daledah commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 8, 2025

Uh oh!

Pujan92 commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

shawnborton commented Apr 8, 2025

Uh oh!

dannymcclain commented Apr 8, 2025

Uh oh!

shawnborton commented Apr 8, 2025

Uh oh!

Pujan92 commented Apr 8, 2025

Uh oh!

Uh oh!

dubielzyk-expensify commented Apr 9, 2025

Uh oh!

Pujan92 commented Apr 9, 2025

Uh oh!

shawnborton commented Apr 9, 2025

Uh oh!

daledah commented Apr 9, 2025

Uh oh!

shawnborton commented Apr 9, 2025

Uh oh!

shawnborton commented Apr 9, 2025

Uh oh!

Uh oh!

daledah commented Apr 9, 2025

Uh oh!

Pujan92 commented Apr 9, 2025

Uh oh!

shawnborton commented Apr 9, 2025

Uh oh!

Uh oh!

dannymcclain commented Apr 9, 2025

Uh oh!

Pujan92 left a comment

Choose a reason for hiding this comment

Uh oh!

shawnborton commented Apr 10, 2025

Uh oh!

Pujan92 commented Apr 10, 2025

Uh oh!

Pujan92 commented Apr 11, 2025

Uh oh!

shawnborton commented Apr 11, 2025

Uh oh!

melvin-bot Bot commented Apr 11, 2025

Uh oh!

shawnborton commented Apr 11, 2025

Uh oh!

shawnborton commented Apr 11, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 14, 2025

Uh oh!

github-actions Bot commented Apr 14, 2025

Uh oh!

github-actions Bot commented Apr 16, 2025

Uh oh!

sosek108 Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

daledah commented Apr 8, 2025 •

edited

Loading

Pujan92 commented Apr 8, 2025 •

edited

Loading