Show green loader everywhere while showing skeleton loaders on the Reports page by thelullabyy · Pull Request #59578 · Expensify/App

thelullabyy · 2025-04-03T10:25:19Z

Explanation of Change

Fixed Issues

$#59261
PROPOSAL:#59261 (comment)

Tests

Open App
Open Reports Tab
Perform search some results
Verify green loader show below the Reports top page header while showing skeleton loaders

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open App
Open Reports Tab
Perform search some results
Verify green loader show below the Reports top page header while showing skeleton loaders

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

0f0602c9-9b71-4866-bc13-8f63335ab9d0.mp4

Android: mWeb Chrome

android_chorme.mov

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

chorme.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2025-04-03T10:33:30Z

@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

thesahindia · 2025-04-07T23:58:11Z

    shouldDisplaySearch?: boolean;
    shouldDisplayHelpButton?: boolean;
    cancelSearch?: () => void;
+    forceShowLoadingBar?: boolean;


Rename it to "shouldShowLoadingBar"

thesahindia · 2025-04-08T00:01:47Z

    }
+    const searchResults = currentSearchResults?.data ? currentSearchResults : lastNonEmptySearchResults;
+
+    const isDataLoaded =


Move this to a function in SearchUIUtils.ts.

@thesahindia I updated PR below. Pls help to check again.

thesahindia · 2025-04-08T13:19:52Z

I can see the loader even when not connected to the internet.

Screen.Recording.2025-04-08.at.6.44.41.PM.mov

@shawnborton, should the loading bar appear in the LHN and the chat screen?

shawnborton · 2025-04-08T13:21:00Z

I think on mobile, yes. What you are showing above seems correct to me? cc @Expensify/design for the gut check.

dannymcclain · 2025-04-08T13:56:12Z

I think on mobile, yes.

Agree

thesahindia · 2025-04-09T04:34:37Z

I can see the loader even when not connected to the internet.

Screen.Recording.2025-04-08.at.6.44.41.PM.mov

cc: @thelullabyy

thelullabyy · 2025-04-09T08:48:14Z

@thesahindia I suppose that your case isLoadingReportData is return true here and not belong to this issue. The current logic is always show the green loader when this variable is true. Can you check again if we want to hide loader in this case and i will update PR accordingly.

App/src/components/Navigation/TopBar.tsx

Line 32 in e8ac1a0

const [isLoadingReportData] = useOnyx(ONYXKEYS.IS_LOADING_REPORT_DATA);

thesahindia · 2025-04-09T10:48:36Z

an you check again if we want to hide loader in this case

I think we should to keep the behaviour same.

thesahindia · 2025-04-09T10:50:00Z

@shawnborton @dannymcclain, the loader shouldn't appear when the app is offline. Is that correct?

dannymcclain · 2025-04-09T13:27:08Z

the loader shouldn't appear when the app is offline. Is that correct?

🤔 Hmm, I don't think it should since we're not actually trying to fetch/load anything, right?

shawnborton · 2025-04-09T15:04:39Z

I can see in theory that if we know you are online, there is no sense in showing the green loading bar because it would just sit there and pulse forever, even though it can't actually finish up.

That being said, we currently display the green loading bar when offline on staging. So we could technically handle that as a follow up, since it's a bug that already exists. Or we can handle it here if you would like.

thesahindia · 2025-04-09T15:31:00Z

So we could technically handle that as a follow up, since it's a bug that already exists. Or we can handle it here if you would like.

cc: @thelullabyy

dubielzyk-expensify · 2025-04-10T02:02:59Z

Yeah, I don't mind where we solve it, but agree that it's generally weird if we show the green bar when we you're fully in offline mode.

thelullabyy · 2025-04-10T03:08:24Z

@thesahindia Thanks to clarify, i will update PR asap

thelullabyy · 2025-04-10T09:47:47Z

@thesahindia I update the PR and here is the result, can you take a look.

Screen.Recording.2025-04-10.at.16.35.22.mov

thesahindia · 2025-04-10T13:53:10Z

@thelullabyy, the issue is still reproducible. Steps to repro:

Go to settings > troubleshoot > Force offline
Go to any chat
Reload the app

Screen.Recording.2025-04-10.at.7.13.02.PM.mov

@thelullabyy, You can revert the recent changes since this case is out of scope. We can address this in a separate issue.

thelullabyy · 2025-04-11T13:53:52Z

@thesahindia completed. Pls help to check again. Thanks

thesahindia · 2025-04-11T17:12:30Z

Will test again on monday.

thesahindia · 2025-04-14T11:16:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-04-10.at.7.35.29.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-04-10.at.6.21.32.PM.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2025-04-10.at.6.59.58.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-04-08.at.5.52.11.PM.mov

MacOS: Desktop

Screen.Recording.2025-04-08.at.5.47.14.PM.mov

thesahindia

LGTM!

OSBotify · 2025-04-14T13:17:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-14T23:16:55Z

🚀 Deployed to staging by https://github.com/justinpersaud in version: 9.1.28-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-16T22:12:40Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.28-15 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

fix: add green loader while showing skeleton loaders on the Reports page

abd80bc

thelullabyy marked this pull request as ready for review April 3, 2025 10:33

thelullabyy requested a review from a team as a code owner April 3, 2025 10:33

melvin-bot Bot requested review from thesahindia and removed request for a team April 3, 2025 10:33

thesahindia suggested changes Apr 8, 2025

View reviewed changes

thelullabyy added 2 commits April 8, 2025 14:18

Merge branch 'main' into fix/59261-show-green-loader-everywhere

cb5ee26

refactor code

1d33d1b

thelullabyy added 2 commits April 10, 2025 16:27

Merge branch 'main' into fix/59261-show-green-loader-everywhere

b0dc0f3

fix: shouldn't show loader when offline

b4faeec

revert change with offline fixing

8241eeb

thesahindia approved these changes Apr 14, 2025

View reviewed changes

melvin-bot Bot requested a review from justinpersaud April 14, 2025 11:17

justinpersaud approved these changes Apr 14, 2025

View reviewed changes

justinpersaud merged commit f5f3af7 into Expensify:main Apr 14, 2025

github-actions Bot mentioned this pull request Apr 15, 2025

Deploy Checklist: New Expensify 2025-04-15 #60222

Closed

melvin-bot Bot mentioned this pull request Apr 16, 2025

[Due for payment 2025-04-23] [$250] Show green loader everywhere we're showing skeleton loaders on the Reports page #59261

Closed

Conversation

thelullabyy commented Apr 3, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 3, 2025

Uh oh!

thesahindia Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

thelullabyy Apr 8, 2025

Choose a reason for hiding this comment

Uh oh!

thesahindia Apr 8, 2025

Choose a reason for hiding this comment

Uh oh!

thelullabyy Apr 8, 2025

Choose a reason for hiding this comment

Uh oh!

thesahindia commented Apr 8, 2025

Uh oh!

shawnborton commented Apr 8, 2025

Uh oh!

dannymcclain commented Apr 8, 2025

Uh oh!

thesahindia commented Apr 9, 2025

Uh oh!

thelullabyy commented Apr 9, 2025

Uh oh!

thesahindia commented Apr 9, 2025

Uh oh!

thesahindia commented Apr 9, 2025

Uh oh!

dannymcclain commented Apr 9, 2025

Uh oh!

shawnborton commented Apr 9, 2025

Uh oh!

thesahindia commented Apr 9, 2025

Uh oh!

dubielzyk-expensify commented Apr 10, 2025

Uh oh!

thelullabyy commented Apr 10, 2025

Uh oh!

thelullabyy commented Apr 10, 2025

Uh oh!

thesahindia commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thelullabyy commented Apr 11, 2025

Uh oh!

thesahindia commented Apr 11, 2025

Uh oh!

thesahindia commented Apr 14, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

thesahindia left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 14, 2025

Uh oh!

github-actions Bot commented Apr 14, 2025

Uh oh!

github-actions Bot commented Apr 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

thesahindia commented Apr 10, 2025 •

edited

Loading