Repository navigation

Reuse Onyx's validateCodeAction everywhere for handling errors of magic code - #58934

Merged

amyevans merged 54 commits into

mainfrom

youssef_better_validation_error_handling

Apr 24, 2025

Merged

Reuse Onyx's validateCodeAction everywhere for handling errors of magic code#58934
amyevans merged 54 commits into
mainfrom
youssef_better_validation_error_handling

Commits on Mar 22, 2025
- Use VALIDATE_ACTION_CODE for storing/displaying magic code errors
  Youssef Lourayad
  committed
  7d5e470
- Remove unused function
  Youssef Lourayad
  committed
  f50c655
- Clearr both magic code and flow specific error onClose
  Youssef Lourayad
  committed
  4ee6648
- Use default for validateCodeActionErrorField
  Youssef Lourayad
  committed
  90117e7
- Clear validateCode errors properly
  Youssef Lourayad
  committed
  13e6928
- Pass validateCodeAction to ValidateCodeForm
  Youssef Lourayad
  committed
  c62a055
- Use magic code errors coming from PendingContactAction instead of loginList
  Youssef Lourayad
  committed
  a973516
- Lint
  Youssef Lourayad
  committed
  e321cc0
- Bring back prop validatePendingAction
  Youssef Lourayad
  committed
  0487f20
- Update comment
  Youssef Lourayad
  committed
  3a51c84
- Use validateCodeAction for handling magic code errors when reporting virtual card
  Youssef Lourayad
  committed
  2b1b74a
- Update comment
  Youssef Lourayad
  committed
  6e20b2f
- Don't remove virtual cards optimistically
  Youssef Lourayad
  committed
  480874a
- Fix virtual card modal closing when entering bad magic code
  Youssef Lourayad
  committed
  0c6009c
Commits on Mar 23, 2025
- Add validatePendingAction to props of ValidateCodeActionModal
  Youssef Lourayad
  committed
  cb32f5a
- Use validateCodeAction errors in copy codes page
  Youssef Lourayad
  committed
  947c170
- Don't make some props required
  Youssef Lourayad
  committed
  4727877
- Pass validateCodeAction so we can use the pending action
  Youssef Lourayad
  committed
  e7a471e
- Revert unneeded change
  Youssef Lourayad
  committed
  421e613
- Improve magic code error handling when reveal virtual card
  Youssef Lourayad
  committed
  ec9aed9
- Use validateCodeAction errors when adding delegate
  Youssef Lourayad
  committed
  02889a7
- Use validateCodeAction errors when updating delegate role
  Youssef Lourayad
  committed
  648f6f5
- Use validateCodeAction in remaining magic code modals
  Youssef Lourayad
  committed
  2355609
- Rename Onyx key
  Youssef Lourayad
  committed
  f5f2752
- Rename variable
  Youssef Lourayad
  committed
  2cad204
- Fix lint
  Youssef Lourayad
  committed
  86a25ed
Commits on Mar 24, 2025
- Clear magic code errors in BaseValidateCodeForm instead of parent components
  Youssef Lourayad
  committed
  14e6e01
- Lint
  Youssef Lourayad
  committed
  a776794
Commits on Mar 25, 2025
- Remove offline data from Onyx data when adding contact method as it's an online flow only
  Youssef Lourayad
  committed
  c588345
- Remove dead code
  Youssef Lourayad
  committed
  46416a2
- Merge branch 'main' into youssef_better_validation_error_handling
  Youssef Lourayad
  committed
  a4ee23f
- Revert unneeded change
  Youssef Lourayad
  committed
  4a22e09
- Use validateCodeAction in base componenet and don't require it for parent componenets
  Youssef Lourayad
  committed
  2b4900b
- Add missing props to validate modal of contact method details
  Youssef Lourayad
  committed
  fb58d6a
- Clean up no longer needed params/variables
  Youssef Lourayad
  committed
  3709509
- Lint
  Youssef Lourayad
  committed
  dc0e52c
- Allow pasing hasMagicCodeBeenSent when we're not getting it from validateCodeAction
  Youssef Lourayad
  committed
  21a9529
- Fix missing errorField prop
  Youssef Lourayad
  committed
  3fb94ba
Commits on Mar 27, 2025
- Merge branch 'main' into youssef_better_validation_error_handling
  Youssef Lourayad
  committed
  cc8475a
- Address comments
  Youssef Lourayad
  committed
  2af25c1
Commits on Apr 4, 2025
- Merge branch 'main' into youssef_better_validation_error_handling
  Youssef Lourayad
  committed
  7693118
- Fix no error shown in validate code modal when revealing card details
  Youssef Lourayad
  committed
  acb5032
- Cleanup
  Youssef Lourayad
  committed
  a5aa550
Commits on Apr 5, 2025
- Update comment
  Youssef Lourayad
  committed
  fd8581f
Commits on Apr 6, 2025
- Allow clearig validate error in reveal details page
  Youssef Lourayad
  committed
  a3bc4cd
Commits on Apr 7, 2025
- Also clear backend errors when submitting
  Youssef Lourayad
  committed
  2ce1dbc
- Merge branch 'main' into youssef_better_validation_error_handling
  Youssef Lourayad
  committed
  aeebe79
Commits on Apr 16, 2025
- Merge branch 'main' into youssef_better_validation_error_handling
  Youssef Lourayad
  committed
  6c29811
Commits on Apr 22, 2025
- Merge branch 'main' into youssef_better_validation_error_handling
  Youssef Lourayad
  committed
  2f64f56
- Update src/components/ValidateCodeActionModal/ValidateCodeForm/BaseValidateCodeForm.tsx
  
  Youssef Lourayad
  and
  amyevans
  authored
  9631c45
- Apply suggestions from code review
  
  Youssef Lourayad
  and
  amyevans
  authored
  a398641
- Lint
  Youssef Lourayad
  committed
  b067ea3
Commits on Apr 23, 2025
- Merge branch 'main' into youssef_better_validation_error_handling
  Youssef Lourayad
  committed
  07af406
- Use new method in BaseOnboardingWorkEmailValidation
  Youssef Lourayad
  committed
  4ce7a5b

Commits

Commits on Mar 22, 2025

Commits on Mar 23, 2025

Commits on Mar 24, 2025

Commits on Mar 25, 2025

Commits on Mar 27, 2025

Commits on Apr 4, 2025

Commits on Apr 5, 2025

Commits on Apr 6, 2025

Commits on Apr 7, 2025

Commits on Apr 16, 2025

Commits on Apr 22, 2025

Commits on Apr 23, 2025