Conversation
andriivitiv
force-pushed
the
58893-Add-renderer-for-the-`mention-short`-tag
branch
from
March 21, 2025 19:04
785bdea to
16b5257
Compare
It is added on Android Native and causes equality checks to fail. The same fix is applied in `MentionUserRenderer` and `MentionReportRenderer` files.
andriivitiv
marked this pull request as ready for review
March 21, 2025 21:21
melvin-bot
Bot
requested review from
shubham1206agra
and removed request for
a team
March 21, 2025 21:21
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
@CyberAndrii I am getting this error. Can you please look into this? Plus, this PR is failing on iOS: Native. |
Contributor
Reviewer Checklist
Screenshots/Videos |
Co-authored-by: Shubham Agrawal <58412969+shubham1206agra@users.noreply.github.com>
shubham1206agra
approved these changes
Mar 27, 2025
MariaHCD
approved these changes
Mar 27, 2025
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
45 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.1.20-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.1.20-2 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







Explanation of Change
Adds HTML renderer for our custom
mention-shorttag. This fixes short mentions not being displayed.Fixed Issues
$ #58887
$ #58893
PROPOSAL: #58893 (comment)
Tests
Same as QA Steps.
Offline tests
N/A
QA Steps
Case 1:
Case 2:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
58893.android.native.webm
Android: mWeb Chrome
58893.android.chrome.webm
iOS: Native
58893.ios.native.mp4
iOS: mWeb Safari
58893.ios.safari.mp4
MacOS: Chrome / Safari
58893.macos.chrome.mov
MacOS: Desktop
58893.macos.desktop.mov