[HybridApp] Fix unexpected sing out when verifying account by war-in · Pull Request #58905 · Expensify/App

war-in · 2025-03-21T12:45:17Z

Explanation of Change

This PR sends authToken to old app each time it changes. We need it to be up to date for the reauthentication purposes

Fixed Issues

$ #58704
PROPOSAL:

MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13487

Tests

Create a new account
Go to Settings -> Profile -> contact method
Validate primary contact method
Switch to expensify classic
Verify if the classic app opens and doesn't sign out

Offline tests

QA Steps

Create a new account
Go to Settings -> Profile -> contact method
Validate primary contact method
Switch to expensify classic
Verify if the classic app opens and doesn't sign out

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-25.at.16.56.04.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2025-03-25.at.17.10.31.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

github-actions · 2025-03-21T12:45:27Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

mateuuszzzzz · 2025-03-24T11:24:28Z

 }

+- (void)sendAuthToken:(NSString *)authToken {
+    NSLog(@"[ReactNativeHybridApp] `sendAuthToken` should never be called in standalone `New Expensify` app");


What about creating a template for those logs, method name could be a parameter🤔

Same for Android and web

Maybe we could even create single template on JS side and print those logs based on isHybridApp value

@mateuuszzzzz agree, but I'd do that in separate PR in case of reverts

melvin-bot · 2025-03-25T16:13:47Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2025-03-25T20:13:31Z

@war-in Do we have to wait for the Hybrid repo PR for this to test?

mountiny

Changes look good to me but triggered an adhoc build for testing

@parasharrajat are you able to test and complete the checklist?

github-actions · 2025-03-25T20:59:59Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

github-actions · 2025-03-25T21:41:16Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/58905-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/58905-hybrid/index.html

Android Hybrid 🤖🔄	iOS Hybrid 🍎🔄
N/A	N/A
N/A	N/A
Desktop 💻	Web 🕸️
N/A	N/A
N/A	N/A

👀 View the workflow run that generated this build 👀

github-actions · 2025-03-26T09:23:25Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

parasharrajat · 2025-03-26T11:10:19Z

Testing...

parasharrajat · 2025-03-26T12:56:40Z

I am getting this patch failure.

Failed to apply patch file react-native+0.76.3+001+invalidate-reacthost.patch.

I have removed node_modules and tried to install again but no luck.

parasharrajat · 2025-03-26T12:58:33Z

We are using "react-native": "0.77.1" on NewDot. So I believe we need to update this patch as well.

war-in · 2025-03-26T13:07:21Z

@parasharrajat I think you have an outdated version of Mobile-Expensify submodule
Some developers from our team experienced this issue yesterday and we fixed it by bumping the module, so please try this 🙏

parasharrajat · 2025-03-26T13:13:25Z

Oh, yeah. Completely missed it. Thanks.

parasharrajat · 2025-03-26T15:52:35Z

Furthere getting this build error on the android

Proceeding without mode-specific .env
No modules to process in combine-js-to-schema-cli. If this is unexpected, please check if you set up your NativeComponent correctly. See combine-js-to-schema.js for how codegen finds modules.
e: file:///Users/anonymous/dev/Expensify/App1/Mobile-Expensify/Android/src/org/me/mobiexpensifyg/ReactNativeHybridApp.kt:13:1 Class 'ReactNativeHybridApp' is not abstract and does not implement abstract base class member 'sendAuthToken'.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileDebugKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
   > Com

war-in · 2025-03-26T15:56:36Z

@parasharrajat Have you changed the branch of Mobile-Expensify submodule?
I linked related OD PR in description: https://github.com/Expensify/Mobile-Expensify/pull/13487

parasharrajat · 2025-03-26T17:46:30Z

Screenshots

🔲 iOS / native

26.03.2025_23.12.21_REC.mp4

🔲 iOS / Safari

🔲 MacOS / Desktop

26.03.2025_23.14.01_REC.mp4

🔲 MacOS / Chrome

26.03.2025_19.06.47_REC.mp4

🔲 Android / Chrome

🔲 Android / native

26.03.2025_22.01.59_REC.mp4

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

parasharrajat · 2025-03-26T17:48:08Z

So we should merge the OldDot PR asap after this one otherwise, the NewDot build will start failing. Correct?

In that case, shouldn't we merge the OLDDOt first and update the submodule in this PR.

mountiny

Thanks!

OSBotify · 2025-03-26T23:02:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-27T14:07:53Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.20-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-03-31T10:06:16Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.20-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

war-in added 3 commits March 21, 2025 12:53

send authToken to OD on every change, android part

c319b7b

Merge branch 'main' into war-in/send-auth-token-to-OD

ca457bd

add ios part

b944c0d

mateuuszzzzz reviewed Mar 24, 2025

View reviewed changes

Merge branch 'main' into war-in/send-auth-token-to-OD

9e9b4bb

mountiny assigned war-in Mar 25, 2025

war-in marked this pull request as ready for review March 25, 2025 16:13

war-in requested a review from a team as a code owner March 25, 2025 16:13

melvin-bot Bot requested review from parasharrajat and removed request for a team March 25, 2025 16:13

mountiny approved these changes Mar 25, 2025

View reviewed changes

Merge branch 'main' into war-in/send-auth-token-to-OD

0040822

parasharrajat approved these changes Mar 26, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny March 26, 2025 17:47

mountiny approved these changes Mar 26, 2025

View reviewed changes

mountiny merged commit e4d480d into Expensify:main Mar 26, 2025

github-actions Bot mentioned this pull request Mar 27, 2025

Deploy Checklist: New Expensify 2025-03-27 #59215

Closed

45 tasks

melvin-bot Bot mentioned this pull request Mar 31, 2025

[Due for payment 2025-04-07] [HIGH] Android hybrid - The app log out the Gmail account after finish the add bank flow #58704

Closed

8 tasks

dukenv0307 mentioned this pull request Apr 28, 2025

[$250] iOS - Login - App crashes when tapping on settings in OD #60796

Closed

8 tasks

Conversation

war-in commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Mar 21, 2025

Uh oh!

mateuuszzzzz Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

mateuuszzzzz Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

mateuuszzzzz Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

war-in Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Mar 25, 2025

Uh oh!

parasharrajat commented Mar 25, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Mar 25, 2025

Uh oh!

github-actions Bot commented Mar 25, 2025

Uh oh!

github-actions Bot commented Mar 26, 2025

Uh oh!

parasharrajat commented Mar 26, 2025

Uh oh!

parasharrajat commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parasharrajat commented Mar 26, 2025

Uh oh!

war-in commented Mar 26, 2025

Uh oh!

parasharrajat commented Mar 26, 2025

Uh oh!

parasharrajat commented Mar 26, 2025

Uh oh!

war-in commented Mar 26, 2025

Uh oh!

parasharrajat commented Mar 26, 2025

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

Uh oh!

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Uh oh!

parasharrajat commented Mar 26, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Mar 26, 2025

Uh oh!

github-actions Bot commented Mar 27, 2025

Uh oh!

github-actions Bot commented Mar 31, 2025

Uh oh!

Reviewers

Assignees

Labels

war-in commented Mar 21, 2025 •

edited

Loading

parasharrajat commented Mar 26, 2025 •

edited

Loading