Skip to content

[CP Staging] Revert Partial of "Display Xero disable 2FA error from backend", fixes Nothing happens after hitting Enter on amount input page #58171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mollfpr merged 3 commits into from
Mar 11, 2025
Merged

[CP Staging] Revert Partial of "Display Xero disable 2FA error from backend", fixes Nothing happens after hitting Enter on amount input page #58171

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b9a0c1
Revert "Display Xero disable 2FA error from backend"
allgandalf Mar 11, 2025
c44e391
revert only the input issue
allgandalf Mar 11, 2025
d6c9e80
export function
allgandalf Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/components/Button/validateSubmitShortcut/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import type ValidateSubmitShortcut from './types';

const IGNORED_NODE_NAMES = ['TEXTAREA', 'INPUT'];

/**
* Validate if the submit shortcut should be triggered depending on the button state
*
Expand All @@ -13,9 +11,7 @@ const IGNORED_NODE_NAMES = ['TEXTAREA', 'INPUT'];

const validateSubmitShortcut: ValidateSubmitShortcut = (isDisabled, isLoading, event) => {
const eventTarget = event?.target as HTMLElement;

// If the event target node is for an input, such as when there's a stray "Enter" event from an autocomplete input, then ignore it because it's not meant for this button
if (isDisabled || isLoading || IGNORED_NODE_NAMES.includes(eventTarget.nodeName) || (eventTarget?.contentEditable === 'true' && eventTarget.ariaMultiLine)) {
if (isDisabled || isLoading || eventTarget.nodeName === 'TEXTAREA' || (eventTarget?.contentEditable === 'true' && eventTarget.ariaMultiLine)) {
return false;
}

Expand Down