Fix: Taxes are not imported for sage intacct integration by twilight2294 · Pull Request #57643 · Expensify/App

twilight2294 · 2025-03-01T14:04:30Z

Explanation of Change

Fixed Issues

Tests

Precondition: Have a workspace connected to sage Intacct and the connection has TaxSolutionIDs

If we do not hvae taxes then run this useEffect to set tax solution ID.

    useEffect(() => {
        Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {
            connections: {
                intacct: {
                    data: {
                        taxSolutionIDs: ['Australia - GST', 'United Kingdom - VAT', 'Canadian Sales Taxn- SYS', 'South Africa - VAT'],
                    },
                },
            },
        });
        console.log('sageIntacctData', sageIntacctData);
    }, [policyID]);

Tests:

Open accounting settings > Import > Tax.
Verify that you have a toggle
When enabled, verify that the dropdown menu appears
Click on it

Verify that no errors appear in the JS console

Offline tests

Same as QA

QA Steps

Precondition: Have a workspace connected to sage Intacct and the connection has TaxSolutionIDs

Tests:

Open accounting settings > Import > Tax.
Verify that you have a toggle
When enabled, verify that the dropdown menu appears
Click on it

Verify that selector opens with all the taxsolutionIDs attached to that workspace.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen_recording_20250408_122131.mp4

Android: mWeb Chrome

Screen_recording_20250408_121429.mp4

iOS: Native

Simulator.Screen.Recording.-.Expensify.testing.-.2025-04-08.at.12.28.36.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.Expensify.testing.-.2025-04-08.at.12.19.41.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-04-08.at.12.11.12.PM.mov

MacOS: Desktop

Screen.Recording.2025-04-08.at.12.15.39.PM.mov

melvin-bot · 2025-03-01T14:04:35Z

@dannymcclain @allgandalf One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

twilight2294 · 2025-03-01T14:14:13Z

@allgandalf @dannymcclain Still waiting on the backend changes, I will let you know when this PR is ready for review

allgandalf · 2025-03-06T10:58:39Z

@twilight2294 the BE is on production now, mind fixing the tests and uploading videos please ?

twilight2294 · 2025-03-08T13:57:36Z

@allgandalf PR ready for review

allgandalf · 2025-03-10T03:16:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-04-11.at.11.52.23.AM.mov

Android: mWeb Chrome

Screen.Recording.2025-04-11.at.11.50.17.AM.mov

iOS: Native

Screen.Recording.2025-04-11.at.11.33.45.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-04-11.at.11.35.01.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-04-11.at.11.26.51.AM.mov

MacOS: Desktop

Screen.Recording.2025-04-11.at.11.28.30.AM.mov

allgandalf · 2025-03-12T03:24:24Z

@twilight2294 please upload platform videos!

twilight2294 · 2025-03-17T08:01:37Z

I was OoO most of last week, working on it today!

allgandalf · 2025-03-20T18:34:56Z

bump @twilight2294

twilight2294 · 2025-03-26T12:09:05Z

UpdateD!

allgandalf · 2025-04-01T09:55:08Z

@twilight2294 I don't see them, can you please check

allgandalf · 2025-04-04T15:28:00Z

bump @twilight2294

twilight2294 · 2025-04-08T06:42:50Z

@allgandalf I updated!

allgandalf · 2025-04-11T05:13:27Z

@twilight2294 please merge main, i cannot login on current branch

twilight2294 · 2025-04-11T05:16:22Z

Updated @allgandalf

OSBotify · 2025-04-14T19:04:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-14T23:16:16Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.1.28-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

IuliiaHerets · 2025-04-15T10:54:14Z

@twilight2294 QA team doesn't have taxes; shared useEffect code is not applied.
Which code should we use?

bandicam.2025-04-15.13-46-16-981.mp4

twilight2294 · 2025-04-16T06:11:14Z

@IuliiaHerets you need a sage intacct connection account which has taxID solutions

IuliiaHerets · 2025-04-16T10:49:11Z

@twilight2294 Unfortunately, we do not have such an account. Could you check this internally?

twilight2294 · 2025-04-16T11:46:37Z

okay @IuliiaHerets, c.c. @yuwenmemon

github-actions · 2025-04-16T22:11:53Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.28-15 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

twilight2294 requested a review from a team as a code owner March 1, 2025 14:04

melvin-bot Bot requested review from allgandalf and dannymcclain and removed request for a team March 1, 2025 14:04

twilight2294 force-pushed the taxesNotImported branch from fb421f7 to 9d46640 Compare March 1, 2025 14:07

twilight2294 closed this Mar 1, 2025

twilight2294 force-pushed the taxesNotImported branch from 9d46640 to ec99650 Compare March 1, 2025 14:09

Fix: Taxes are not imported for sage intacct integration

65a92b6

twilight2294 reopened this Mar 1, 2025

twilight2294 added 6 commits March 7, 2025 15:37

Merge branch 'Expensify:main' into taxesNotImported

bc298cb

fix lint

2905392

fix lint 2

37c2d71

fix spanish text

7885b69

fix lint

544ea48

fix prettier

fb22a40

Merge branch 'Expensify:main' into taxesNotImported

83a3035

Merge branch 'Expensify:main' into taxesNotImported

2b7a6d5

Merge branch 'Expensify:main' into taxesNotImported

f2d05bc

Merge branch 'Expensify:main' into taxesNotImported

fbd079d

allgandalf approved these changes Apr 11, 2025

View reviewed changes

melvin-bot Bot requested a review from yuwenmemon April 11, 2025 06:23

yuwenmemon approved these changes Apr 14, 2025

View reviewed changes

yuwenmemon merged commit a50d4bd into Expensify:main Apr 14, 2025

github-actions Bot mentioned this pull request Apr 15, 2025

Deploy Checklist: New Expensify 2025-04-15 #60222

Closed

ChavdaSachin mentioned this pull request Apr 20, 2025

[$250] intacct - no tax toggle displayed when user navigate to import #60548

Closed

8 tasks

Conversation

twilight2294 commented Mar 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Mar 1, 2025

Uh oh!

twilight2294 commented Mar 1, 2025

Uh oh!

allgandalf commented Mar 6, 2025

Uh oh!

twilight2294 commented Mar 8, 2025

Uh oh!

allgandalf commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allgandalf commented Mar 12, 2025

Uh oh!

twilight2294 commented Mar 17, 2025

Uh oh!

allgandalf commented Mar 20, 2025

Uh oh!

twilight2294 commented Mar 26, 2025

Uh oh!

allgandalf commented Apr 1, 2025

Uh oh!

allgandalf commented Apr 4, 2025

Uh oh!

twilight2294 commented Apr 8, 2025

Uh oh!

allgandalf commented Apr 11, 2025

Uh oh!

twilight2294 commented Apr 11, 2025

Uh oh!

OSBotify commented Apr 14, 2025

Uh oh!

github-actions Bot commented Apr 14, 2025

Uh oh!

IuliiaHerets commented Apr 15, 2025

Uh oh!

twilight2294 commented Apr 16, 2025

Uh oh!

IuliiaHerets commented Apr 16, 2025

Uh oh!

twilight2294 commented Apr 16, 2025

Uh oh!

github-actions Bot commented Apr 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

twilight2294 commented Mar 1, 2025 •

edited

Loading

allgandalf commented Mar 10, 2025 •

edited

Loading