Fix: do not show Expensify Card when not fully set up by koko57 · Pull Request #57407 · Expensify/App

koko57 · 2025-02-25T15:16:52Z

Explanation of Change

Fixed Issues

$ #57391
PROPOSAL: -

Tests

Enable the Expensify Card feature but doesn't have settle bank account
Go to member page
Click on the member detail
Click on the Add card
Verify that the Expensify Card option is not displayed
Go to a workspace where the Expensify Card is enabled and the account is set
Repeat steps 2-4
Verify that the Expensify Card option is displayed

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Enable the Expensify Card feature but doesn't have settle bank account
Go to member page
Click on the member detail
Click on the Add card
Verify that the Expensify Card option is not displayed
Go to a workspace where the Expensify Card is enabled and the account is set
Repeat steps 2-4
Verify that the Expensify Card option is displayed

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-02-25.at.16.18.52.mp4

MacOS: Desktop

koko57 · 2025-02-25T15:38:03Z

    WORKSPACE_ACCOUNTING_QUICKBOOKS_ONLINE_ADVANCED: {
        route: 'settings/workspaces/:policyID/accounting/quickbooks-online/advanced',
-        getRoute: (policyID: string) => `settings/workspaces/${policyID}/accounting/quickbooks-online/advanced` as const,
+        getRoute: (policyID?: string) => `settings/workspaces/${policyID}/accounting/quickbooks-online/advanced` as const,


I had to change this bc eslint was complaining, but I see that a looot of occurences of defaulting policy id to '-1'
so I wonder if this eslint rule not to default to string is valid

@koko57 It seems this is unrelated to our PR. Let's discuss this change first to avoid unexpected things. In the scope of this PR, I think we should revert this change

@DylanDylann so should I add the comment disabling eslint above the policy?.id ?? '-1' and revert the change with the routes?

You mean that the eslint will be failed if we revert this change

yep, that's why I changed it. Eslint complains only on the touched files - as long as other files with policy?.id ?? '-1' isn't changed, it will ignore it. So sooner or later we would need to change it anyway. Or we can work on a PR to change it all at once if we're going to stick to this rule (I can volunteer 😃).

cc @mountiny

I don't think it would break anything - I've seen a few more occurrences of an optional policyID param

while resolving conflicts I see taht in some places we have policyID: string | undefined and some logs are logged when there's no policyID, so maybe I'll just replace my changes with the same logic

melvin-bot · 2025-02-25T15:38:24Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2025-02-26T06:59:16Z

    WORKSPACE_ACCOUNTING_QUICKBOOKS_ONLINE_ADVANCED: {
        route: 'settings/workspaces/:policyID/accounting/quickbooks-online/advanced',
-        getRoute: (policyID: string) => `settings/workspaces/${policyID}/accounting/quickbooks-online/advanced` as const,
+        getRoute: (policyID?: string) => `settings/workspaces/${policyID}/accounting/quickbooks-online/advanced` as const,


@koko57 It seems this is unrelated to our PR. Let's discuss this change first to avoid unexpected things. In the scope of this PR, I think we should revert this change

DylanDylann · 2025-02-26T07:07:03Z

@koko57 Also please resolve conflict

DylanDylann · 2025-02-26T07:07:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-02-26.at.16.33.57.mov

Android: mWeb Chrome

Screen.Recording.2025-02-26.at.16.30.36.mov

iOS: Native

Screen.Recording.2025-02-26.at.16.31.33.mov

iOS: mWeb Safari

Screen.Recording.2025-02-26.at.16.32.48.mov

MacOS: Chrome / Safari

Screen.Recording.2025-02-26.at.16.29.48.mov

MacOS: Desktop

Screen.Recording.2025-02-26.at.16.29.30.mov

DylanDylann · 2025-02-26T07:15:11Z

@koko57 A familiar bug, the Expensify feed doesn't display if users haven't gone to Expensify card page

Screen.Recording.2025-02-26.at.14.13.11.mov

koko57 · 2025-02-26T07:55:58Z

@DylanDylann the bug with the feed - isn't it still being worked on?

koko57 · 2025-02-26T07:57:35Z

@DylanDylann #56045 (comment)

koko57 · 2025-02-26T08:19:02Z

@DylanDylann conflicts resolved, comments addressed

DylanDylann · 2025-02-26T08:30:38Z

@koko57 Typescript failed

DylanDylann · 2025-02-26T08:39:02Z

    const bankAccountTitle = bankAccountList?.[paymentBankAccountID]?.title ?? '';

-    const policyID = policy?.id ?? '-1';
+    const policyID = policy?.id;


Why do we need t change this line?

https://github.com/Expensify/App/actions/runs/13524618354/job/37791922234?pr=57407

Do not default string IDs to any value.

As I mentioned above - I don't like this rule as we have many occurrences of defaulting to '-1'

and TS fails, but it's my bad I didn't resolve the conflicts properly

mountiny

One NAB comment

mountiny · 2025-02-27T16:00:25Z

+/**
+ * Check if the Expensify Card is fully set up and a new card can be issued
+ *
+ * @param policy the policy object


Do we need these? They kinda seem redundant here

@mountiny you mean the whole comment or just params?

mountiny · 2025-02-27T16:02:09Z

Actually can you please add unit test for the new method

koko57 · 2025-02-27T16:50:33Z

@mountiny done

mountiny · 2025-02-28T09:27:30Z

Thank you

OSBotify · 2025-02-28T09:35:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-03T17:15:09Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.8-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-03-04T21:54:24Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.8-1 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

koko57 added 4 commits February 25, 2025 15:32

fix: change the condition for displaying Expensify Cards

e6bf33f

fix: create an util function

4dde402

chore: replace the condition with the util function

37877ee

fix: minor naming improvement

0503b24

koko57 force-pushed the fix/57391-do-not-show-exfy-card-when-not-setup branch from 58ad96f to 0503b24 Compare February 25, 2025 15:17

fix: eslint errors

aa0ed86

koko57 commented Feb 25, 2025

View reviewed changes

koko57 marked this pull request as ready for review February 25, 2025 15:38

koko57 requested a review from a team as a code owner February 25, 2025 15:38

melvin-bot Bot requested review from DylanDylann and removed request for a team February 25, 2025 15:38

koko57 mentioned this pull request Feb 25, 2025

[Due for payment 2025-03-11] [$250] Do not allow to enter issue expensify card flow unless the policy is provisioned #57391

Closed

8 tasks

DylanDylann reviewed Feb 26, 2025

View reviewed changes

koko57 mentioned this pull request Feb 26, 2025

[$250] Expensify Card - Success page reappears every time clicking Issue new card button #55124

Closed

8 tasks

koko57 added 3 commits February 26, 2025 09:07

Merge branch 'main' into fix/57391-do-not-show-exfy-card-when-not-setup

9155ce9

fix: resolve conflicts

7b8d704

fix: minor fix

f84c3fe

koko57 requested a review from DylanDylann February 26, 2025 08:19

DylanDylann mentioned this pull request Feb 26, 2025

Expensify Card - New card is not shown in profile unless Expensify Card page is visited first #56045

Closed

8 tasks

DylanDylann reviewed Feb 26, 2025

View reviewed changes

koko57 added 2 commits February 26, 2025 10:07

fix: replace with util

5708437

fix: route types

756f932

DylanDylann approved these changes Feb 26, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny February 26, 2025 09:34

mountiny previously approved these changes Feb 27, 2025

View reviewed changes

feat: add unit test

f89b775

koko57 dismissed mountiny’s stale review via f89b775 February 27, 2025 16:50

DylanDylann approved these changes Feb 28, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny February 28, 2025 03:19

mountiny approved these changes Feb 28, 2025

View reviewed changes

mountiny merged commit b7d924a into Expensify:main Feb 28, 2025

github-actions Bot mentioned this pull request Mar 3, 2025

Deploy Checklist: New Expensify 2025-03-03 #57683

Closed

42 tasks

koko57 deleted the fix/57391-do-not-show-exfy-card-when-not-setup branch February 13, 2026 11:39

Uh oh!

Conversation

koko57 commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Feb 25, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DylanDylann commented Feb 26, 2025

Uh oh!

DylanDylann commented Feb 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann commented Feb 26, 2025

Uh oh!

koko57 commented Feb 26, 2025

Uh oh!

koko57 commented Feb 26, 2025

Uh oh!

koko57 commented Feb 26, 2025

Uh oh!

DylanDylann commented Feb 26, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

koko57 Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mountiny commented Feb 27, 2025

Uh oh!

koko57 commented Feb 27, 2025

Uh oh!

mountiny commented Feb 28, 2025

Uh oh!

OSBotify commented Feb 28, 2025

Uh oh!

github-actions Bot commented Mar 3, 2025

Uh oh!

github-actions Bot commented Mar 4, 2025

Uh oh!

Reviewers

Assignees

Labels

koko57 commented Feb 25, 2025 •

edited

Loading

DylanDylann commented Feb 26, 2025 •

edited

Loading

koko57 Feb 27, 2025 •

edited

Loading