Repository navigation
[No QA] Fullstory small changes - #55487
Merged
Merged
Conversation
melvin-bot
Bot
requested review from
sobitneupane
and removed request for
a team
January 20, 2025 18:35
|
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
danieldoglas
requested review from
rushatgabhane
and removed request for
sobitneupane
January 23, 2025 15:00
| Session.isSupportAuthToken() | ||
| ) { | ||
| // On web, if we started FS at some point in a browser, it will run forever. So let's shut it down if we don't want it to run. | ||
| FullStory('shutdown'); |
Member
There was a problem hiding this comment.
NAB: the command names should probably go in CONST
Member
|
Bug: FS error steps: login to any account on web in an incognito window I think doing a restart when init hasn't run is causing the problem? 
|
Member
|
@danieldoglas hmmm same issue on login. i tested the latest code. this time the issue is 
|
Member
Reviewer Checklist
Screenshots/VideosAndroid: Native
Android: mWeb ChromeiOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop |
|
@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🎯 @rushatgabhane, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #55722. |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
c3024
reviewed
Jan 24, 2025
| Session.isSupportAuthToken() | ||
| ) { | ||
| // On web, if we started FS at some point in a browser, it will run forever. So let's shut it down if we don't want it to run. | ||
| FullStory(CONST.FULL_STORY.SHUTDOWN); |
Contributor
There was a problem hiding this comment.
-FullStory(CONST.FULL_STORY.SHUTDOWN);+ if (isInitialized()) {
+ FullStory(CONST.FULL_STORY.SHUTDOWN);
+ }I got this error @rushatgabhane reported on latest main.
Member
There was a problem hiding this comment.
you need to update your .env file
Member
There was a problem hiding this comment.
USE_THIRD_PARTY_SCRIPTS=true
Contributor
Author
There was a problem hiding this comment.
hmm good suggestion. Let me put up a PR
Contributor
Author
There was a problem hiding this comment.
Checking if it is initialized is a good way to prevent this from happening on dev.
github-actions
Bot
added
the
DeployBlockerCash
Contributor
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
Contributor
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
48 of 50 tasks
danieldoglas
removed
the
DeployBlockerCash
Contributor
Author
|
Removing the deploy blocker. After talking to @mountiny, the e2e performance tests is sometimes flakey, and we can't find anything specific on this PR that would cause that. |
82 tasks done
Contributor
|
🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.0.90-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.90-6 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This PR will:
parseFSAttributesafter all components are readyFixed Issues
$ https://github.com/Expensify/Expensify/issues/458292
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop