Skip to content

Center-me button is missing on the map #55458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iwiznia merged 3 commits into from
Jan 21, 2025
Merged

Center-me button is missing on the map #55458

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4354181
Center-me button is missing on the map
mohit6789 Jan 19, 2025
b0298c2
Fix eslint errors on MapViewImpl
mohit6789 Jan 20, 2025
71a3127
Merge branch 'main' into 55228-center-me-button-fix-mWeb-iphone
mohit6789 Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/components/MapView/MapViewImpl.website.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import useTheme from '@hooks/useTheme';
import useThemeStyles from '@hooks/useThemeStyles';
import type {GeolocationErrorCallback} from '@libs/getCurrentPosition/getCurrentPosition.types';
import {GeolocationErrorCode} from '@libs/getCurrentPosition/getCurrentPosition.types';
import * as UserLocation from '@userActions/UserLocation';
import {clearUserLocation, setUserLocation} from '@userActions/UserLocation';
import CONST from '@src/CONST';
import useLocalize from '@src/hooks/useLocalize';
import useNetwork from '@src/hooks/useNetwork';
Expand Down Expand Up @@ -74,7 +74,7 @@ const MapViewImpl = forwardRef<MapViewHandle, MapViewProps>(
if (error?.code !== GeolocationErrorCode.PERMISSION_DENIED || !initialLocation) {
return;
}
UserLocation.clearUserLocation();
clearUserLocation();
},
[initialLocation],
);
Expand All @@ -98,7 +98,7 @@ const MapViewImpl = forwardRef<MapViewHandle, MapViewProps>(

getCurrentPosition((params) => {
const currentCoords = {longitude: params.coords.longitude, latitude: params.coords.latitude};
UserLocation.setUserLocation(currentCoords);
setUserLocation(currentCoords);
}, setCurrentPositionToInitialState);
}, [isOffline, shouldPanMapToCurrentPosition, setCurrentPositionToInitialState]),
);
Expand Down Expand Up @@ -244,7 +244,7 @@ const MapViewImpl = forwardRef<MapViewHandle, MapViewProps>(
mapLib={mapboxgl}
mapboxAccessToken={accessToken}
initialViewState={initialViewState}
style={StyleUtils.getTextColorStyle(theme.mapAttributionText)}
style={{...StyleUtils.getTextColorStyle(theme.mapAttributionText), zIndex: -1}}
mapStyle={styleURL}
interactive={interactive}
>
Expand Down