User's name containing accent not shown in results if no accent in search query

.eslintrc.js

@@ -3,26 +3,14 @@ const path = require('path');
 const restrictedImportPaths = [
     {
         name: 'react-native',
-        importNames: [
-            'useWindowDimensions',
-            'StatusBar',
-            'TouchableOpacity',
-            'TouchableWithoutFeedback',
-            'TouchableNativeFeedback',
-            'TouchableHighlight',
-            'Pressable',
-            'Text',
-            'ScrollView',
-            'Animated',
-        ],
+        importNames: ['useWindowDimensions', 'StatusBar', 'TouchableOpacity', 'TouchableWithoutFeedback', 'TouchableNativeFeedback', 'TouchableHighlight', 'Pressable', 'Text', 'ScrollView'],
         message: [
             '',
             "For 'useWindowDimensions', please use '@src/hooks/useWindowDimensions' instead.",
             "For 'TouchableOpacity', 'TouchableWithoutFeedback', 'TouchableNativeFeedback', 'TouchableHighlight', 'Pressable', please use 'PressableWithFeedback' and/or 'PressableWithoutFeedback' from '@components/Pressable' instead.",
             "For 'StatusBar', please use '@libs/StatusBar' instead.",
             "For 'Text', please use '@components/Text' instead.",
             "For 'ScrollView', please use '@components/ScrollView' instead.",
-            "For 'Animated', please use 'Animated' from 'react-native-reanimated' instead.",
         ].join('\n'),
     },
     {
@@ -146,10 +134,6 @@ module.exports = {
             {
                 selector: ['variable', 'property'],
                 format: ['camelCase', 'UPPER_CASE', 'PascalCase'],
-                filter: {
-                    regex: '^private_[a-z][a-zA-Z0-9]+$',
-                    match: false,
-                },
             },
             {
                 selector: 'function',

.github/workflows/README.md

@@ -94,7 +94,6 @@ The GitHub workflows require a large list of secrets to deploy, notify and test
 1. `CSC_LINK` - Required to be set for desktop code signing: https://www.electron.build/code-signing.html#travis-appveyor-and-other-ci-servers
 1. `CSC_KEY_PASSWORD` - Required to be set for desktop code signing: https://www.electron.build/code-signing.html#travis-appveyor-and-other-ci-servers
 1. `APPLE_ID` - Required for notarizing desktop code in `desktop/notarize.js`
-1. `APPLE_TEAM_ID` - Required for notarizing desktop code in `desktop/notarize.js`
 1. `APPLE_ID_PASSWORD` - Required for notarizing desktop code in `desktop/notarize.js`
 1. `AWS_ACCESS_KEY_ID` - Required for hosting website and desktop compiled code
 1. `AWS_SECRET_ACCESS_KEY` - Required for hosting website and desktop compiled code

.github/workflows/deploy.yml

@@ -318,7 +318,6 @@ jobs:
           CSC_LINK: ${{ secrets.CSC_LINK }}
           CSC_KEY_PASSWORD: ${{ secrets.CSC_KEY_PASSWORD }}
           APPLE_ID: ${{ secrets.APPLE_ID }}
-          APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
           APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }}
           AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
           AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}

.github/workflows/testBuild.yml

@@ -266,7 +266,6 @@ jobs:
           CSC_LINK: ${{ secrets.CSC_LINK }}
           CSC_KEY_PASSWORD: ${{ secrets.CSC_KEY_PASSWORD }}
           APPLE_ID: ${{ secrets.APPLE_ID }}
-          APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
           APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }}
           AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
           AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}

.github/workflows/testBuildHybrid.yml

@@ -77,11 +77,11 @@ jobs:
             const pullRequest = await github.rest.pulls.get({
               owner: context.repo.owner,
               repo: context.repo.repo,
-              pull_number: '${{ env.PULL_REQUEST_NUMBER }}'',
+              pull_number: env.PULL_REQUEST_NUMBER,
             });
 
             const body = pullRequest.data.body;
-            const regex = /MOBILE-EXPENSIFY:(?<prNumber>\d+)/;
+            const regex = /MOBILE-EXPENSIFY:(?<prNumber>.*)/;
             const found = body.match(regex)?.groups?.prNumber || "";
 
             return found.trim();
@@ -93,14 +93,11 @@ jobs:
       outputs:
         OLD_DOT_REF: ${{ steps.getHeadRef.outputs.REF }}
       steps:
-        - name: Checkout
-          uses: actions/checkout@v4
-
         - name: Check if pull request number is correct
           id: getHeadRef
           run: |
             set -e
-            echo "REF=$(gh pr view ${{ needs.getOldDotPR.outputs.OLD_DOT_PR }} -R 'Expensify/Mobile-Expensify' --json headRefOid --jq '.headRefOid')" >> "$GITHUB_OUTPUT"
+            echo "REF=$(gh pr view ${{ needs.getOldDotPR.outputs.OLD_DOT_PR }} --json headRefOid --jq '.headRefOid')" >> "$GITHUB_OUTPUT"
           env:
             GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 

README.md

@@ -794,6 +794,20 @@ The commands used to compile a production or staging desktop build are `npm run
 HOWEVER, by default those commands will try to notarize the build (signing it as Expensify) and publish it to the S3 bucket where it's hosted for users. In most cases you won't actually need or want to do that for your local testing. To get around that and disable those behaviors for your local build, apply the following diff:
 
 ```diff
+diff --git a/config/electronBuilder.config.js b/config/electronBuilder.config.js
+index e4ed685f65..4c7c1b3667 100644
+--- a/config/electronBuilder.config.js
++++ b/config/electronBuilder.config.js
+@@ -42,9 +42,6 @@ module.exports = {
+         entitlements: 'desktop/entitlements.mac.plist',
+         entitlementsInherit: 'desktop/entitlements.mac.plist',
+         type: 'distribution',
+-        notarize: {
+-            teamId: '368M544MTT',
+-        },
+     },
+     dmg: {
+         title: 'New Expensify',
 diff --git a/scripts/build-desktop.sh b/scripts/build-desktop.sh
 index 791f59d733..526306eec1 100755
 --- a/scripts/build-desktop.sh

android/app/build.gradle

@@ -110,8 +110,8 @@ android {
         minSdkVersion rootProject.ext.minSdkVersion
         targetSdkVersion rootProject.ext.targetSdkVersion
         multiDexEnabled rootProject.ext.multiDexEnabled
-        versionCode 1009008902
-        versionName "9.0.89-2"
+        versionCode 1009008805
+        versionName "9.0.88-5"
         // Supported language variants must be declared here to avoid from being removed during the compilation.
         // This also helps us to not include unnecessary language variants in the APK.
         resConfigs "en", "es"

config/electronBuilder.config.js

@@ -42,6 +42,9 @@ module.exports = {
         entitlements: 'desktop/entitlements.mac.plist',
         entitlementsInherit: 'desktop/entitlements.mac.plist',
         type: 'distribution',
+        notarize: {
+            teamId: '368M544MTT',
+        },
         target: [
             {
                 target: 'default',

contributingGuides/TS_CHEATSHEET.md

@@ -101,46 +101,22 @@
 
 - [1.4](#animated-style) **Animated styles**
 
-The recommended approach to creating animations is by using the `react-native-reanimated` library,
-as it offers greater efficiency and convenience compared to using the `Animated` API directly from
-React Native.
-
   ```ts
-  import React from 'react';
-  import { View, StyleSheet, StyleProp, ViewStyle } from 'react-native';
-  import Animated, { useAnimatedStyle, useSharedValue, withTiming, SharedValue, WithTimingConfig } from 'react-native-reanimated';
-
+  import {useRef} from 'react';
+  import {Animated, StyleProp, ViewStyle} from 'react-native';
+
   type MyComponentProps = {
-    opacity: Animated.SharedValue<number>;
-  };
-
-  const MyComponent = ({ opacity }: MyComponentProps) => {
-    const animatedStyle = useAnimatedStyle(() => ({
-      opacity: opacity.value,
-    }));
-
-    return (
-      <Animated.View style={[styles.box, animatedStyle]} />
-    );
-  };
-
-  const App = () => {
-    const opacity = useSharedValue(0);
-
-    const startAnimation = () => {
-      opacity.value = withTiming(1, {
-        duration: 1000,
-        easing: Easing.inOut(Easing.quad),
-      });
-    };
-
-    return (
-      <View style={styles.container}>
-        <MyComponent opacity={opacity} />
-        <Button title="Animate" onPress={startAnimation} /> 
-      </View>
-    );
+      style?: Animated.WithAnimatedValue<StyleProp<ViewStyle>>;
   };
+
+  function MyComponent({ style }: MyComponentProps) {
+      return <Animated.View style={style} />;
+  }
+
+  function App() {
+      const anim = useRef(new Animated.Value(0)).current;
+      return <MyComponent style={{opacity: anim.interpolate({...})}} />;
+  }
   ```
 
 <a name="render-prop"></a><a name="1.5"></a>

desktop/README.md

@@ -131,7 +131,7 @@ You will need to pass your Apple ID (username) and an [app-specific password](ht
 Now that your credentials have been set up properly, you can push a build to Min.IO. Start by updating the version value in `package.json` to be much higher than it is currently (1.0.0-0 -> 2.0.0-0) so that the uploaded version is always higher than the version you're testing on. Then run the following, where `RootUserKey` and `RootPassKey` are the `RootUser` and `RootPass` values from step 3:
 
 ```shell
-AWS_ACCESS_KEY_ID=RootUserKey AWS_SECRET_ACCESS_KEY=RootPassKey APPLE_ID=YOUR_APPLE_ID APPLE_TEAM_ID=YOUR_APPLE_TEAM_ID APPLE_APP_SPECIFIC_PASSWORD=YOUR_APP_SPECIFIC_PW npm run desktop-build
+AWS_ACCESS_KEY_ID=RootUserKey AWS_SECRET_ACCESS_KEY=RootPassKey APPLE_ID=YOUR_APPLE_ID APPLE_APP_SPECIFIC_PASSWORD=YOUR_APP_SPECIFIC_PW npm run desktop-build
 ```
 
 This command will create a build, notarize it, and push your build to the server. Note that it can take around 10 minutes for the command to complete.

docs/_data/_routes.yml

@@ -119,11 +119,6 @@ platforms:
         icon: /assets/images/money-into-wallet.svg
         description: Learn more about expense tracking and submission.
 
-      - href: connect-credit-cards
-        title: Connect Credit Cards
-        icon: /assets/images/bank-card.svg
-        description: Track credit card transactions and reconcile company cards.
-
       - href: expensify-card
         title: Expensify Card
         icon: /assets/images/hand-card.svg