Skip to content

phone number field is not auto focused #54447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjasikowski merged 5 commits into from
Jan 2, 2025
Merged

phone number field is not auto focused #54447

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6f33a3b
phone number field is not auto focused
NJ-2020 Dec 21, 2024
0cac0c4
fix eslint error
NJ-2020 Dec 21, 2024
dfd23f6
clean up the code
NJ-2020 Dec 24, 2024
ef015fe
Merge branch 'Expensify:main' into fix/53030
NJ-2020 Dec 24, 2024
d6b9f90
fix lint error
NJ-2020 Dec 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/pages/settings/Profile/PersonalDetails/PhoneNumberPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import HeaderWithBackButton from '@components/HeaderWithBackButton';
import OfflineWithFeedback from '@components/OfflineWithFeedback';
import ScreenWrapper from '@components/ScreenWrapper';
import TextInput from '@components/TextInput';
import useAutoFocusInput from '@hooks/useAutoFocusInput';
import useLocalize from '@hooks/useLocalize';
import useThemeStyles from '@hooks/useThemeStyles';
import * as ErrorUtils from '@libs/ErrorUtils';
Expand All @@ -28,6 +29,7 @@ function PhoneNumberPage() {
const [isLoadingApp] = useOnyx(ONYXKEYS.IS_LOADING_APP, {initialValue: true});
const styles = useThemeStyles();
const {translate} = useLocalize();
const {inputCallbackRef} = useAutoFocusInput();
const phoneNumber = privatePersonalDetails?.phoneNumber ?? '';

const validateLoginError = ErrorUtils.getEarliestErrorField(privatePersonalDetails, 'phoneNumber');
Expand Down Expand Up @@ -97,6 +99,7 @@ function PhoneNumberPage() {
>
<InputWrapper
InputComponent={TextInput}
ref={inputCallbackRef}
inputID={INPUT_IDS.PHONE_NUMBER}
name="lfname"
label={translate('common.phoneNumber')}
Expand Down