Update chat with account manager banner by mkzie2 · Pull Request #52682 · Expensify/App

mkzie2 · 2024-11-17T19:24:17Z

Explanation of Change

Fixed Issues

$ #51433
PROPOSAL: #51433 (comment)

Tests

Open Concierge chat.
Verify that the banner is updated and displayed correctly.

Verify that no errors appear in the JS console

Offline tests

Same

QA Steps

Requirement: Have a validated domain admin account
Add someone as the “Account Manager” via Concierge tool
Have a domain admin log into NewDot and navigate to the Concierge chat
Verify there is a “Chat now” button
Tap the button and verify they are brought to the chat with the Account Manager
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-18.at.18.04.27.mov

Android: mWeb Chrome

Screen.Recording.2024-11-18.at.18.03.25.mov

iOS: Native

Screen.Recording.2024-11-19.at.00.53.49.mov

iOS: mWeb Safari

Screen.Recording.2024-11-19.at.00.59.59.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-18.at.16.14.23.mov

MacOS: Desktop

Screen.Recording.2024-11-19.at.01.03.30.mov

danielrvidal · 2024-11-18T22:23:47Z

@allgandalf was asking for help on the translation but their proposal works great for the translation:

en: Need something specific? Chat with your account manager
es: ¿Necesitas algo específico? Habla con tu gerente de cuenta.
en: Chat now
es: Chatear ahora

allgandalf · 2024-11-19T04:50:22Z

@mkzie2 do you think you can get this one ready for review today?

melvin-bot · 2024-11-19T10:16:10Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mkzie2 · 2024-11-19T10:16:39Z

@allgandalf This PR is ready.

shawnborton · 2024-11-19T10:21:30Z

I don't think the banner is supposed to have a hover state:

Let's check with the @Expensify/design though, but I think we should remove that (no background color change, don't change the color of the icon either).

Also from @dannymcclain 's mock, it looks like maybe the gap between the green button and the close icon should be slightly larger (add 4px more). Here is the mock:

allgandalf · 2024-11-19T10:39:25Z

@mkzie2 please make the changes ^ and then perhaps we should run an AdHoc build to test better @shawnborton ?

allgandalf · 2024-11-19T10:40:42Z

@mkzie2 why do we go to self-dm when we click chat to accounts manager?

Also testing steps are not clear, will this banner appear forever ?

allgandalf

Please address the feedback

mkzie2 · 2024-11-19T10:53:21Z

@allgandalf Regarding #52682 (comment), I mocked accountManagerReportID to be self DM report ID, so in the screenshots the button navigates to self DM.

allgandalf · 2024-11-19T10:55:11Z

Please read the expected behaviour below:

mkzie2 · 2024-11-19T11:59:04Z

@allgandalf I updated.

Please read the expected behaviour below:

I only mocked accountManagerReportID to be self DM, not changing any logics in open account manager report. In the case account has an actual AM, it should work correctly.

allgandalf · 2024-11-19T13:04:27Z

@marcaaron how do we get to the AM DM on development? current we get directed to self-dm

marcaaron · 2024-11-19T20:13:07Z

@marcaaron how do we get to the AM DM on development? current we get directed to self-dm

Looks like there's an ONYXKEYS.ACCOUNT_MANAGER_REPORT_ID. We can set that to be a reportID of a random 1:1 chat or something to that effect?

allgandalf · 2024-11-20T05:51:27Z

@marcaaron @shawnborton can any of you trigger an ADHOC build please, lets test this

shawnborton · 2024-11-20T10:41:58Z

Will run the test build now for you 🚀

github-actions · 2024-11-20T10:42:39Z

🚧 @shawnborton has triggered a test build. You can view the workflow run here.

allgandalf · 2024-11-20T11:13:45Z

@mkzie2 can you please share a reproducible steps video on the ad hoc build showing how to bring the banner up and the redirection to chat please

mkzie2 · 2024-11-21T04:45:55Z

@marcaaron How can we create an account with an account manager cc @allgandalf

marcaaron · 2024-11-21T19:16:20Z

I'm confused by the question. Can we not use the trick that I mentioned already and set any reportID manually in the Onyx data?

marcaaron · 2024-11-21T19:22:18Z

@allgandalf @mkzie2 let's pull out the stops here?

Having this show up is not so easy because you need a validated private domain and we would also need to add an account manager for you. We likely have test accounts for internal use. @danielrvidal might be able to set something up for us, but I'd recommend just hardcoding something for test purposes and then we can send this to QA for further testing.

mkzie2 · 2024-11-21T19:32:59Z

@mkzie2 can you please share a reproducible steps video on the ad hoc build showing how to bring the banner up and the redirection to chat please

@marcaaron C+ is requesting me for testing on the ad hoc build why I'm asking about this question. About the dev env, yeah we can test by hardcoding.

allgandalf · 2024-11-21T19:34:40Z

We likely have test accounts for internal use.

All cool, I will complete the checklist then, thanks :))

danielrvidal · 2024-11-26T00:21:13Z

@allgandalf are you all good to keep making progress or do you need anything from me?

allgandalf · 2024-11-26T08:45:17Z

@allgandalf are you all good to keep making progress or do you need anything from me?

All good, i was waiting for a comment to get addressed, completing the checklist now

allgandalf · 2024-11-26T08:45:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

allgandalf · 2024-11-26T10:58:51Z

@mkzie2 please update the QA steps to have the following:

Precondition:

The logged in account should have account Manager assigned

allgandalf · 2024-11-26T11:04:20Z

Also please mark this PR as : [Internal QA]

allgandalf

Design wise LGTM, lets internal QA this and check the functionality 🚀

allgandalf · 2024-11-26T11:19:13Z

    const [isComposerFullSize] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_IS_COMPOSER_FULL_SIZE}${reportIDFromRoute}`, {initialValue: false});
    const [accountManagerReportID] = useOnyx(ONYXKEYS.ACCOUNT_MANAGER_REPORT_ID, {initialValue: ''});
+    // If accountManagerReportID is an empty string, using ?? can crash the app.
+    // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing


@marcaaron we needed to do this because accountManagerReportID can be an empty string which is a valid string in javascript, using ?? would have never fallen us back to -1

marcaaron

LGTM but let's fix all the abbreviations and change "am" to "accountManager" wherever it appears.

marcaaron · 2024-11-26T23:17:12Z

    ChangeTypeParams,
    CharacterLengthLimitParams,
    CharacterLimitParams,
+    ChatWithAMParams,


I would prefer if this was ChatWithAccountManagerParams and everywhere else we do am changed to accountManager

@marcaaron I updated.

marcaaron

Amazing, thanks for the changes!

OSBotify · 2024-11-28T01:05:51Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-28T14:47:33Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 9.0.68-0 🚀

platform	result
🤖 android 🤖	false ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

kavimuru · 2024-11-28T15:41:29Z

@mountiny is this internal QA #52682 (comment)?

allgandalf · 2024-11-28T15:42:32Z

Yes this one is Internal QA, sorry for not updating the title :) I asked this to be marked as Internal here but couldn't follow up c.c. @marcaaron

mountiny · 2024-11-30T00:22:25Z

Seems like the internal QA is quite tricky, the changes are quite simple so I feel like we do not have to hold deploy on this in case the QA is not by the time to deploy

github-actions · 2024-11-30T13:52:08Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.68-7 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

mkzie2 added 2 commits November 18, 2024 02:23

Update chat with account manager banner

66f969f

fix prettier

cd82df4

mkzie2 added 3 commits November 19, 2024 14:31

update translations

07ea65e

get accountManagerReport using useOnyx instead of getReport

0b62e74

use || instead of ??

289d68a

mkzie2 marked this pull request as ready for review November 19, 2024 10:16

mkzie2 requested review from a team as code owners November 19, 2024 10:16

melvin-bot Bot requested review from allgandalf and removed request for a team November 19, 2024 10:16

allgandalf reviewed Nov 19, 2024

View reviewed changes

mkzie2 added 2 commits November 19, 2024 18:56

fix various comments

ff52090

fix translation

9def46f

Merge branch 'main' into mkzie2-issue/51433

f5082e8

shawnborton added the Ready To Build label Nov 20, 2024

marcaaron assigned mkzie2 Nov 20, 2024

allgandalf reviewed Nov 22, 2024

View reviewed changes

Comment thread src/components/Banner.tsx

Comment thread src/pages/home/ReportScreen.tsx

allgandalf approved these changes Nov 26, 2024

View reviewed changes

melvin-bot Bot requested a review from marcaaron November 26, 2024 11:17

allgandalf reviewed Nov 26, 2024

View reviewed changes

danielrvidal mentioned this pull request Nov 26, 2024

[HOLD for payment 2024-12-07] [$500] Remove or update the “Chat with your account manager here” banner #51433

Closed

marcaaron requested changes Nov 26, 2024

View reviewed changes

mkzie2 added 2 commits November 27, 2024 12:31

merge main

09dfe5c

change AM to accountManager

f7dfcf3

marcaaron approved these changes Nov 28, 2024

View reviewed changes

marcaaron merged commit 10a7be8 into Expensify:main Nov 28, 2024

github-actions Bot mentioned this pull request Nov 28, 2024

Deploy Checklist: New Expensify 2024-11-28 #53245

Closed

72 tasks done

mountiny added the InternalQA This pull request required internal QA label Nov 29, 2024

Conversation

mkzie2 commented Nov 17, 2024 • edited by marcaaron Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

danielrvidal commented Nov 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

allgandalf commented Nov 19, 2024

Uh oh!

melvin-bot Bot commented Nov 19, 2024

Uh oh!

mkzie2 commented Nov 19, 2024

Uh oh!

shawnborton commented Nov 19, 2024

Uh oh!

allgandalf commented Nov 19, 2024

Uh oh!

allgandalf commented Nov 19, 2024

Uh oh!

allgandalf left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mkzie2 commented Nov 19, 2024

Uh oh!

allgandalf commented Nov 19, 2024

Uh oh!

mkzie2 commented Nov 19, 2024

Uh oh!

allgandalf commented Nov 19, 2024

Uh oh!

marcaaron commented Nov 19, 2024

Uh oh!

allgandalf commented Nov 20, 2024

Uh oh!

shawnborton commented Nov 20, 2024

Uh oh!

github-actions Bot commented Nov 20, 2024

Uh oh!

allgandalf commented Nov 20, 2024

Uh oh!

mkzie2 commented Nov 21, 2024

Uh oh!

marcaaron commented Nov 21, 2024

Uh oh!

marcaaron commented Nov 21, 2024

Uh oh!

mkzie2 commented Nov 21, 2024

Uh oh!

allgandalf commented Nov 21, 2024

Uh oh!

Uh oh!

Uh oh!

danielrvidal commented Nov 26, 2024

Uh oh!

allgandalf commented Nov 26, 2024

Uh oh!

allgandalf commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allgandalf commented Nov 26, 2024

Uh oh!

allgandalf commented Nov 26, 2024

mkzie2 commented Nov 17, 2024 •

edited by marcaaron

Loading

danielrvidal commented Nov 18, 2024 •

edited

Loading

allgandalf commented Nov 26, 2024 •

edited

Loading

allgandalf commented Nov 28, 2024 •

edited

Loading