feat: synk fix electron upgrade by allroundexperts · Pull Request #52289 · Expensify/App

allroundexperts · 2024-11-09T16:06:12Z

Explanation of Change

Fixed Issues

Tests

N/A

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

N/A

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-ELECTRON-8352921 - https://snyk.io/vuln/SNYK-JS-ELECTRON-8310521 - https://snyk.io/vuln/SNYK-JS-ELECTRON-8310517 - https://snyk.io/vuln/SNYK-JS-ELECTRON-8310519

…95f2dbeceede6adc51fe1f017

melvin-bot · 2024-11-09T16:17:04Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts · 2024-11-09T17:24:08Z

@hungvu193 This does not need a C+ review.

allroundexperts · 2024-11-09T17:34:11Z

@pecanoro This is working well, and should be good to merge.

pecanoro · 2024-11-11T19:28:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

pecanoro · 2024-11-11T19:30:08Z

For future context, this is coming from this PR originally created by Snyk here: #52266

OSBotify · 2024-11-11T19:42:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

mvtglobally · 2024-11-13T00:55:58Z

@pecanoro Is there anything to QA here?

github-actions · 2024-11-13T01:09:22Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 9.0.61-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

pecanoro · 2024-11-13T21:28:20Z

@mvtglobally No, nothing in particular, if anything is broken, it will show during regression tests

github-actions · 2024-11-14T00:40:40Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.61-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

allroundexperts · 2024-11-15T22:35:46Z

@pecanoro Can you please create an issue for my payment here?

pecanoro · 2024-11-18T15:43:19Z

@allroundexperts Created here: #52706

snyk-bot and others added 3 commits November 8, 2024 15:57

Merge branch 'main' of github.com:Expensify/App into snyk-fix-b51ba10…

0e18a5d

…95f2dbeceede6adc51fe1f017

fix type checks

1624693

allroundexperts marked this pull request as ready for review November 9, 2024 16:16

allroundexperts requested a review from a team as a code owner November 9, 2024 16:16

melvin-bot Bot requested a review from hungvu193 November 9, 2024 16:17

melvin-bot Bot removed the request for review from a team November 9, 2024 16:17

allroundexperts added 4 commits November 9, 2024 21:30

fix deprecations

f30c307

fix deprecations

6d5159c

add comment for the deprecation warning ignore

e9beef2

revert electron-context-menu upgrade

ef8237f

pecanoro self-requested a review November 11, 2024 19:27

pecanoro removed the request for review from hungvu193 November 11, 2024 19:28

pecanoro approved these changes Nov 11, 2024

View reviewed changes

pecanoro merged commit 9d8571b into Expensify:main Nov 11, 2024

pecanoro mentioned this pull request Nov 11, 2024

[Snyk] Security upgrade electron from 29.4.6 to 32.2.3 #52266

Merged

49 tasks done

github-actions Bot mentioned this pull request Nov 13, 2024

Deploy Checklist: New Expensify 2024-11-13 #52440

Closed

41 tasks done

pecanoro mentioned this pull request Nov 18, 2024

[HOLD for payment 2024-11-20] Payment issue for E/App PR#52289 #52706

Closed

Navigation Menu

Repository navigation

feat: synk fix electron upgrade - #52289

feat: synk fix electron upgrade#52289
pecanoro merged 7 commits into
Expensify:mainfrom
allroundexperts:synk-fix-electron-upgrade

allroundexperts commented Nov 9, 2024 •

edited

Loading

Uh oh!

melvin-bot Bot commented Nov 9, 2024

Uh oh!

allroundexperts commented Nov 9, 2024

Uh oh!

allroundexperts commented Nov 9, 2024

Uh oh!

pecanoro commented Nov 11, 2024 •

edited

Loading

Uh oh!

pecanoro commented Nov 11, 2024

Uh oh!

OSBotify commented Nov 11, 2024

Uh oh!

mvtglobally commented Nov 13, 2024

Uh oh!

github-actions Bot commented Nov 13, 2024

Uh oh!

pecanoro commented Nov 13, 2024

Uh oh!

github-actions Bot commented Nov 14, 2024

Uh oh!

allroundexperts commented Nov 15, 2024

Uh oh!

pecanoro commented Nov 18, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

allroundexperts commented Nov 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 9, 2024

Uh oh!

allroundexperts commented Nov 9, 2024

Uh oh!

allroundexperts commented Nov 9, 2024

Uh oh!

pecanoro commented Nov 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

pecanoro commented Nov 11, 2024

Uh oh!

OSBotify commented Nov 11, 2024

Uh oh!

mvtglobally commented Nov 13, 2024

Uh oh!

github-actions Bot commented Nov 13, 2024

Uh oh!

pecanoro commented Nov 13, 2024

Uh oh!

github-actions Bot commented Nov 14, 2024

Uh oh!

allroundexperts commented Nov 15, 2024

Uh oh!

pecanoro commented Nov 18, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

allroundexperts commented Nov 9, 2024 •

edited

Loading

pecanoro commented Nov 11, 2024 •

edited

Loading