fix: 50485 mWeb/Chrome - IOU- Continue and green button not working in scan page by layacat · Pull Request #52087 · Expensify/App

layacat · 2024-11-06T03:35:28Z

Explanation of Change

Update the docs and explanation for IOU camera flow.

Fixed Issues

Tests

[mWeb only]

Precondition: App has never asked for camera permission before. Might need to clear the browser cache to reset permission settings.

Tap FAB > Create expense > Scan > Continue
Deny camera access
Verify Camera access still hasn't been granted, please follow these instructions. message and Continue button appears
Tap these instructions
Verify Expensify help site opens with How can I enable camera permission for a website on mobile browsers? highlighted
Follow the instructions in help site to grant camera access
Refresh the site
Verify camera is enabled in IOU Scan page

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

How to enable camera permission for a website on mobile browsers?

Google Chrome:

Open Chrome.
To the right of the address bar, tap More icon › Settings.
Tap Site settings › Camera.
Tap to turn the microphone or camera on or off.
- If you find the site you want to use under Blocked, tap the site › Allow.
Refresh the site.

Safari:

Open Safari.
To the left of the address bar, tap More icon › Site settings › Camera.
Tap Allow to grant permission.
Tap Done.
Refresh the site.

[mWeb only]

Precondition: App has never asked for camera permission before. Might need to clear the browser cache to reset permission settings.

Tap FAB > Create expense > Scan > Continue
Deny camera access
Verify Camera access still hasn't been granted, please follow these instructions. message and Continue button appears
Tap these instructions
Verify Expensify help site opens
Follow the instructions in the How to enable camera permission for a website on mobile browsers? section above to grant camera access
Back to App and refresh it
Verify camera is enabled in IOU Scan page

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…n scan page

melvin-bot · 2024-11-07T01:46:01Z

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

layacat · 2024-11-07T01:47:08Z

It's ready for review. I'll complete the screenshots in the meantime

dominictb · 2024-11-08T10:29:15Z

Please copy the Tests steps to the QA Steps. Refrain from "Same as...".

layacat · 2024-11-11T07:37:53Z

I'm working on it

dominictb · 2024-11-14T03:41:21Z

@layacat Ping me when you're done.

layacat · 2024-11-14T06:21:28Z

Sure. I'm having issue with running the docs project. I'll keep you posted

dominictb · 2024-11-19T08:41:19Z

@layacat any new updates?

layacat · 2024-11-19T08:42:58Z

I'm updating the docs section with your advice. I'll also address all the review comments in one go.

layacat · 2024-11-20T10:01:15Z

@dominictb What do you think about this? I linked user to FAQ section if they click here:

mbbrs.mov

dominictb · 2024-11-20T10:26:38Z

@layacat Looks much better. How about just the FAQ question? The info box seems an extra step and quite redundant to me.

layacat · 2024-11-20T11:35:14Z

I updated. Please check

dominictb

Please do it very carefully this time to speed up the PR! I already included the changes with detailed text for you.

layacat · 2024-11-21T07:02:21Z

All Done. Please check again.

dominictb · 2024-11-21T07:37:13Z

@layacat Please update your screenshots and videos as well showing the final flow and text. We need marketing approval on the text.

layacat · 2024-11-21T07:45:55Z

Sure. I've added.

dominictb · 2024-11-21T08:32:54Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Tested on emulator using mocked camera.

Screen.Recording.2024-11-21.at.17.47.05-compressed.mov

iOS: Native

iOS: mWeb Safari

Tested on simulator using mocked camera.

Screen.Recording.2024-11-21.at.17.37.13-compressed.mov

MacOS: Chrome / Safari

MacOS: Desktop

dominictb · 2024-11-21T10:04:36Z

@layacat Please update Tests and QA Tests:

[mWeb only]

**Precondition**: App has never asked for camera permission before. Might need to clear the browser cache to reset permission settings.

1. Tap FAB > Create expense > Scan > Continue
2. Deny camera access
3. Verify `Camera access still hasn't been granted, please follow these instructions.` message and `Continue` button appears
4. Tap `these instructions`
5. Verify Expensify help site opens with `How can I enable camera permission for a website on mobile browsers?` highlighted
6. Follow the instructions in help site to grant camera access
7. Refresh the site
8. Verify camera is enabled in IOU Scan page

…nse.md Update end of line dot. Co-authored-by: Dominic <165644294+dominictb@users.noreply.github.com>

dominictb · 2024-11-21T10:44:27Z

@layacat You missed the QA Steps

layacat · 2024-11-21T10:45:40Z

Updated.

dominictb

LGTM

dominictb · 2024-11-21T10:52:16Z

@Julesssss Need your help here:

What's the procedure to get approval on help site article text? Do we need Waiting for Copy label?
AFAIK, QA cannot test help site changes on staging, can they? If so how can we test it, or need to wait for production deployment and retest later?

dominictb · 2024-11-21T10:54:56Z

@layacat Thanks for your collaborative attitude to get this done ASAP today 🚀

However next time please be more mindful, careful and attentive to details. Refine your changes before requesting review. Think about other similar cases/places. So we can avoid back-to-back conversations for just several very minor changes.

Julesssss · 2024-11-21T16:14:35Z

What's the procedure to get approval on help site article text? Do we need Waiting for Copy label?

AFAIK, QA cannot test help site changes on staging, can they? If so how can we test it, or need to wait for production deployment and retest later?

Hey @dominictb. Yeah that sounds correct looking at internal instructions. We can review it briefly on prod before paying out 👍

Julesssss · 2024-11-21T16:17:54Z

I requested copy review here.

dominictb · 2024-11-22T03:58:34Z

@layacat Because QA cannot test Help docs on staging, please update QA Steps as follow:

<details>
<summary>How to enable camera permission for a website on mobile browsers?</summary>

<h4>Google Chrome:</h4>

1. Open Chrome.
2. To the right of the address bar, tap More icon › **Settings**.
3. Tap **Site settings** › **Camera**.
4. Tap to turn the microphone or camera on or off.
    - If you find the site you want to use under **Blocked**, tap the site › **Allow**.
6. Refresh the site.

<h4>Safari:</h4>

1. Open Safari.
2. To the left of the address bar, tap More icon › **Site settings** › **Camera**.
3. Tap **Allow** to grant permission.
4. Tap **Done**.
5. Refresh the site.
</details>

[mWeb only]

**Precondition**: App has never asked for camera permission before. Might need to clear the browser cache to reset permission settings.

1. Tap FAB > Create expense > Scan > Continue
2. Deny camera access
3. Verify `Camera access still hasn't been granted, please follow these instructions.` message and `Continue` button appears
4. Tap `these instructions`
5. Verify Expensify help site opens
6. Follow the instructions in the **How to enable camera permission for a website on mobile browsers?** section above to grant camera access
7. Back to App and refresh it
8. Verify camera is enabled in IOU Scan page

dominictb · 2024-11-22T04:04:06Z

And remove "Same as Tests" from Offline tests. If we're offline, we cannot open Help site.

layacat · 2024-11-22T09:10:50Z

Thanks. I updated

Julesssss

Copy was approved. Lets merge

OSBotify · 2024-11-28T11:20:51Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-28T14:47:12Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.0.68-0 🚀

platform	result
🤖 android 🤖	false ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-11-30T13:51:47Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.68-7 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

layacat added 2 commits November 6, 2024 10:31

fix: 50485 mWeb/Chrome - IOU- Continue and green button not working i…

3171834

…n scan page

Fix show only when denied

2d8e017

layacat marked this pull request as ready for review November 7, 2024 01:45

layacat requested a review from a team as a code owner November 7, 2024 01:45

melvin-bot Bot requested review from dominictb and removed request for a team November 7, 2024 01:45

dominictb suggested changes Nov 8, 2024

View reviewed changes

Comment thread docs/articles/new-expensify/expenses-&-payments/Create-an-expense.md

Comment thread src/languages/es.ts

Comment thread src/pages/iou/request/step/IOURequestStepScan/index.tsx Outdated

Comment thread src/pages/iou/request/step/IOURequestStepScan/index.tsx Outdated

layacat added 6 commits November 20, 2024 18:10

Merge remote-tracking branch 'origin/main' into fix/50485

a12323d

Fix create an expense markdown

4bfd3ff

Add missing sentence ending period.

724c463

keep the Continue button for both cases

3b259c5

Remove include info

40efd4d

Update deniedCameraAccess es

51fd9a8

dominictb suggested changes Nov 21, 2024

View reviewed changes

Fix comment

a7804b1

dominictb reviewed Nov 21, 2024

View reviewed changes

Comment thread src/pages/iou/request/step/IOURequestStepScan/index.tsx Outdated

Move link to CONST

7cc287a

dominictb reviewed Nov 21, 2024

View reviewed changes

Comment thread docs/articles/new-expensify/expenses-&-payments/Create-an-expense.md Outdated

Update docs/articles/new-expensify/expenses-&-payments/Create-an-expe…

e60bbb9

…nse.md Update end of line dot. Co-authored-by: Dominic <165644294+dominictb@users.noreply.github.com>

dominictb approved these changes Nov 21, 2024

View reviewed changes

melvin-bot Bot requested a review from Julesssss November 21, 2024 10:50

Julesssss added Waiting for copy User facing verbiage needs polishing and removed Waiting for copy User facing verbiage needs polishing labels Nov 21, 2024

Julesssss mentioned this pull request Nov 21, 2024

[HOLD for payment 2024-12-11] [HOLD for payment 2024-12-07] [$250] mWeb/Chrome - IOU- Continue and green button not working in scan page #50485

Closed

1 of 6 tasks

Julesssss approved these changes Nov 28, 2024

View reviewed changes

Julesssss merged commit 43640b1 into Expensify:main Nov 28, 2024

github-actions Bot mentioned this pull request Nov 28, 2024

Deploy Checklist: New Expensify 2024-11-28 #53245

Closed

72 tasks done

Conversation

layacat commented Nov 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

Google Chrome:

Safari:

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 7, 2024

Uh oh!

layacat commented Nov 7, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dominictb commented Nov 8, 2024

Uh oh!

layacat commented Nov 11, 2024

Uh oh!

dominictb commented Nov 14, 2024

Uh oh!

layacat commented Nov 14, 2024

Uh oh!

dominictb commented Nov 19, 2024

Uh oh!

layacat commented Nov 19, 2024

Uh oh!

layacat commented Nov 20, 2024

Uh oh!

dominictb commented Nov 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

layacat commented Nov 20, 2024

Uh oh!

dominictb left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

layacat commented Nov 21, 2024

Uh oh!

Uh oh!

dominictb commented Nov 21, 2024

Uh oh!

layacat commented Nov 21, 2024

Uh oh!

dominictb commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dominictb commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

dominictb commented Nov 21, 2024

Uh oh!

layacat commented Nov 21, 2024

Uh oh!

dominictb left a comment

Choose a reason for hiding this comment

Uh oh!

dominictb commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dominictb commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Julesssss commented Nov 21, 2024

layacat commented Nov 6, 2024 •

edited

Loading

dominictb commented Nov 20, 2024 •

edited

Loading

dominictb left a comment •

edited

Loading

dominictb commented Nov 21, 2024 •

edited

Loading

dominictb commented Nov 21, 2024 •

edited

Loading

dominictb commented Nov 21, 2024 •

edited

Loading

dominictb commented Nov 21, 2024 •

edited

Loading

dominictb commented Nov 22, 2024 •

edited

Loading