[CP Staging] [NO QA]: Add bank urls to Company Card flow by narefyev91 · Pull Request #51384 · Expensify/App

narefyev91 · 2024-10-24T07:15:31Z

Details

Add correct redirect urls for Bank connection

Fixed Issues

$ #50448
PROPOSAL:

Tests

It's just polish to remove test code

Verify that no errors appear in the JS console

Offline tests

It's just polish to remove test code

QA Steps

It's just polish to remove test code

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-10-24.at.11.44.11.mov

MacOS: Desktop

melvin-bot · 2024-10-24T08:33:05Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf · 2024-10-24T08:34:42Z

        BILLABLE: 'billable',
        NON_BILLABLE: 'nonBillable',
    },
+    COMPANY_CARD_DOMAIN_NAME: 'expensify-policyABASDASDASDASDFASD.exfy',


where did you take this value from ?

tagged you in thread as well

This was just a format example, the policyID has to be the policyID of the policy to which you trying to connect the bank :D

allgandalf · 2024-10-24T08:43:11Z

@@ -180,6 +180,7 @@ const CONST = {
        BILLABLE: 'billable',


Looks good, did you test atleast on one platform ?

yeah

Screen.Recording.2024-10-24.at.11.44.11.mov

allgandalf · 2024-10-24T09:10:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2024-10-24.at.2.43.24.PM.mov

allgandalf

code cleanup, looks great, thanks @narefyev91 !

mountiny

The domain name has to be dynamic to the policy you trying to connect the bank to

mountiny · 2024-10-24T09:33:40Z

        BILLABLE: 'billable',
        NON_BILLABLE: 'nonBillable',
    },
+    COMPANY_CARD_DOMAIN_NAME: 'expensify-policyABASDASDASDASDFASD.exfy',


This was just a format example, the policyID has to be the policyID of the policy to which you trying to connect the bank :D

narefyev91 · 2024-10-24T10:07:20Z

The domain name has to be dynamic to the policy you trying to connect the bank to

Updated

allgandalf

small change, but i think we should stay consistent across our codebase

allgandalf · 2024-10-24T10:09:19Z

 import ONYXKEYS from '@src/ONYXKEYS';

 function BankConnection() {
+    const params = useRoute().params as Record<string, string>;


This is not really the way we get route params, can you please update this , i can attach the pattern we follow below:

App/src/pages/workspace/companyCards/WorkspaceCompanyCardDetailsPage.tsx

Lines 39 to 42 in 8e13bcc

type WorkspaceCompanyCardDetailsPageProps = StackScreenProps<SettingsNavigatorParamList, typeof SCREENS.WORKSPACE.COMPANY_CARD_DETAILS>;

function WorkspaceCompanyCardDetailsPage({route}: WorkspaceCompanyCardDetailsPageProps) {

const {policyID, cardID, backTo, bank} = route.params;

yeah but it's not a navigation page - it's just a component

ummm, can't we then just pass the prop down to the component then? do we do the same thing in other component pages ? just that i saw this pattern for the first time

updated - passed inside AddNewCardPage

allgandalf

Okay the policyId are dynamic now, thanks for the quick change @narefyev91

mountiny

Looks terrific

mountiny · 2024-10-24T10:53:09Z

+export default function getPolicyDomainName(policyID: string): string {
+    return `expensify-policy${policyID}.exfy`;
+}


NAB: but in future PR can you please move this to the existing policy utils file?

mountiny · 2024-10-24T10:53:42Z

@@ -0,0 +1,3 @@
+export default function getPolicyDomainName(policyID: string): string {
+    return `expensify-policy${policyID}.exfy`;


@narefyev91 actually relaized, this has to be lowercase, can you make sure the returned string is made lowercase?

@mountiny you mean policyID value?

Yeah the entire thing but the policyID in there would be passed as uppercase

yeah i found already existed util function for that

mountiny

Thanks!

melvin-bot · 2024-10-24T11:18:47Z

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

mountiny · 2024-10-24T11:27:20Z

tests were passing

[CP Staging] [NO QA]: Add bank urls to Company Card flow (cherry picked from commit 7e5910e) (CP triggered by mountiny)

OSBotify · 2024-10-24T11:28:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-24T11:54:46Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.53-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-25T02:18:08Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.53-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-25T07:49:12Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.53-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

narefyev91 added 3 commits October 24, 2024 10:10

Add bank urls to Company Card flow

e4a1fa4

add const

b484467

add bank of america

d087a9b

narefyev91 marked this pull request as ready for review October 24, 2024 08:33

narefyev91 requested a review from a team as a code owner October 24, 2024 08:33

melvin-bot Bot requested a review from allgandalf October 24, 2024 08:33

melvin-bot Bot removed the request for review from a team October 24, 2024 08:33

allgandalf reviewed Oct 24, 2024

View reviewed changes

allgandalf approved these changes Oct 24, 2024

View reviewed changes

melvin-bot Bot requested a review from mountiny October 24, 2024 09:15

mountiny requested changes Oct 24, 2024

View reviewed changes

mountiny assigned narefyev91 Oct 24, 2024

mountiny changed the title ~~[NO QA]: Add bank urls to Company Card flow~~ [CP Staging] [NO QA]: Add bank urls to Company Card flow Oct 24, 2024

add dynamic policy

308cece

narefyev91 requested a review from mountiny October 24, 2024 10:07

allgandalf suggested changes Oct 24, 2024

View reviewed changes

pass prop directly

77cec75

narefyev91 requested a review from allgandalf October 24, 2024 10:17

allgandalf approved these changes Oct 24, 2024

View reviewed changes

mountiny previously approved these changes Oct 24, 2024

View reviewed changes

Comment thread src/libs/actions/getCompanyCardBankConnection/index.tsx Outdated

add policy domain name util function

eb17f40

narefyev91 dismissed mountiny’s stale review via eb17f40 October 24, 2024 10:50

mountiny requested changes Oct 24, 2024

View reviewed changes

use getDomainNameForPolicy

3b7cebf

narefyev91 requested a review from mountiny October 24, 2024 11:00

mountiny approved these changes Oct 24, 2024

View reviewed changes

mountiny merged commit 7e5910e into Expensify:main Oct 24, 2024

melvin-bot Bot added the Emergency label Oct 24, 2024

mountiny removed the Emergency label Oct 24, 2024

OSBotify pushed a commit that referenced this pull request Oct 24, 2024

Merge pull request #51384 from narefyev91/add-bank-urls

b6eae36

[CP Staging] [NO QA]: Add bank urls to Company Card flow (cherry picked from commit 7e5910e) (CP triggered by mountiny)

github-actions Bot added the CP Staging marks PRs that have been CP'd to staging label Oct 24, 2024

github-actions Bot mentioned this pull request Oct 24, 2024

Deploy Checklist: New Expensify 2024-10-23 #51344

Closed

42 tasks done

melvin-bot Bot mentioned this pull request Oct 25, 2024

[HOLD for payment 2024-11-05] [HOLD for payment 2024-11-01] [HOLD for payment 2024-10-30] [Direct Feeds] [App] Adding Direct Card Feed: Bank UI #50448

Closed

	type WorkspaceCompanyCardDetailsPageProps = StackScreenProps<SettingsNavigatorParamList, typeof SCREENS.WORKSPACE.COMPANY_CARD_DETAILS>;

	function WorkspaceCompanyCardDetailsPage({route}: WorkspaceCompanyCardDetailsPageProps) {
	const {policyID, cardID, backTo, bank} = route.params;

		@@ -0,0 +1,3 @@
		export default function getPolicyDomainName(policyID: string): string {
		return `expensify-policy${policyID}.exfy`;

Conversation

narefyev91 commented Oct 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 24, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

allgandalf commented Oct 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allgandalf left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

narefyev91 commented Oct 24, 2024

Uh oh!

allgandalf left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

allgandalf left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mountiny Oct 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Oct 24, 2024

Uh oh!

mountiny commented Oct 24, 2024

Uh oh!

OSBotify commented Oct 24, 2024

narefyev91 commented Oct 24, 2024 •

edited

Loading

allgandalf commented Oct 24, 2024 •

edited

Loading

mountiny Oct 24, 2024 •

edited

Loading