QBO: Fix connection missing by hungvu193 · Pull Request #50766 · Expensify/App

hungvu193 · 2024-10-15T03:32:37Z

Details

While connecting to QBO, we can see the Last synced with an empty date appeared briefly. This PR fixes it.

Fixed Issues

$ #46445
PROPOSAL: #46445 (comment)

Tests

Create new workspace.
Go to More Feature => Enable Accounting feature.
Go to the Accounting screen, and click on QBO connection to connect with QBO.
Verify that you can connect to QBO successfully and during the process, you won't see the Last synced with an empty date.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

mAndroid.mov

iOS: Native

IOS.mov

iOS: mWeb Safari

Safari.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-15.at.10.40.19.mov

MacOS: Desktop

Screen.Recording.2024-10-15.at.10.43.53.mov

melvin-bot · 2024-10-15T05:05:01Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2024-10-15T20:33:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-16.at.7.29.09.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-10-16.at.8.43.13.PM.mov

iOS: Native

Screen.Recording.2024-10-16.at.8.37.15.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-10-16.at.4.12.59.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-16.at.4.02.05.AM.mov

MacOS: Desktop

Screen.Recording.2024-10-19.at.2.04.31.AM.mov

ishpaul777 · 2024-10-16T13:37:14Z

i couldn't get it done yesterday, on it today :D

ishpaul777 · 2024-10-16T15:45:00Z

@hungvu193 I am getting last synced without any option on desktop app, options dont show at all

Screen.Recording.2024-10-16.at.9.11.09.PM.mov

hungvu193 · 2024-10-16T16:10:08Z

@ishpaul777 oh shot! Looks like you can reproduce the bug in the OP. Can you reproduce it consistently?. If Yes can you please inspect the Pusher event on verbose tab and let me know the result.
I think there will be some kind of missing Pusher event like I explained in #46445 (comment)

hungvu193 · 2024-10-17T03:04:02Z

Hmm I don't think I can reproduce, do you have specific steps to reproduce it?

Screen.Recording.2024-10-17.at.10.02.19.mov

ishpaul777 · 2024-10-17T09:54:45Z

it same as in this video #50766 (comment), one thing i noticed is it redirected you staging.new.expensify/connection-complete for me it redirected to new.expensify/connection-complete in case that makes a difference

hungvu193 · 2024-10-17T15:31:49Z

Yeah, if you've navigated to new.expensify.com, it looks like you were connected to prod env. I used to reproduce #50766 (comment) on Staging but couldn't reproduce it after few days while working on this idea. .
Are you turning on the Use Staging Server switch?

ishpaul777 · 2024-10-18T20:41:05Z

Using staging server does the trick, but i think we should also investigate (and fix it if can be on FE) , if not in this PR maybe in follow up? Wdyt?

Screen.Recording.2024-10-19.at.2.04.31.AM.mov

hungvu193 · 2024-10-19T00:44:07Z

As I explained in here: #46445 (comment)

The RCA of the missing menu item is that Pusher event never sent any updates of QBO data until next manual sync. I think there is a PR on Staging fixed it but it isn't deployed to Prod yet.

ishpaul777 · 2024-10-20T13:00:05Z

alright! PR LGTM, All yours @yuwenmemon

yuwenmemon · 2024-10-23T20:46:15Z

Sorry for the delay. Taking a look now.

yuwenmemon · 2024-10-23T21:33:05Z

Tests well! Thanks!

OSBotify · 2024-10-23T21:43:40Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-25T02:08:26Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.54-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-29T09:14:06Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.54-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

github-actions · 2024-10-29T11:38:23Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.54-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

fix connection missing QBO

5457af1

hungvu193 marked this pull request as ready for review October 15, 2024 05:04

hungvu193 requested a review from a team as a code owner October 15, 2024 05:04

melvin-bot Bot requested review from ishpaul777 and removed request for a team October 15, 2024 05:04

hungvu193 mentioned this pull request Oct 15, 2024

[Waiting on Checklist - HOLD for payment 2024-11-05] [$250] QBO - Connection options are missing in QBO connection #46445

Closed

6 tasks

Merge remote-tracking branch 'origin/main' into fix-qbo-sync-issue

ede7ca4

ishpaul777 approved these changes Oct 20, 2024

View reviewed changes

melvin-bot Bot requested a review from yuwenmemon October 20, 2024 12:57

Merge remote-tracking branch 'origin/main' into fix-qbo-sync-issue

1b1d03a

yuwenmemon approved these changes Oct 23, 2024

View reviewed changes

yuwenmemon merged commit 5e975f5 into Expensify:main Oct 23, 2024

github-actions Bot mentioned this pull request Oct 25, 2024

Deploy Checklist: New Expensify 2024-10-25 #51448

Closed

49 tasks

Conversation

hungvu193 commented Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 15, 2024

Uh oh!

ishpaul777 commented Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ishpaul777 commented Oct 16, 2024

Uh oh!

ishpaul777 commented Oct 16, 2024

Uh oh!

hungvu193 commented Oct 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hungvu193 commented Oct 17, 2024

Uh oh!

ishpaul777 commented Oct 17, 2024

Uh oh!

hungvu193 commented Oct 17, 2024

Uh oh!

ishpaul777 commented Oct 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hungvu193 commented Oct 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ishpaul777 commented Oct 20, 2024

Uh oh!

yuwenmemon commented Oct 23, 2024

Uh oh!

yuwenmemon commented Oct 23, 2024

Uh oh!

OSBotify commented Oct 23, 2024

Uh oh!

github-actions Bot commented Oct 25, 2024

Uh oh!

github-actions Bot commented Oct 29, 2024

Uh oh!

github-actions Bot commented Oct 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hungvu193 commented Oct 15, 2024 •

edited

Loading

ishpaul777 commented Oct 15, 2024 •

edited

Loading

hungvu193 commented Oct 16, 2024 •

edited

Loading

ishpaul777 commented Oct 18, 2024 •

edited

Loading

hungvu193 commented Oct 19, 2024 •

edited

Loading