Update Invoices setting screen by rezkiy37 · Pull Request #50565 · Expensify/App

rezkiy37 · 2024-10-10T13:06:11Z

Details

The PR replaces the legacy sections of the invoices page with the new ones.
Note: this PR should be merged right after #50571 because it integrates API there.

Fixed Issues

$ #45175
PROPOSAL: N/A

Tests

Preconditions:

Enable invoices of a workspace

Open the workspace’s invoices page
Verify that there are 2 sections: balance, bank accounts and details.

Verify that no errors appear in the JS console

Offline tests

Same as "Tests".

QA Steps

Same as "Tests".

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…ture/45175-invoicing-settings-screen

shawnborton · 2024-10-17T15:20:44Z

We're still missing the stylized page header:

melvin-bot · 2024-10-17T16:34:17Z

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rezkiy37 · 2024-10-17T16:34:52Z

Note: this PR should be merged right after #50571 because it integrates API there.

rezkiy37 · 2024-10-17T16:40:57Z

We're still missing the stylized page header:

I've added the icon and aligned the header. Fixed - 52d02d8.

Details

cc @shawnborton

shawnborton · 2024-10-17T16:51:42Z

I deleted my last comment, you have the right icon in place - sorry about that!

shawnborton · 2024-10-17T16:52:04Z

That looks good to me, cc @JmillsExpensify to make sure you have visibility into this one as well.

…ture/45175-invoicing-settings-screen

rezkiy37 · 2024-10-22T10:55:12Z

I've updated the sections descriptions agreed in Slack.

Details

cc @shawnborton

rezkiy37 · 2024-10-22T11:14:10Z

Aligned text styles - 71b7feb.

Details

cc @shawnborton

shawnborton · 2024-10-22T11:22:46Z

Hmm I'm not seeing any changes? This part of the invoice view:

Should look more like the Settings > Wallet view:

shawnborton · 2024-10-22T11:23:41Z

Though we chatted on Slack that we want all of the paragraph text below the card's title to use our text supporting color, just like the rest of the workspace editor has:

So that means we need to update Settings to match (or not, we can do that as a follow up).

rezkiy37 · 2024-10-22T11:32:05Z

Hmm I'm not seeing any changes? This part of the invoice view:

Should look more like the Settings > Wallet view:

Do you think it looks correct? @shawnborton

…ture/45175-invoicing-settings-screen

shawnborton · 2024-10-22T11:56:18Z

Nice, that looks good to me!

rezkiy37 · 2024-10-22T12:07:30Z

@fedirjh bump

fedirjh · 2024-10-23T14:12:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

fedirjh

LGTM. cc @Expensify/design

shawnborton · 2024-10-23T18:33:09Z

Looks pretty good to me! I'm going to run a test build so I can take it for a spin in my account but the screenshots seem correct at first glance.

dannymcclain · 2024-10-23T18:40:44Z

Looking much better

github-actions · 2024-10-23T18:54:43Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/50565/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/50565/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/50565/NewExpensify.dmg	https://50565.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shawnborton · 2024-10-23T18:59:31Z

Styles look good to me. Is it known that the Company name and Company website fields don't work/don't save though? Not sure if that was a regression introduced here or not.

fedirjh · 2024-10-23T21:05:25Z

Is it known that the Company name and Company website fields don't work/don't save though?

Yes, It will be handled in:

Invoicing details section #50571

shawnborton · 2024-10-24T06:22:33Z

Sounds good, thanks for confirming. I think this is all good from a design standpoint then, thanks for the changes here!

melvin-bot · 2024-10-24T08:43:37Z

@madmax330 looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2024-10-24T08:53:31Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

madmax330 · 2024-10-24T09:49:45Z

Tests were passing

github-actions · 2024-10-25T02:08:17Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 9.0.54-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-29T09:13:57Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.54-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

github-actions · 2024-10-29T11:38:14Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.54-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

dukenv0307 · 2025-01-07T03:56:15Z

-            <Balance balance={policy?.invoice?.bankAccount?.stripeConnectAccountBalance ?? 0} />
+            <MenuItemWithTopDescription
+                description={translate('walletPage.balance')}
+                title={CurrencyUtils.convertToDisplayString(policy?.invoice?.bankAccount?.stripeConnectAccountBalance ?? 0)}


We should add policy?.outputCurrency here. Ref: #53916

…ing-settings-screen

rezkiy37 added 5 commits October 10, 2024 15:04

remove old components

9833f36

add WorkspaceInvoicingDetailsSection

af2a5e3

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

b9bcdbc

…ture/45175-invoicing-settings-screen

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

4d17baa

…ture/45175-invoicing-settings-screen

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

0d5a360

…ture/45175-invoicing-settings-screen

rezkiy37 mentioned this pull request Oct 17, 2024

Invoicing details section #50571

Merged

50 tasks

kubabutkiewicz approved these changes Oct 17, 2024

View reviewed changes

rezkiy37 changed the title ~~[WIP] Update Invoices setting screen~~ Update Invoices setting screen Oct 17, 2024

rezkiy37 marked this pull request as ready for review October 17, 2024 16:34

rezkiy37 requested a review from a team as a code owner October 17, 2024 16:34

melvin-bot Bot requested review from fedirjh and removed request for a team October 17, 2024 16:34

apply icon

52d02d8

rezkiy37 added 2 commits October 21, 2024 11:39

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

71db29a

…ture/45175-invoicing-settings-screen

tweak sections descriptions

09478e3

align test styles

71b7feb

use muted descriptions

43bc47e

rezkiy37 added 2 commits October 22, 2024 13:34

change balance view

aa5164b

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

f029d56

…ture/45175-invoicing-settings-screen

fedirjh approved these changes Oct 23, 2024

View reviewed changes

melvin-bot Bot requested a review from madmax330 October 23, 2024 17:44

shawnborton added the Ready To Build label Oct 23, 2024

madmax330 approved these changes Oct 24, 2024

View reviewed changes

madmax330 merged commit 8e13bcc into Expensify:main Oct 24, 2024

melvin-bot Bot added the Emergency label Oct 24, 2024

madmax330 removed the Emergency label Oct 24, 2024

github-actions Bot mentioned this pull request Oct 25, 2024

Deploy Checklist: New Expensify 2024-10-25 #51448

Closed

49 tasks

melvin-bot Bot mentioned this pull request Oct 29, 2024

[HOLD for payment 2024-11-05] Update Invoices setting screen #45175

Closed

dukenv0307 reviewed Jan 7, 2025

View reviewed changes

shahidtumbi pushed a commit to shahidtumbi/expensify-app that referenced this pull request Jun 2, 2026

Merge pull request Expensify#50565 from rezkiy37/feature/45175-invoic…

f28edd6

…ing-settings-screen

Conversation

rezkiy37 commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

shawnborton commented Oct 17, 2024

Uh oh!

melvin-bot Bot commented Oct 17, 2024

Uh oh!

rezkiy37 commented Oct 17, 2024

Uh oh!

rezkiy37 commented Oct 17, 2024

Uh oh!

shawnborton commented Oct 17, 2024

Uh oh!

shawnborton commented Oct 17, 2024

Uh oh!

rezkiy37 commented Oct 22, 2024

Uh oh!

rezkiy37 commented Oct 22, 2024

Uh oh!

shawnborton commented Oct 22, 2024

Uh oh!

shawnborton commented Oct 22, 2024

Uh oh!

rezkiy37 commented Oct 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawnborton commented Oct 22, 2024

Uh oh!

rezkiy37 commented Oct 22, 2024

Uh oh!

fedirjh commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

fedirjh left a comment

Choose a reason for hiding this comment

Uh oh!

shawnborton commented Oct 23, 2024

Uh oh!

dannymcclain commented Oct 23, 2024

Uh oh!

github-actions Bot commented Oct 23, 2024

Uh oh!

shawnborton commented Oct 23, 2024

Uh oh!

fedirjh commented Oct 23, 2024

Uh oh!

shawnborton commented Oct 24, 2024

Uh oh!

melvin-bot Bot commented Oct 24, 2024

Uh oh!

OSBotify commented Oct 24, 2024

Uh oh!

madmax330 commented Oct 24, 2024

Uh oh!

github-actions Bot commented Oct 25, 2024

Uh oh!

github-actions Bot commented Oct 29, 2024

Uh oh!

github-actions Bot commented Oct 29, 2024

Uh oh!

dukenv0307 Jan 7, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

rezkiy37 commented Oct 10, 2024 •

edited

Loading

rezkiy37 commented Oct 22, 2024 •

edited

Loading

fedirjh commented Oct 23, 2024 •

edited

Loading