fix: mention suggestions overlaps composer by dominictb · Pull Request #50132 · Expensify/App

dominictb · 2024-10-03T08:01:29Z

Details

Fixed Issues

$ #49474
PROPOSAL: #49474 (comment)

Tests

Create a room
Type "@" into chat compose

Verify on mobile, member suggestions list does not overlap composer

Verify that no errors appear in the JS console

Offline tests

QA Steps

Create a room
Type "@" into chat compose

Verify on mobile, member suggestions list does not overlap composer

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-10-03T08:08:18Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dominictb · 2024-10-03T08:38:16Z

@eVoloshchak Sorry I linked the wrong issue initially, feel free to unassign yourself. @parasharrajat Please review.

parasharrajat · 2024-10-03T19:01:27Z

@@ -1,5 +1,5 @@
 function getBottomSuggestionPadding(): number {
-    return 16;
+    return 26;


Why are we changing this?

This is to fix the suggestion overlap on iOS.

parasharrajat · 2024-10-08T15:33:23Z

@dominictb Any updates?

parasharrajat · 2024-10-10T17:13:26Z

BUG: extra gap on the Web and desktop between cursor and popup.

It would be good to just apply the changes on mWeb so it behave like mobile native.

parasharrajat · 2024-10-15T07:23:21Z

@dominictb Any updates? My plan is to get this merged today. I will be going on leave from 17 Oct to 25 oct.

…/49747

dominictb · 2024-10-15T08:24:25Z

@parasharrajat Please check again. I applied the changes for mWeb only.

parasharrajat · 2024-10-15T12:29:08Z

Screenshots

🔲 iOS / native

15.10.2024_17.47.34_REC.mp4

🔲 iOS / Safari

15.10.2024_17.34.44_REC.mp4

🔲 MacOS / Desktop

15.10.2024_17.43.23_REC.mp4

🔲 MacOS / Chrome

15.10.2024_17.32.15_REC.mp4

🔲 Android / Chrome

15.10.2024_17.43.57_REC.mp4

🔲 Android / native

parasharrajat · 2024-10-15T12:29:37Z

+import {isMobile} from '@libs/Browser';
+
 function getBottomSuggestionPadding(): number {
+    if (!isMobile()) {


This breaks Android.

parasharrajat · 2024-10-15T12:47:19Z

@dominictb I also noticed that the Send button is also overlapped by suggestion menu on Native when there is multi line input. let's fix that.

parasharrajat · 2024-10-16T04:28:53Z

@dominictb Bump....

dominictb · 2024-10-16T09:01:34Z

@parasharrajat I just came across this thread and seems like the overlap between the suggestion box and composer/send button is expected. It's to keep the distance between the suggestion box and the cursor not too far away.

If we manually modified getBottomSuggestionPadding, we would have the issue you mentioned here #50132 (comment) where there's extra gap between cursor and popup.

I think we should just close the PR since it is expected. Wdyt?

parasharrajat · 2024-10-16T09:27:03Z

@dominictb can you please cross post it on the issue?

dominictb · 2024-10-22T07:03:46Z

Close this PR as expected behavior.

fix: mention suggestion overlap composer

26750f4

dominictb marked this pull request as ready for review October 3, 2024 08:08

dominictb requested a review from a team as a code owner October 3, 2024 08:08

melvin-bot Bot requested review from eVoloshchak and removed request for a team October 3, 2024 08:08

fix ios overlap

bb9011a

parasharrajat reviewed Oct 3, 2024

View reviewed changes

BhuvaneshPatil mentioned this pull request Oct 8, 2024

[$250] Android - Composer - Suggestion list is overlapping with text in the composer and buttons #50377

Closed

1 of 6 tasks

dominictb added 3 commits October 15, 2024 14:56

Merge branch 'main' of https://github.com/dominictb/epsf-app into fix…

277674c

…/49747

only fix overlap on mobile

40791de

fix lint

e8340d1

parasharrajat suggested changes Oct 15, 2024

View reviewed changes

dominictb closed this Oct 22, 2024

Conversation

dominictb commented Oct 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 3, 2024

Uh oh!

dominictb commented Oct 3, 2024

Uh oh!

parasharrajat Oct 3, 2024

Choose a reason for hiding this comment

Uh oh!

dominictb Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

parasharrajat commented Oct 8, 2024

Uh oh!

parasharrajat commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parasharrajat commented Oct 15, 2024

Uh oh!

dominictb commented Oct 15, 2024

Uh oh!

parasharrajat commented Oct 15, 2024

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

Uh oh!

parasharrajat Oct 15, 2024

Choose a reason for hiding this comment

Uh oh!

parasharrajat commented Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parasharrajat commented Oct 16, 2024

Uh oh!

dominictb commented Oct 16, 2024

Uh oh!

parasharrajat commented Oct 16, 2024

Uh oh!

dominictb commented Oct 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dominictb commented Oct 3, 2024 •

edited

Loading

parasharrajat commented Oct 10, 2024 •

edited

Loading

parasharrajat commented Oct 15, 2024 •

edited

Loading

dominictb commented Oct 22, 2024 •

edited

Loading