[No QA] Card flow screens by koko57 · Pull Request #44376 · Expensify/App

koko57 · 2024-06-25T10:28:56Z

Details

Fixed Issues

$ #44308
PROPOSAL: -

Tests

In the browser type settings/workspaces/expensify-card/issue-new or in terminal type npx uri-scheme open new-expensify://settings/workspaces/expensify-card/issue-new --android or npx uri-scheme open new-expensify://settings/workspaces/expensify-card/issue-new --ios to open on android/ios.
Go through the flow - verify that the title for each step is correct and you can navigate to the previous and the next stepby clicking the header button or the "Next" button. "Issue card" button should navigate to the settings page.

NOTE: Each step will not have any elements besides the title - the content will be added in 44309

Verify that no errors appear in the JS console

Offline tests

QA Steps

n/a

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-06-25.at.14.42.02.mp4

Android: mWeb Chrome

Screen.Recording.2024-06-25.at.15.05.57.mp4

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-06-25.at.12.46.08.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-06-25.at.13.03.05.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-06-25.at.12.47.10.mp4

MacOS: Desktop

Screen.Recording.2024-06-25.at.15.08.51.mp4

mountiny

Thanks! Keep them coming, i think this can be noQA for applause but @allgandalf or @DylanDylann can review once this is ready

We just merge a PR to simplify the root navigator so there will be probably conflicts from there

mountiny · 2024-06-25T12:05:44Z

+    - RCT-Folly
+    - RCTRequired
+    - RCTTypeSafety
+    - React
+    - React-Codegen
+    - React-RCTFabric
+    - ReactCommon/turbomodule/core
  - react-native-document-picker (9.1.1):


are these changes necessary?

for sure not, reverting!

koko57 · 2024-06-25T12:13:23Z

We just merge a PR to simplify the root navigator so there will be probably conflicts from there

Ok, thanks, will take care of it!

melvin-bot · 2024-06-25T14:32:35Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2024-06-25T15:22:23Z

            benefit4: 'Customizable limits',
            addWorkEmail: 'Add work email address',
            checkingDomain: 'Hang tight! We are still working on enabling your Expensify Cards. Check back here in a few minutes.',
+            issueCard: 'Issue card',


@koko57 Did we confirm the translation with design team?

@DylanDylann translations are in the design doc

DylanDylann · 2024-06-25T16:45:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-06-26.at.21.01.43.mov

Android: mWeb Chrome

Screen.Recording.2024-06-26.at.20.58.42.mov

iOS: Native

Screen.Recording.2024-06-26.at.21.00.24.mov

iOS: mWeb Safari

Screen.Recording.2024-06-26.at.20.57.02.mov

MacOS: Chrome / Safari

Screen.Recording.2024-06-26.at.20.51.30.mov

MacOS: Desktop

Screen.Recording.2024-06-26.at.20.54.36.mov

DylanDylann · 2024-06-28T02:24:59Z

@koko57 Please resolve the conflict

DylanDylann · 2024-06-28T02:25:57Z

@mountiny All yours

koko57 · 2024-06-28T06:27:18Z

@DylanDylann @mountiny conflicts resolved

DylanDylann · 2024-06-28T11:02:50Z

@MariaHCD This PR is ready for review

mountiny

Changes look good to me

OSBotify · 2024-06-28T11:51:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-03T20:01:39Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.0.4-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-04T22:14:06Z

🚀 Cherry-picked to staging by https://github.com/tgolen in version: 9.0.4-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-10T11:00:59Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T20:20:35Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

rayane-d · 2024-08-10T20:42:57Z

+            <FormProvider
+                formID={ONYXKEYS.FORMS.ISSUE_NEW_EXPENSIFY_CARD_FORM}
+                submitButtonText={translate('common.next')}
+                onSubmit={submit}
+                style={[styles.mh5, styles.flexGrow1]}
+            >


FYI, this PR missed setting disablePressOnEnter={false} in the FormProvider usage, which caused #45269: Expensify Card - Hitting Enter on limit amount page does not proceed to the next page. However, we've now changed the default value of disablePressOnEnter to false. This way, we only need to use disablePressOnEnter={true} when necessary. #45269 (comment)

koko57 added 7 commits June 24, 2024 10:05

feat: setup a new route for expensify card

f41b7ca

feat: add translations, create first step page

0da25a7

feat: create the rest of the steps, give them a name and a header

9408da6

feat: create types, connect the steps

159fda6

feat: add issue new card button in the confirmation step

dc10601

chore: cleanup

21a0c6e

feat: leave comments

508b004

koko57 mentioned this pull request Jun 25, 2024

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [Workspace Feeds] [External] Logic for saving the data and navigating between steps #44308

Closed

fix: correct index

7fb2af0

mountiny assigned koko57 Jun 25, 2024

mountiny requested changes Jun 25, 2024

View reviewed changes

fix: resolve conflicts

e626365

koko57 requested a review from mountiny June 25, 2024 12:27

fix: lint

86209f3

koko57 marked this pull request as ready for review June 25, 2024 14:32

koko57 requested a review from a team as a code owner June 25, 2024 14:32

melvin-bot Bot requested review from DylanDylann and removed request for a team June 25, 2024 14:32

DylanDylann reviewed Jun 25, 2024

View reviewed changes

DylanDylann approved these changes Jun 26, 2024

View reviewed changes

fix: resolve conflicts

a660189

mountiny approved these changes Jun 28, 2024

View reviewed changes

MariaHCD approved these changes Jun 28, 2024

View reviewed changes

MariaHCD merged commit 3622deb into Expensify:main Jun 28, 2024

github-actions Bot mentioned this pull request Jul 3, 2024

Deploy Checklist: New Expensify 2024-07-03 #44782

Closed

rayane-d reviewed Aug 10, 2024

View reviewed changes

rayane-d mentioned this pull request Aug 10, 2024

[HOLD for payment 2024-08-09] [$250] Expensify Card - Hitting Enter on limit amount page does not proceed to the next page #45269

Closed

6 tasks done

Conversation

koko57 commented Jun 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny Jun 25, 2024

Choose a reason for hiding this comment

Uh oh!

koko57 Jun 25, 2024

Choose a reason for hiding this comment

Uh oh!

koko57 commented Jun 25, 2024

Uh oh!

melvin-bot Bot commented Jun 25, 2024

Uh oh!

DylanDylann Jun 25, 2024

Choose a reason for hiding this comment

Uh oh!

koko57 Jun 25, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DylanDylann commented Jun 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann commented Jun 28, 2024

Uh oh!

DylanDylann commented Jun 28, 2024

Uh oh!

koko57 commented Jun 28, 2024

Uh oh!

DylanDylann commented Jun 28, 2024

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jun 28, 2024

Uh oh!

OSBotify commented Jul 3, 2024

Uh oh!

OSBotify commented Jul 4, 2024

Uh oh!

OSBotify commented Jul 10, 2024

Uh oh!

OSBotify commented Jul 15, 2024

Uh oh!

rayane-d Aug 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

koko57 commented Jun 25, 2024 •

edited

Loading

DylanDylann commented Jun 25, 2024 •

edited

Loading

rayane-d Aug 10, 2024 •

edited

Loading