[Travel] Create Trip Receipt for newDot by cdOut · Pull Request #44086 · Expensify/App

cdOut · 2024-06-20T14:49:16Z

Details

Add different way of displaying the Thumbnail image for the EReceipt for travel expenses.

Fixed Issues

$ #37824
PROPOSAL:

Tests

Log in to OldDot with an account with access to Travel.
Go to https://staging.expensify.com/travel.
Click on travel.
Accept the terms and set an address again on your account.
You'll be redirected to Spotnana (if redirect doesn't work use this link: https://staging.travel.expensify.com/).
Book a new travel (so on the selector to "select trip" you should create a new one).
Log in to NewDot and open your default workspace chat.
Verify that the thumbnail for the EReceipt displays properly, depending on whether you reserved a transport or an accommodation.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

merge 'main' into trip-corrected/trip-receipt

melvin-bot · 2024-06-20T15:20:44Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shubham1206agra · 2024-06-21T14:21:43Z

@cdOut Can you merge main here?

merge main into trip-corrected/trip-receipt

cdOut · 2024-06-21T14:35:33Z

@shubham1206agra merged with newest main.

shubham1206agra · 2024-06-21T15:09:56Z

@cdOut I am unable to see correct Receipts.

cdOut · 2024-06-21T15:24:01Z

@cdOut I am unable to see correct Receipts.

Very odd as the receipt color is very closely related to the icon too. Could you check this for Desktop and native?

shubham1206agra · 2024-06-21T15:35:44Z

@cdOut Not working in Desktop too

shubham1206agra · 2024-06-26T12:54:39Z

@cdOut Can you merge main please?

merge main into trip-corrected/trip-receipt

cdOut · 2024-06-26T14:58:15Z

@shubham1206agra merged main, if the problem still persists could you give me a console.log(propsObj) after the conditional in ReportActionItemImage.tsx?

shubham1206agra · 2024-06-26T15:33:40Z

@cdOut I am unable to see receipt now.

cdOut · 2024-07-03T11:04:15Z

@shubham1206agra I've pushed changes that fix the issues, PR is ready for a retest.

merge main into trip-corrected/trip-receipt

shubham1206agra · 2024-07-03T11:22:25Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-07-03T11:23:00Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #37824 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

OSBotify · 2024-07-03T17:20:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-03T20:00:57Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.4-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-04T22:13:24Z

🚀 Cherry-picked to staging by https://github.com/tgolen in version: 9.0.4-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-10T10:58:23Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

grgia · 2024-07-12T10:02:41Z

+    switch (reservationType) {
+        case CONST.RESERVATION_TYPE.FLIGHT:
+        case CONST.RESERVATION_TYPE.CAR:
+            return {tripIcon: Expensicons.Plane, tripBGColor: CONST.ERECEIPT_COLORS.PINK};


We need to remove tripBGColor and calculate the color combos using the same methods in https://github.com/Expensify/App/blob/main/src/components/EReceipt.tsx#L35-L36

OSBotify · 2024-07-15T20:19:41Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

cdOut added 5 commits June 20, 2024 16:28

add trip receipt case

ee0f65b

fix prettier

4e34eb1

correct type imports and lint

44a368f

set correct icon for accommodation

85f4941

Merge branch 'main' into trip-corrected/trip-receipt

95ce1e6

merge 'main' into trip-corrected/trip-receipt

cdOut marked this pull request as ready for review June 20, 2024 15:20

cdOut requested a review from a team as a code owner June 20, 2024 15:20

melvin-bot Bot requested review from shubham1206agra and removed request for a team June 20, 2024 15:20

Merge branch 'main' into trip-corrected/trip-receipt

2e3821b

merge main into trip-corrected/trip-receipt

cdOut added 2 commits June 21, 2024 17:52

correct conditional for displaying the EReceipt icon

4d700b7

fix conditional for displaying travel ereceipt

c13f952

Merge branch 'main' into trip-corrected/trip-receipt

f502c83

merge main into trip-corrected/trip-receipt

correct logic for displaying the trip receipt

c40f681

Merge branch 'main' into trip-corrected/trip-receipt

d627fdd

merge main into trip-corrected/trip-receipt

shubham1206agra approved these changes Jul 3, 2024

View reviewed changes

melvin-bot Bot requested a review from yuwenmemon July 3, 2024 11:23

yuwenmemon approved these changes Jul 3, 2024

View reviewed changes

yuwenmemon merged commit 2fa1734 into Expensify:main Jul 3, 2024

github-actions Bot mentioned this pull request Jul 3, 2024

Deploy Checklist: New Expensify 2024-07-03 #44782

Closed

melvin-bot Bot mentioned this pull request Jul 10, 2024

[HOLD for payment 2024-07-17] [$500] [CRITICAL] Create Trip Receipt for newDot #37824

Closed

grgia reviewed Jul 12, 2024

View reviewed changes

Conversation

cdOut commented Jun 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 20, 2024

Uh oh!

shubham1206agra commented Jun 21, 2024

Uh oh!

cdOut commented Jun 21, 2024

Uh oh!

shubham1206agra commented Jun 21, 2024

Uh oh!

cdOut commented Jun 21, 2024

Uh oh!

shubham1206agra commented Jun 21, 2024

Uh oh!

shubham1206agra commented Jun 26, 2024

Uh oh!

cdOut commented Jun 26, 2024

Uh oh!

shubham1206agra commented Jun 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cdOut commented Jul 3, 2024

Uh oh!

shubham1206agra commented Jul 3, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 3, 2024

Uh oh!

OSBotify commented Jul 3, 2024

Uh oh!

OSBotify commented Jul 3, 2024

Uh oh!

OSBotify commented Jul 4, 2024

Uh oh!

OSBotify commented Jul 10, 2024

Uh oh!

grgia Jul 12, 2024

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jul 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cdOut commented Jun 20, 2024 •

edited

Loading

shubham1206agra commented Jun 26, 2024 •

edited

Loading