Delay in showing new currency when selecting a new currency by ZhenjaHorbach · Pull Request #42183 · Expensify/App

ZhenjaHorbach · 2024-05-15T08:50:22Z

Details

Delay in showing new currency when selecting a new currency

Fixed Issues

$ #41515
PROPOSAL: #41515 (comment)

Tests

Launch New Expensify app.
Go to FAB.
Tap Submit expense.
Tap on the currency.
Select a different currency
Verify that when the screen change animation is finished we have selected currency
Go to Account Settings
Open Workspaces and choose a workspace
In Profile tap on Default currency
Select a different currency
Verify that when the screen change animation is finished we have selected currency
On Workspace screen open More features
Enable any Feature
Verify that when the screen is changed we have feature screen without "Not Found" for a split second

Verify that no errors appear in the JS console

Offline tests

Launch New Expensify app.
Go to FAB.
Tap Submit expense.
Tap on the currency.
Select a different currency
Verify that when the screen change animation is finished we have selected currency
Go to Account Settings
Open Workspaces and choose a workspace
In Profile tap on Default currency
Select a different currency
Verify that when the screen change animation is finished we have selected currency
On Workspace screen open More features
Enable any Feature
Verify that when the screen is changed we have feature screen without "Not Found" for a split second

QA Steps

Launch New Expensify app.
Go to FAB.
Tap Submit expense.
Tap on the currency.
Select a different currency
Verify that when the screen change animation is finished we have selected currency
Go to Account Settings
Open Workspaces and choose a workspace
In Profile tap on Default currency
Select a different currency
Verify that when the screen change animation is finished we have selected currency
On Workspace screen open More features
Enable any Feature
Verify that when the screen is changed we have feature screen without "Not Found" for a split second

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

2024-05-17.20.34.07.mov

Android: mWeb Chrome

android.mov

2024-05-17.20.34.07.mov

iOS: Native

ios.mov

2024-05-17.20.32.01.mov

iOS: mWeb Safari

ios-web.mov

2024-05-17.20.38.39.mov

MacOS: Chrome / Safari

web.mov

2024-05-17.20.35.40.mov

MacOS: Desktop

desktop.mov

2024-05-17.20.40.13.mov

melvin-bot · 2024-05-15T08:50:27Z

@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2024-05-15T08:58:23Z

@rojiphil
Hello )
PR is ready

rojiphil

I have left few comments for consideration. Please check.

rojiphil · 2024-05-17T18:02:11Z

@@ -0,0 +1,13 @@
+export default function setNavigationActionToMicrotaskQueue(nabigationAction: () => void) {


Let us use the correct word i.e. navigationAction here

Sorry, but what do you mean?
If you are talking about a mistake in a word, I have already fixed it)

I am referring to nabigationAction which doesn't seem correct.

Oh
Sorry
You're right )
I didn't notice in these places
Thank you

rojiphil · 2024-05-17T18:03:49Z

-            Navigation.navigate(featureRoute);
-        });
-    });
+    Navigation.setNavigationActionToMicrotaskQueue(() => Navigation.navigate(featureRoute));


NAB but as we made changes here, let us add a test case to avoid possible regression.

rojiphil · 2024-05-17T18:04:37Z

    const onSelectCurrency = (item: CurrencyListItem) => {
        Policy.updateGeneralSettings(policy?.id ?? '', policy?.name ?? '', item.currencyCode);
-        Navigation.goBack();
+        Navigation.setNavigationActionToMicrotaskQueue(Navigation.goBack);


NAB but same here. Let us add a test case for this to avoid possible regression.

rojiphil · 2024-05-18T03:55:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari

42183-web-safari.mp4

Android: Native

42183-android-native.mp4

Android: mWeb Chrome

42183-mweb-chrome.mp4

iOS: Native

42183-ios-native.mp4

iOS: mWeb Safari

42183-mweb-safari.mp4

MacOS: Desktop

42183-desktop.mp4

rojiphil

Thanks. LGTM and tests well too.

amyevans

Looks good!

amyevans · 2024-05-20T15:45:57Z

[Currently held on merge freeze]

rojiphil · 2024-05-28T02:22:20Z

@ZhenjaHorbach There are conflicts here. Please resolve.

…-a-new-currency

shawnborton · 2024-05-28T08:02:57Z

Seems fine from a design-perspective too.

OSBotify · 2024-05-28T14:36:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-29T09:43:09Z

🚀 Deployed to staging by https://github.com/amyevans in version: 1.4.77-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T21:25:58Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T22:37:56Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix bug with Delay in showing new currency when selecting a new currency

7c7c15f

ZhenjaHorbach requested a review from a team as a code owner May 15, 2024 08:50

melvin-bot Bot requested review from rojiphil and removed request for a team May 15, 2024 08:50

Rename setNavigationActionToMicrotaskQueue function

1dbf9cd

rojiphil reviewed May 17, 2024

View reviewed changes

rename param for setNavigationActionToMicrotaskQueue

49b050f

rojiphil approved these changes May 18, 2024

View reviewed changes

melvin-bot Bot requested a review from amyevans May 18, 2024 03:55

amyevans previously approved these changes May 20, 2024

View reviewed changes

Fix conflicts and update branch

e9dc2ef

ZhenjaHorbach dismissed amyevans’s stale review via e9dc2ef May 28, 2024 07:59

ZhenjaHorbach requested a review from a team as a code owner May 28, 2024 07:59

Merge branch 'main' into delay-in-showing-new-currency-when-selecting…

da95b79

…-a-new-currency

shawnborton approved these changes May 28, 2024

View reviewed changes

amyevans approved these changes May 28, 2024

View reviewed changes

amyevans merged commit 9a6514e into Expensify:main May 28, 2024

github-actions Bot mentioned this pull request May 29, 2024

Deploy Checklist: New Expensify 2024-05-29 #42741

Closed

melvin-bot Bot mentioned this pull request May 30, 2024

[HOLD for payment 2024-06-06] [$250] BNP - Delay in showing new currency when selecting a new currency #41515

Closed

3 of 6 tasks

		@@ -0,0 +1,13 @@
		export default function setNavigationActionToMicrotaskQueue(nabigationAction: () => void) {

Conversation

ZhenjaHorbach commented May 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 15, 2024

Uh oh!

ZhenjaHorbach commented May 15, 2024

Uh oh!

rojiphil left a comment

Choose a reason for hiding this comment

Uh oh!

rojiphil May 17, 2024

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach May 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rojiphil May 17, 2024

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach May 17, 2024

Choose a reason for hiding this comment

Uh oh!

rojiphil May 17, 2024

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach May 17, 2024

Choose a reason for hiding this comment

Uh oh!

rojiphil May 17, 2024

Choose a reason for hiding this comment

Uh oh!

rojiphil commented May 18, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

rojiphil left a comment

Choose a reason for hiding this comment

Uh oh!

amyevans left a comment

Choose a reason for hiding this comment

Uh oh!

amyevans commented May 20, 2024

Uh oh!

rojiphil commented May 28, 2024

Uh oh!

shawnborton commented May 28, 2024

Uh oh!

OSBotify commented May 28, 2024

Uh oh!

OSBotify commented May 29, 2024

Uh oh!

OSBotify commented May 30, 2024

Uh oh!

OSBotify commented May 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ZhenjaHorbach commented May 15, 2024 •

edited

Loading

ZhenjaHorbach May 17, 2024 •

edited

Loading