Show scanning status bar in a one transaction report

[bernhardoj]

Details

We want to show the scanning status bar below the header when the one transaction report request is in scanning.

Fixed Issues

$ #40828
PROPOSAL: #40828 (comment)

Tests

Same as QA Steps

• Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

1. Open a chat with no unsettled money request
2. Create a new scan request
3. Press the money request preview to open the one transaction report
4. Verify there is a scanning status bar below the header

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Untitled.mov

Android: mWeb Chrome

Screen.Recording.2024-05-08.at.19.55.51.mov

iOS: Native

Screen.Recording.2024-05-08.at.19.52.50.mov

iOS: mWeb Safari

Screen.Recording.2024-05-08.at.19.44.10.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-08.at.19.32.02.mov

MacOS: Desktop

Screen.Recording.2024-05-08.at.19.43.26.mov

[melvin-bot]

@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[bernhardoj]

So, I refactor the component to have a wrapper so we can have the isScanning status in MoneyReportHeaderContent to hide the next step status bar.

And what I mean here is that the scanning status bar won't show if there is multiple request (not a one transaction report)

The wording also won't match the multiple request view

App/src/languages/en.ts

Line 656 in e0b6a06

receiptStatusText: "Only you can see this receipt when it's scanning. Check back later or enter the details now.",

[rojiphil]

And what I mean here is that the scanning status bar won't show if there is multiple request (not a one transaction report)

The wording also won't match the multiple request view

Ok. While I agree that the wording won't match correctly in this scenario, showing Next steps status bar when all the existing requests are being smart scanned (i.e. in progress) does not make sense too. So I think we can change the wording appropriately in this scenario to something like this
Only you can see these receipts when scanning is in progress. Check back later or enter the details of individual receipts.
and show the scanning status bar instead of Next steps.
What do you think?

[bernhardoj]

@rojiphil yeah, I agree the next step doesn't make sense when all requests are scanning. I think we really need someone internal this time to confirm this because we are introducing a new copy and will need a translation too.

cc: @thienlnam

[thienlnam]

Could you summarize the problem and steps that are taken to get into this state, and what the planned solution is?

[bernhardoj]

So, in this PR, we add a scan status bar to the one/single transaction report

and hide the next step status bar when it's scanning, to replicate the transaction thread view.

When we add more expense, it's not a one/single transaction report anymore, so the scan status bar hides and the next step status bar is shown as shown in the video below

Screen.Recording.2024-05-14.at.16.34.10.mov

@rojiphil suggest to keep showing the scan status bar and hiding the next step if all receipt is scanning. @thienlnam Do you agree with this change? If yes, we might need to have a new text for multiple request for the scan status bar (1st image above).

Untitled.mov

[thienlnam]

Thanks for that - I discussed this internally here, seems like there is consensus for

If there are any receipts scanning we will display the scan status bar and hide the next step status bar

I don't think we need different copy there though, we can probably use the same one

[bernhardoj]

I don't think we need different copy there though, we can probably use the same one

Got it.

If there are any receipts scanning we will display the scan status bar and hide the next step status bar

@thienlnam For confirmation, if we have 1 scanning and 1 not-scanning, do we still show the scan status bar and hide the next step?

[thienlnam]

Yes that is correct

[bernhardoj]

Thanks for the confirmation! To keep the git history clean, I have opened a new PR instead here. Closing this one.