Skip to content

[Wave Collect][Xero] Fix disconnect Xero #41657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lakchote merged 2 commits into from
May 6, 2024
Merged

[Wave Collect][Xero] Fix disconnect Xero #41657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd51314
fix: xero disconnection
mananjadhav May 5, 2024
25c5cb4
style: prettier fix
mananjadhav May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions src/libs/actions/connections/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,22 +25,12 @@ function removePolicyConnection(policyID: string, connectionName: PolicyConnecti
value: null,
},
];
const failureData: OnyxUpdate[] = [
// {
// onyxMethod: Onyx.METHOD.MERGE,
// key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
// value: {
// errorFields: {
// avatar: ErrorUtils.getMicroSecondOnyxError('avatarWithImagePicker.deleteWorkspaceError'),
// },
// },
// },
];

const parameters: RemovePolicyConnectionParams = {
policyID,
connectionName,
};
API.write(WRITE_COMMANDS.REMOVE_POLICY_CONNECTION, parameters, {optimisticData, failureData});
API.write(WRITE_COMMANDS.REMOVE_POLICY_CONNECTION, parameters, {optimisticData});
}
function updatePolicyConnectionConfig<TConnectionName extends ConnectionName, TSettingName extends keyof Connections[TConnectionName]['config']>(
policyID: string,
Expand Down
4 changes: 3 additions & 1 deletion src/pages/workspace/accounting/PolicyAccountingPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,9 @@ function PolicyAccountingPage({policy, connectionSyncProgress}: PolicyAccounting
title={translate('workspace.accounting.disconnectTitle', connectedIntegration)}
isVisible={isDisconnectModalOpen}
onConfirm={() => {
removePolicyConnection(policyID, CONST.POLICY.CONNECTIONS.NAME.QBO);
if (connectedIntegration) {
removePolicyConnection(policyID, connectedIntegration);
}
setIsDisconnectModalOpen(false);
}}
onCancel={() => setIsDisconnectModalOpen(false)}
Expand Down