Skip to content

[CP Staging] Revert Fullstory lib changes - #40894

Merged
danieldoglas merged 4 commits into
Expensify:mainfrom
mananjadhav:revert-full-story
Apr 24, 2024
Merged

[CP Staging] Revert Fullstory lib changes#40894
danieldoglas merged 4 commits into
Expensify:mainfrom
mananjadhav:revert-full-story

Conversation

@mananjadhav

@mananjadhav mananjadhav commented Apr 24, 2024 •
edited by mountiny
Loading

Copy link
Copy Markdown
Collaborator

Reverting the Fullstory integration fixes the app crash on video upload.

Details

Fixed Issues

$ #40874
$ #40784
$ #40910
PROPOSAL: N/A

Tests

  1. Go to any chat
  2. Click on the Create (+) button
  3. Click on Add attachment and upload a video.
  4. Ensure the video is successfully uploaded.
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Test steps

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android-revert-fullstory.mp4
Android: mWeb Chrome
mweb-chrome-revert-fullstory.mov
iOS: Native
ios-revert-fullstory.mov
iOS: mWeb Safari
mweb-safari-revert-fullstory.mov
MacOS: Chrome / Safari
web-revert-fullstory.mov
MacOS: Desktop
desktop-revert-fullstory.mov

@mananjadhav
Revert "Merge pull request Expensify#40807 from Expensify/dsilva_chan…
df8d7e3 
…gingPropertyBeingUsedByFullstory"

This reverts commit 51372ab, reversing
changes made to e58ec49.
@mananjadhav
Revert "Merge pull request Expensify#40817 from Expensify/dsilva_chan…
41898c3 
…gingGTMToThirdPartyScripts"

This reverts commit 7ea2b6c, reversing
changes made to 0358841.
@mananjadhav
Revert "Merge pull request Expensify#40294 from LCOleksii/fullstory-i…
bcc705e 
…ntegration"

This reverts commit 1928c3a, reversing
changes made to 9b839f4.
@mananjadhav mananjadhav changed the title Revert full story Revert Fullstory lib changes Apr 24, 2024
@github-actions

github-actions Bot commented Apr 24, 2024

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/40894/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/40894/index.html
Android iOS
Desktop 💻 Web 🕸️
❌ FAILED ❌ https://40894.pr-testing.expensify.com
The QR code can't be generated, because the Desktop build failed Web

👀 View the workflow run that generated this build 👀

@mountiny mountiny changed the title Revert Fullstory lib changes [CP Staging] Revert Fullstory lib changes Apr 24, 2024
@melvin-bot

melvin-bot Bot commented Apr 24, 2024

Copy link
Copy Markdown

Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work?

@mountiny mountiny mentioned this pull request Apr 24, 2024
Closed
6 tasks
@mananjadhav

mananjadhav commented Apr 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

@mountiny @danieldoglas I am opening this up for review. I am having some issues with my Android build, so I'll test on the adhoc build.

If we're able to fix it with Fullstory we can close this one.

@mananjadhav
mananjadhav marked this pull request as ready for review April 24, 2024 16:29
@mananjadhav
mananjadhav requested a review from a team as a code owner April 24, 2024 16:29
@melvin-bot
melvin-bot Bot requested review from ishpaul777 and removed request for a team April 24, 2024 16:29
@melvin-bot

melvin-bot Bot commented Apr 24, 2024

Copy link
Copy Markdown

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny
mountiny approved these changes Apr 24, 2024
View reviewed changes

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this also fixed #40910

@danieldoglas
danieldoglas merged commit f0c6589 into Expensify:main Apr 24, 2024
OSBotify pushed a commit that referenced this pull request Apr 24, 2024
@danieldoglas @OSBotify
Merge pull request #40894 from mananjadhav/revert-full-story
1e5deec 
[CP Staging] Revert Fullstory lib changes

(cherry picked from commit f0c6589)
@github-actions github-actions Bot mentioned this pull request Apr 24, 2024
Closed
74 tasks
@OSBotify

OSBotify commented Apr 24, 2024

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.4.65-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

This was referenced Apr 25, 2024
Closed
Closed
@OSBotify

OSBotify commented Apr 25, 2024

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.65-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danieldoglas danieldoglas danieldoglas approved these changes
@mountiny mountiny mountiny approved these changes
@ishpaul777 ishpaul777 Awaiting requested review from ishpaul777

Assignees

@mananjadhav mananjadhav

Labels

Ready To Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mananjadhav @OSBotify @danieldoglas @mountiny