[CP Staging] Don't show the loading screen when the connections feature is not enabled by hayata-suenaga · Pull Request #40893 · Expensify/App

hayata-suenaga · 2024-04-24T13:56:06Z

Details

If the Connections feature is not enabled on the More Features page, we don't fetch the connections data. However, we forgot to account for this case, which resulted in the infinite loading indicator as the Categories screen was waiting for the connections data which won't be fetched under this condition.

Fixed Issues

$ #40875
PROPOSAL: N/A

Tests / QA Steps

Have a policy that does not have accounting integration feature turned on
This policy should have categories enabled too
Sign out
Sign back in
Go to the Categories page
Verify the categories page is loaded
Verify that no errors appear in the JS console

Offline tests

N/A

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…t enabled

melvin-bot · 2024-04-24T13:56:36Z

@blimpich Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

s77rt · 2024-04-24T14:05:10Z

This is not fixing the bug from my side

s77rt · 2024-04-24T14:05:19Z

with accounting enabled ^

mountiny · 2024-04-24T14:05:45Z

@hayata-suenaga thanks! can you please add tests?

I find the logic a bit odd as the feature flag is co-dependent to hasConnectionsDataBeenFetched that only changes once and if its true we wont ever load it again

hayata-suenaga · 2024-04-24T14:06:39Z

@mountiny, the test steps are in the OP 😄

mountiny · 2024-04-24T14:08:36Z

@hayata-suenaga they werent when I was posting the comment :D

regarding this #40881 (comment)

its not true that this logic would load it in Categories page. It does not load it if the connections feature is not on.

hayata-suenaga · 2024-04-24T14:09:45Z

co-dependent to hasConnectionsDataBeenFetched

I don't know what you mean by this, but we only need to fetch the connections data if the connections feature is enabled.

only changes once and if its true we wont ever load it again

This value will be reset on every user session as you can see from initWithStoredValues: false,

hayata-suenaga · 2024-04-24T14:11:47Z

It does not load it if the connections feature is not on.

yes, that's right. That's why we have to check if the connections feature is enabled or not before showing the loading indicator.

s77rt · 2024-04-24T14:14:32Z

@hayata-suenaga If initWithStoredValues is false then hasConnectionsDataBeenFetched will be null. This will cause the loader to show indefinitely. The effect won't call openPolicyAccountingPage due to the early return

hayata-suenaga · 2024-04-24T14:14:49Z

This is not fixing the bug from my side
with accounting enabled ^

Trying to reproduce this, but I cannot right now. Let me keep trying

hayata-suenaga · 2024-04-24T14:20:26Z

@s77rt okay now it's ready 😓

s77rt · 2024-04-24T14:42:13Z

Rewriting the conditions in variable should help with code readability. I don't see why we need to status though

const needToFetchConnections = !hasConnectionsDataBeenFetched && props.policy?.areConnectionsEnabled && !props?.policy?.connections;
const isLoading = needToFetchConnections || status === 'loading';

s77rt · 2024-04-24T14:45:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

s77rt · 2024-04-24T14:52:23Z

Added only screenshot for web. The simulator is OOO 😅. Let's get this merged

mountiny

Thanks

melvin-bot · 2024-04-24T14:53:05Z

@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hayata-suenaga · 2024-04-24T14:56:23Z

requesting cherry pick -> https://expensify.slack.com/archives/C07J32337/p1713970530252449

OSBotify · 2024-04-24T15:00:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…screen-when-fetching-connections-data [CP Staging] Don't show the loading screen when the connections feature is not enabled (cherry picked from commit cd3966e)

…-40893-1 🍒 Cherry pick PR #40893 to staging 🍒

OSBotify · 2024-04-24T15:49:33Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.65-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-25T13:47:24Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.65-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: don't show the loading screen when the connections feature is no…

98243fc

…t enabled

hayata-suenaga self-assigned this Apr 24, 2024

hayata-suenaga requested a review from a team as a code owner April 24, 2024 13:56

hayata-suenaga mentioned this pull request Apr 24, 2024

[CP Staging] Fix infinite loading of categories page #40881

Closed

50 tasks

melvin-bot Bot requested review from blimpich and removed request for a team April 24, 2024 13:56

hayata-suenaga changed the title ~~Don't show the loading screen when the connections feature is not enabled~~ [CP Staging] Don't show the loading screen when the connections feature is not enabled Apr 24, 2024

hayata-suenaga requested review from mountiny and s77rt April 24, 2024 14:04

fix: revert the comment

4dc5a82

Hayata Suenaga added 2 commits April 24, 2024 10:18

fix: account for null value case

a03cdd3

fix: conditional

279a72b

s77rt approved these changes Apr 24, 2024

View reviewed changes

mountiny approved these changes Apr 24, 2024

View reviewed changes

melvin-bot Bot requested a review from deetergp April 24, 2024 14:53

mountiny merged commit cd3966e into main Apr 24, 2024

mountiny deleted the hayata-fix-infinite-loading-screen-when-fetching-connections-data branch April 24, 2024 14:53

os-botify Bot mentioned this pull request Apr 24, 2024

🍒 Cherry pick PR #40893 to staging 🍒 #40909

Merged

hayata-suenaga pushed a commit that referenced this pull request Apr 24, 2024

Merge pull request #40909 from Expensify/mountiny-cherry-pick-staging…

a8f534b

…-40893-1 🍒 Cherry pick PR #40893 to staging 🍒

github-actions Bot mentioned this pull request Apr 24, 2024

Deploy Checklist: New Expensify 2024-04-23 #40843

Closed

74 tasks

melvin-bot Bot mentioned this pull request Apr 25, 2024

[HOLD for payment 2024-05-03] Unable to load categories in the workspace settings #40875

Closed

6 tasks

Conversation

hayata-suenaga commented Apr 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests / QA Steps

Offline tests

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 24, 2024

Uh oh!

s77rt commented Apr 24, 2024

Uh oh!

s77rt commented Apr 24, 2024

Uh oh!

mountiny commented Apr 24, 2024

Uh oh!

hayata-suenaga commented Apr 24, 2024

Uh oh!

mountiny commented Apr 24, 2024

Uh oh!

hayata-suenaga commented Apr 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hayata-suenaga commented Apr 24, 2024

Uh oh!

s77rt commented Apr 24, 2024

Uh oh!

hayata-suenaga commented Apr 24, 2024

Uh oh!

hayata-suenaga commented Apr 24, 2024

Uh oh!

s77rt commented Apr 24, 2024

Uh oh!

s77rt commented Apr 24, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

s77rt commented Apr 24, 2024

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Apr 24, 2024

Uh oh!

hayata-suenaga commented Apr 24, 2024

Uh oh!

OSBotify commented Apr 24, 2024

Uh oh!

OSBotify commented Apr 24, 2024

Uh oh!

OSBotify commented Apr 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hayata-suenaga commented Apr 24, 2024 •

edited

Loading

hayata-suenaga commented Apr 24, 2024 •

edited

Loading