-
Notifications
You must be signed in to change notification settings - Fork 4k
Improve UX of modifying single line text inputs #40757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f4d7bd2
Improve UX of modifying single line text inputs
nkdengineer 25af916
resolve conflict
nkdengineer ef96598
add clear icon
nkdengineer d141a51
add cicler svg
nkdengineer 12e7820
fix icon size
nkdengineer d9b34bf
Update src/components/TextInput/BaseTextInput/types.ts
nkdengineer 82e1c2d
add translation
nkdengineer 84fa2ce
fix conflict
nkdengineer 3b098fe
fix remove onClearInput
nkdengineer 5ceb448
fix: add TextInputClearButton component
nkdengineer 30c3847
Merge branch 'main' into fix/40313
nkdengineer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| import {forwardRef} from 'react'; | ||
| import Icon from '@components/Icon'; | ||
| import {PressableWithoutFeedback} from '@components/Pressable'; | ||
| import Tooltip from '@components/Tooltip'; | ||
| import useLocalize from '@hooks/useLocalize'; | ||
| import useTheme from '@hooks/useTheme'; | ||
| import useThemeStyles from '@hooks/useThemeStyles'; | ||
| import CONST from '@src/CONST'; | ||
|
|
||
| type TextInputClearButtonProps = { | ||
| onPressButton: () => void; | ||
| }; | ||
|
|
||
| function TextInputClearButton({onPressButton}: TextInputClearButtonProps) { | ||
| const theme = useTheme(); | ||
| const styles = useThemeStyles(); | ||
| const {translate} = useLocalize(); | ||
| return ( | ||
| <Tooltip text={translate('common.clear')}> | ||
| <PressableWithoutFeedback | ||
| style={[styles.mt4, styles.ml1]} | ||
| accessibilityRole={CONST.ROLE.BUTTON} | ||
| accessibilityLabel={translate('common.clear')} | ||
| onMouseDown={(e) => { | ||
| e.preventDefault(); | ||
| }} | ||
| onPress={onPressButton} | ||
| > | ||
| <Icon | ||
| src={Expensicons.Clear} | ||
| width={20} | ||
| height={20} | ||
| fill={theme.icon} | ||
| /> | ||
| </PressableWithoutFeedback> | ||
| </Tooltip> | ||
| ); | ||
| } | ||
|
|
||
| TextInputClearButton.displayName = 'TextInputClearButton'; | ||
|
|
||
| export default forwardRef(TextInputClearButton); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thanks! ❤️