Skip to content

[No QA] Update type of employee list to indicate it's an array of PolicyMembers #39148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuwenmemon merged 5 commits into from
Mar 29, 2024
Merged

[No QA] Update type of employee list to indicate it's an array of PolicyMembers #39148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
761434d
Update type of employee list to indicate it's an array of PolicyMembers
yuwenmemon Mar 28, 2024
811add0
Use OnyxTypes
yuwenmemon Mar 28, 2024
eb828ed
Lawd help me typescript
yuwenmemon Mar 28, 2024
9cfcda9
Merge branch 'main' of github.com:Expensify/App into yuwen-memberTypes
yuwenmemon Mar 29, 2024
945aca2
ESLint
yuwenmemon Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/types/onyx/Policy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import type {ValueOf} from 'type-fest';
import type CONST from '@src/CONST';
import type * as OnyxTypes from '.';
import type * as OnyxCommon from './OnyxCommon';

type Unit = 'mi' | 'km';
Expand Down Expand Up @@ -328,7 +329,7 @@ type Policy = OnyxCommon.OnyxValueWithOfflineFeedback<
submitsTo?: number;

/** The employee list of the policy */
employeeList?: [];
employeeList?: OnyxTypes.PolicyMembers | [];

/** The reimbursement choice for policy */
reimbursementChoice?: ValueOf<typeof CONST.POLICY.REIMBURSEMENT_CHOICES>;
Expand Down
9 changes: 9 additions & 0 deletions src/types/onyx/PolicyMember.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,15 @@ type PolicyMember = OnyxCommon.OnyxValueWithOfflineFeedback<{
/** Role of the user in the policy */
role?: string;

/** Email of the user */
email?: string;

/** Email of the user this user forwards all approved reports to */
forwardsTo?: string;

/** Email of the user this user submits all reports to */
submitsTo?: string;

/**
* Errors from api calls on the specific user
* {<timestamp>: 'error message', <timestamp2>: 'error message 2'}
Expand Down