Skip to content

fix: Error in JS console when right-clicking in the app #38494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deetergp merged 6 commits into from
Mar 21, 2024
Merged

fix: Error in JS console when right-clicking in the app #38494

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f049a0b
fix: Error in JS console when right-clicking in the app
dukenv0307 Mar 18, 2024
30053e4
fix patch name
dukenv0307 Mar 19, 2024
379739b
fix lint
dukenv0307 Mar 19, 2024
02d5702
fix lint
dukenv0307 Mar 19, 2024
bfd9fb6
Merge branch 'main' into fix/37877
dukenv0307 Mar 21, 2024
89c2619
rename fix pointer event down
dukenv0307 Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions patches/react-native-web+0.19.9+006+fixPointerEventDown.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
diff --git a/node_modules/react-native-web/dist/modules/useResponderEvents/ResponderSystem.js b/node_modules/react-native-web/dist/modules/useResponderEvents/ResponderSystem.js
index 0aec2d6..a71aec2 100644
--- a/node_modules/react-native-web/dist/modules/useResponderEvents/ResponderSystem.js
+++ b/node_modules/react-native-web/dist/modules/useResponderEvents/ResponderSystem.js
@@ -133,7 +133,7 @@ to return true:wantsResponderID| |

import createResponderEvent from './createResponderEvent';
import { isCancelish, isEndish, isMoveish, isScroll, isSelectionChange, isStartish } from './ResponderEventTypes';
-import { getLowestCommonAncestor, getResponderPaths, hasTargetTouches, hasValidSelection, isPrimaryPointerDown, setResponderId } from './utils';
+import { getLowestCommonAncestor, getResponderPaths, hasTargetTouches, hasValidSelection, isPrimaryOrSecondaryPointerDown, setResponderId } from './utils';
import { ResponderTouchHistoryStore } from './ResponderTouchHistoryStore';
import canUseDOM from '../canUseDom';

@@ -225,7 +225,7 @@ function eventListener(domEvent) {
}
return;
}
- var isStartEvent = isStartish(eventType) && isPrimaryPointerDown(domEvent);
+ var isStartEvent = isStartish(eventType) && isPrimaryOrSecondaryPointerDown(domEvent);
var isMoveEvent = isMoveish(eventType);
var isEndEvent = isEndish(eventType);
var isScrollEvent = isScroll(eventType);
diff --git a/node_modules/react-native-web/dist/modules/useResponderEvents/utils.js b/node_modules/react-native-web/dist/modules/useResponderEvents/utils.js
index 7382cdd..d88f6c0 100644
--- a/node_modules/react-native-web/dist/modules/useResponderEvents/utils.js
+++ b/node_modules/react-native-web/dist/modules/useResponderEvents/utils.js
@@ -148,14 +148,14 @@ export function hasValidSelection(domEvent) {
/**
* Events are only valid if the primary button was used without specific modifier keys.
*/
-export function isPrimaryPointerDown(domEvent) {
+export function isPrimaryOrSecondaryPointerDown(domEvent) {
var altKey = domEvent.altKey,
button = domEvent.button,
buttons = domEvent.buttons,
ctrlKey = domEvent.ctrlKey,
type = domEvent.type;
var isTouch = type === 'touchstart' || type === 'touchmove';
- var isPrimaryMouseDown = type === 'mousedown' && (button === 0 || buttons === 1);
+ var isPrimaryMouseDown = type === 'mousedown' && (button === 0 || buttons === 1 || buttons === 2);
var isPrimaryMouseMove = type === 'mousemove' && buttons === 1;
var noModifiers = altKey === false && ctrlKey === false;
if (isTouch || isPrimaryMouseDown && noModifiers || isPrimaryMouseMove && noModifiers) {