Disable thread in archived room by gijoe0295 · Pull Request #38251 · Expensify/App

gijoe0295 · 2024-03-13T18:57:29Z

Details

Disable reply in thread with messages in an archived room and have no reply.

Fixed Issues

$ #37551
$ #38183
PROPOSAL: #37551 (comment)

Tests

Create a workspace
Send several messages to #announce room
Hover over a message (message A) >> Reply in thread
Send a reply message
Delete the workspace
Go to the archived #announce room from step 2
Hover over message A from step 3
Verify Reply in thread option shows
Press Reply in thread
Verify user navigates to the thread report
Hover over any message that has no reply in #announce room above
Verify Reply in thread option does not show

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Create a workspace
Send several messages to #announce room
Hover over a message (message A) >> Reply in thread
Send a reply message
Delete the workspace
Go to the archived #announce room from step 2
Hover over message A from step 3
Verify Reply in thread option shows
Press Reply in thread
Verify user navigates to the thread report
Hover over any message that has no reply in #announce room above
Verify Reply in thread option does not show

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-14.at.02.22.45-compressed.mov

Android: mWeb Chrome

Screen.Recording.2024-03-14.at.02.24.07-compressed.mov

iOS: Native

Screen.Recording.2024-03-14.at.02.16.36-compressed.mov

iOS: mWeb Safari

Screen.Recording.2024-03-14.at.02.18.56-compressed.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-14.at.02.17.05-compressed.mov

Offline

Screen.Recording.2024-03-14.at.02.25.31-compressed.mov

MacOS: Desktop

Screen.Recording.2024-03-14.at.02.19.45-compressed.mov

melvin-bot · 2024-03-13T19:27:24Z

@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

gijoe0295 · 2024-03-14T09:58:53Z

@akinwale PR ready for your review 👍

blimpich · 2024-03-14T17:21:29Z

It looks like this PR will also fix this issue. See this comment for details. I edited the PR description to include this issue in the list of issues that will be fixed by this PR. Happy coding! 🧑‍💻

akinwale · 2024-03-14T18:13:41Z

 * - The action is the thread's first chat
 */
-function shouldDisableThread(reportAction: OnyxEntry<ReportAction>, reportID: string): boolean {
+function shouldDisableThread(reportAction: OnyxEntry<ReportAction>, reportID: string, isArchivedReport = false): boolean {


You don't need to add a new method parameter for isArchivedReport. You can check if the report is archived in the shouldDisableThread method using the following code:

+const report = getReport(reportID); +const isArchivedReport = isArchivedRoom(report);

Initially I intended to do as your above suggestions but I spotted in ContextMenuAction, we already handle the isArchivedRoom check outside so I don't want to do the extra redundant work again

App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx

Lines 193 to 198 in aca0f8c

shouldShow: (type, reportAction, isArchivedRoom, betas, menuTarget, isChronosReport, reportID) => {

if (type !== CONST.CONTEXT_MENU_TYPES.REPORT_ACTION) {

return false;

}

return !ReportUtils.shouldDisableThread(reportAction, reportID);

},

But I can update according to what you prefer anw.

Since it's a utility method, let's keep it self-contained. You will also notice that the getReport method is used by other methods in the file.

akinwale · 2024-03-15T06:11:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

38251-android-chrome.mp4

iOS: Native

38251-ios-native.mp4

iOS: mWeb Safari

38251-ios-safari.mp4

MacOS: Chrome / Safari

38251-web.mp4

MacOS: Desktop

38251-desktop.mp4

akinwale

LGTM.

gijoe0295 · 2024-03-19T10:14:43Z

@blimpich Waiting for your feedback.

gijoe0295 · 2024-03-22T16:05:23Z

Oh Ben was OOO. Let me ask on Slack if any one can help approving this.

roryabraham

LGTM, approving and merging since @blimpich is OOO. I do wonder if archiving a room should archive all child threads as well, but it seems like that could be a separate concern

roryabraham · 2024-03-22T19:56:48Z

Reassure is failing on SignInPage, which is most certainly unaffected by these changes. going to ignore and merge 🚀

melvin-bot · 2024-03-22T19:57:00Z

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2024-03-22T20:03:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

gijoe0295 added 2 commits March 14, 2024 01:49

disable thread in archived room

1e63cad

fix lint errors

220ee46

gijoe0295 marked this pull request as ready for review March 13, 2024 19:27

gijoe0295 requested a review from a team as a code owner March 13, 2024 19:27

melvin-bot Bot removed the request for review from a team March 13, 2024 19:27

melvin-bot Bot requested a review from akinwale March 13, 2024 19:27

VickyStash mentioned this pull request Mar 14, 2024

[$250] [HOLD for payment 2024-04-05] Workspace - Not here page shows up when opening message in thread in deleted workspace #38183

Closed

6 tasks

akinwale suggested changes Mar 14, 2024

View reviewed changes

remove isArchivedReport param

5f1add8

akinwale approved these changes Mar 15, 2024

View reviewed changes

melvin-bot Bot requested a review from blimpich March 15, 2024 06:43

Merge branch 'main' of https://github.com/gijoe0295/App into gijoe/37551

da45df6

roryabraham approved these changes Mar 22, 2024

View reviewed changes

roryabraham merged commit a59fd6d into Expensify:main Mar 22, 2024

melvin-bot Bot added the Emergency label Mar 22, 2024

roryabraham removed the Emergency label Mar 22, 2024

github-actions Bot mentioned this pull request Mar 27, 2024

Deploy Checklist: New Expensify 2024-03-27 #39033

Closed

melvin-bot Bot mentioned this pull request Mar 29, 2024

[HOLD for payment 2024-04-05] [$500] Chat - "Auth OpenReport returned an error" appears when refresh thread page from archived chat #37551

Closed

6 tasks

	shouldShow: (type, reportAction, isArchivedRoom, betas, menuTarget, isChronosReport, reportID) => {
	if (type !== CONST.CONTEXT_MENU_TYPES.REPORT_ACTION) {
	return false;
	}
	return !ReportUtils.shouldDisableThread(reportAction, reportID);
	},

Conversation

gijoe0295 commented Mar 13, 2024 • edited by blimpich Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Mar 13, 2024

Uh oh!

gijoe0295 commented Mar 14, 2024

Uh oh!

blimpich commented Mar 14, 2024

Uh oh!

akinwale Mar 14, 2024

Choose a reason for hiding this comment

Uh oh!

gijoe0295 Mar 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akinwale Mar 14, 2024

Choose a reason for hiding this comment

Uh oh!

gijoe0295 Mar 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akinwale commented Mar 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

akinwale left a comment

Choose a reason for hiding this comment

Uh oh!

gijoe0295 commented Mar 19, 2024

Uh oh!

gijoe0295 commented Mar 22, 2024

Uh oh!

roryabraham left a comment

Choose a reason for hiding this comment

Uh oh!

roryabraham commented Mar 22, 2024

Uh oh!

melvin-bot Bot commented Mar 22, 2024

Uh oh!

OSBotify commented Mar 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gijoe0295 commented Mar 13, 2024 •

edited by blimpich

Loading

gijoe0295 Mar 14, 2024 •

edited

Loading

gijoe0295 Mar 14, 2024 •

edited

Loading

akinwale commented Mar 15, 2024 •

edited

Loading