Repository navigation
Feat/categories bulk actions #37734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
luacmartins
merged 39 commits into
Expensify:main
from
ArekChr:feat/categories_bulk_actions
Mar 13, 2024
Merged
Feat/categories bulk actions #37734
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
74e7d45
feat(bulk actions ui): add menu dropdown button
ArekChr 3f6c8f5
feat(onyx): implement bulk delete categories
ArekChr dfae8bc
fix(onyx bulk delete): missing params type
ArekChr 10b282b
feat: connect bulk actions with onyx & api
ArekChr bd2c8bf
feat: add red brick road pending action to categories menu item and c…
ArekChr 34c64b1
refactor(types): remove PolicyForList, use ListItem type instead
ArekChr 7713c28
feat: handle dismiss errors in categories list
ArekChr 34b15a0
fix: prevent removing categories from list if pending action is delete
ArekChr c0b6b92
fix: disabled right element styles
ArekChr 920ee83
refactor: optimize optimistic data setting & params as a json
ArekChr f0ec68a
fix: add pending action to list item
ArekChr fd18d44
refactor: remove preading value
ArekChr f697a58
Merge branch 'main' into feat/categories_bulk_actions
ArekChr 14470d8
fix(icon): document for enabling and document slash for disabling cat…
ArekChr a429fa1
fix(update categories): add pending action update when updating categ…
ArekChr 1b2c87e
fix(styles): 50% width for small screen width in button with dropdown
ArekChr 790a0e6
fix: fix icon fill color on mobile platforms
ArekChr 14c1221
refactor: remove usecallback got getHeaderButtons
ArekChr c26e2a7
fix: eslint issues
ArekChr d06f58e
fix: prevent selecting hidden pending removal categories
ArekChr 05ee739
refactor(ts): remove generic from ButtonWithDropdownMenu
ArekChr 9c1aeb6
refactor(onyx actions): use const as api command name instead of string
ArekChr 3a7b40e
refactor(ts): move generic from map to useMemo
ArekChr 70a96d5
fix: rename svg as per convention
ArekChr f42cfb4
Merge branch 'main' into feat/categories_bulk_actions
ArekChr 93a7bfb
Merge branch 'main' into feat/categories_bulk_actions
ArekChr f57b893
fix: remove pendingAction from update category
ArekChr 594f1e5
fix: iterate using categoryNames in failure data
ArekChr 25f45f6
refactor: iterate using categoryNames in success data
ArekChr f4fbbe7
refactor: toggle categories
ArekChr ff3ad81
Merge branch 'main' into feat/categories_bulk_actions
ArekChr 44b019c
fix(categories selection): include disable and enable options when se…
ArekChr fecbd84
Merge branch 'main' into feat/categories_bulk_actions
ArekChr 4e6f244
fix: conflicts
ArekChr 7329493
Merge branch 'main' into feat/categories_bulk_actions
ArekChr cbdfe08
fix: ts issues
ArekChr acacbb2
fix: conflicts - restore actions
ArekChr e760ff1
Merge branch 'main' into feat/categories_bulk_actions
ArekChr 0770d27
fix: conflicts, export deleteWorkspaceCategories
ArekChr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
src/libs/API/parameters/DeleteWorkspaceCategoriesParams.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| type DeleteWorkspaceCategoriesParams = { | ||
| policyID: string; | ||
| /** | ||
| * A JSON-encoded string representing an array of category names to be deleted. | ||
| * Each element in the array is a string that specifies the name of a category. | ||
| */ | ||
| categories: string; | ||
| }; | ||
|
|
||
| export default DeleteWorkspaceCategoriesParams; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.