Skip to content

[Testing GH action] - Feeding dashboard with reassure data #37298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnmlee101 merged 12 commits into from
Feb 29, 2024
Merged

[Testing GH action] - Feeding dashboard with reassure data #37298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
490348d
add test comment
rinej Feb 27, 2024
f2ff675
add random change
rinej Feb 27, 2024
79e2cca
remove merge check for test
rinej Feb 27, 2024
dbbbbcb
add merge check
rinej Feb 27, 2024
ecc0d86
feat: change the path for graphite string
rinej Feb 27, 2024
ab3c805
chore: rebuild actions
rinej Feb 27, 2024
1077c48
chore: fix script
rinej Feb 28, 2024
c4552c9
fix: fix script withy double quotes
rinej Feb 28, 2024
90e7bfa
remove merge to main branch check
rinej Feb 28, 2024
5bf0f7a
feat: add scoped env variables
rinej Feb 29, 2024
da3a37c
testing env variables
rinej Feb 29, 2024
7fb5ff9
feat: set env variables
rinej Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/actions/javascript/getGraphiteString/getGraphiteString.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const fs = require('fs');

const run = () => {
// Prefix path to the graphite metric
const GRAPHITE_PATH = 'bucket-testing.reassure';
const GRAPHITE_PATH = 'reassure';

let regressionOutput;
try {
Expand Down Expand Up @@ -35,10 +35,10 @@ const run = () => {
// Graphite doesn't accept metrics name with space, we replace spaces with "-"
const formattedName = current.name.split(' ').join('-');

const meanDurationString = `${GRAPHITE_PATH}.meanDuration.PR-${prNumber}.${formattedName} ${current.meanDuration} ${timestamp}`;
const meanCountString = `${GRAPHITE_PATH}.meanCount.PR-${prNumber}.${formattedName} ${current.meanCount} ${timestamp}`;
const renderDurationString = `${GRAPHITE_PATH}.PR-${prNumber}.${formattedName}.renderDuration ${current.meanDuration} ${timestamp}`;
const renderCountString = `${GRAPHITE_PATH}.PR-${prNumber}.${formattedName}.renderCount ${current.meanCount} ${timestamp}`;

return `${meanDurationString}\n${meanCountString}`;
return `${renderDurationString}\n${renderCountString}`;
})
.join('\n');

Expand Down
8 changes: 4 additions & 4 deletions .github/actions/javascript/getGraphiteString/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const fs = __nccwpck_require__(7147);

const run = () => {
// Prefix path to the graphite metric
const GRAPHITE_PATH = 'bucket-testing.reassure';
const GRAPHITE_PATH = 'reassure';

let regressionOutput;
try {
Expand Down Expand Up @@ -44,10 +44,10 @@ const run = () => {
// Graphite doesn't accept metrics name with space, we replace spaces with "-"
const formattedName = current.name.split(' ').join('-');

const meanDurationString = `${GRAPHITE_PATH}.meanDuration.PR-${prNumber}.${formattedName} ${current.meanDuration} ${timestamp}`;
const meanCountString = `${GRAPHITE_PATH}.meanCount.PR-${prNumber}.${formattedName} ${current.meanCount} ${timestamp}`;
const renderDurationString = `${GRAPHITE_PATH}.PR-${prNumber}.${formattedName}.renderDuration ${current.meanDuration} ${timestamp}`;
const renderCountString = `${GRAPHITE_PATH}.PR-${prNumber}.${formattedName}.renderCount ${current.meanCount} ${timestamp}`;

return `${meanDurationString}\n${meanCountString}`;
return `${renderDurationString}\n${renderCountString}`;
})
.join('\n');

Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/reassurePerformanceTests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ jobs:
uses: ./.github/actions/javascript/getGraphiteString

- name: Send graphite data
env:
GRAPHITE_SERVER: ${{ vars.GRAPHITE_SERVER }}
GRAPHITE_PORT: ${{ vars.GRAPHITE_PORT }}
# run only when merged to main
if: github.event.pull_request.merged == true && github.event.pull_request.base.ref == 'graphite-testing-script'
run: echo -e "${{ steps.saveGraphiteString.outputs.GRAPHITE_STRING }}" | nc "$GRAPHITE_SERVER" "$GRAPHITE_PORT"
1 change: 1 addition & 0 deletions src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ import InitialUrlContext from './libs/InitialUrlContext';
import {ReportAttachmentsProvider} from './pages/home/report/ReportAttachmentsContext';
import type {Route} from './ROUTES';

// Just adding comment to create PR to graphite-testing-script branch to test the github action flow
type AppProps = {
/** If we have an authToken this is true */
url?: Route;
Expand Down