Fix - display the home route when the app restarts on mobile platforms by HezekielT · Pull Request #36637 · Expensify/App

HezekielT · 2024-02-15T21:44:40Z

Details

Opens the home route on app startup for native platforms by clearing the lastVisitedPath

Fixed Issues

$ #35927
PROPOSAL: #35927 (comment)

Tests

For IOS native and Android native

Launch the app.
Open any report.
Close the app and kill it(make sure it is not running in the background).
Launch the app.
Verify that the Home route is displayed instead of the report opened on step two.

For Other platforms( Web, mobile chrome, safari, desktop)

Open the expensify app.
Open any report(chat).
Close the tab(for web) or close the desktop app.
Open the expensify app again( launch the desktop app).
Verify that the report opened on step two is displayed.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

restartFromHomeRoute.mov

Android: mWeb Chrome

mweb_RestartFromHomeRoute.mov

iOS: Native

ios_restartFromHomeRoute.mov

iOS: mWeb Safari

safari_restartFromHomeroute.mov

MacOS: Chrome / Safari

Web_RestartFromHomeRoute.mov

MacOS: Desktop

desktop_RestartFromHomeRoute.mov

…e-when-the-app-restarts-on-mobile-platforms

melvin-bot · 2024-02-15T21:56:32Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rushatgabhane · 2024-02-16T03:02:00Z

 import platformSetup from './platformSetup';

+function initializeLastVisitedPath(): string | undefined {
+    if (!(getPlatform() === CONST.PLATFORM.ANDROID || getPlatform() === CONST.PLATFORM.IOS)) {


@HezekielT please use platform specific files for this function.
Nothing wrong with inline platform checks, but we want to be consistent with the codestyle

rushatgabhane · 2024-02-16T14:18:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-16.at.20.19.11.mov

Android: mWeb Chrome

Screen.Recording.2024-02-16.at.20.00.57.mov

iOS: Native

Screen.Recording.2024-02-16.at.19.54.54.mov

iOS: mWeb Safari

Screen.Recording.2024-02-16.at.20.01.44.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-16.at.19.50.16.mov

MacOS: Desktop

Screen.Recording.2024-02-16.at.20.21.53.mov

rushatgabhane · 2024-02-16T14:54:56Z

@hayata-suenaga @HezekielT this works as expected on native, web and desktop.

But for me on mWeb, the app always restarts at home screen. I tried clearing cache and did a clean login.
Maybe something is wrong with my device because for @HezekielT the app starts on the last visitied screen.

I think we should merge 👍

HezekielT · 2024-02-16T15:50:08Z

@rushatgabhane You're right about the app always starting on home screen for mweb but the issue is also happening on the latest main. It seems a recent PR has broken the lastVisitedPath logic on main. I tested on staging as well and got the same result on mweb(the lastVisitedPath is not working anymore for mweb). What should we do?

I haven't tested production but this could be a deploy blocker.

HezekielT · 2024-02-16T15:51:37Z

Staging:

staging.mov

hayata-suenaga · 2024-02-16T15:59:48Z

You're right about the app always starting on home screen for mweb but the issue is also happening on the latest main.

@HezekielT Does this issue only happen on mweb?
I tested on desktop Chrome but I couldn't reproduce.

HezekielT · 2024-02-16T16:01:32Z

@hayata-suenaga Yes, it's reproducible only on mobile chrome.

rushatgabhane · 2024-02-16T16:05:33Z

Nice find! it's unrelated to the PR. So let's do nothing?

hayata-suenaga · 2024-02-16T16:06:54Z

@HezekielT @rushatgabhane I filed a bug report

I suggest we hold this PR until the bug is identified and fixed.

rushatgabhane · 2024-02-16T16:09:30Z

@hayata-suenaga should we hold on merging? because this PR is needed for e2e tests to run. And the bug is unrelated, it's about correctly setting the lastVisitedPath before the app is closed.

What do you think?

https://expensify.slack.com/archives/C05LX9D6E07/p1708015299306599?thread_ts=1708015218.455719&cid=C05LX9D6E07

hayata-suenaga · 2024-02-16T16:10:24Z

by the way, QA codes for Ad Hoc builds will be posted on this PR soon because I was planning to test the issue with mweb. But as we now know that the issue is already present on staging, please ignore the ad hoc builds 🙇

github-actions · 2024-02-16T16:15:11Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/36637/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/36637/NewExpensify.dmg	https://36637.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

hayata-suenaga · 2024-02-16T16:50:00Z

@hayata-suenaga should we hold on merging? because this PR is needed for e2e tests to run. And the bug is unrelated, it's about correctly setting the lastVisitedPath before the app is closed.

you made a good point, especially on the broken E2E tests. I was trying to be cautious about merging before we can test this fully on all platforms, but I can see the argument that the discovered bug is not related to this PR.

I'd say... let's merge 🚀

hayata-suenaga

🟢

OSBotify · 2024-02-16T16:56:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-19T23:50:01Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.4.43-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kbecciv · 2024-02-20T17:12:26Z

@HezekielT
This PR is failing because of issue #36926
The issue is reproducible in: IOS/Safari and Android/Chrome

Bug6385905_1708447709787.BRYO7003.mp4

hayata-suenaga · 2024-02-20T18:16:02Z

This issue was known previously

OSBotify · 2024-02-26T20:56:05Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.43-20 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

HezekielT and others added 3 commits February 15, 2024 20:58

restart from home route for native platforms

5a6f969

Merge branch 'Expensify:main' into fix--35927---Display-the-home-rout…

164c492

…e-when-the-app-restarts-on-mobile-platforms

run prettier

a12533e

HezekielT marked this pull request as ready for review February 15, 2024 21:56

HezekielT requested a review from a team as a code owner February 15, 2024 21:56

melvin-bot Bot requested review from rushatgabhane and removed request for a team February 15, 2024 21:56

HezekielT mentioned this pull request Feb 15, 2024

[$500] [Wave Collect] [Ideal Nav] Display the home route when the app restarts on mobile platforms #35927

Closed

rushatgabhane reviewed Feb 16, 2024

View reviewed changes

HezekielT added 2 commits February 16, 2024 09:16

use platform specific files instead of codes

108a9b3

run prettier

0b778c0

rushatgabhane approved these changes Feb 16, 2024

View reviewed changes

melvin-bot Bot requested a review from hayata-suenaga February 16, 2024 14:18

hayata-suenaga added the Ready To Build label Feb 16, 2024

hayata-suenaga approved these changes Feb 16, 2024

View reviewed changes

hayata-suenaga merged commit c70f2d9 into Expensify:main Feb 16, 2024

github-actions Bot mentioned this pull request Feb 19, 2024

Deploy Checklist: New Expensify 2024-02-19 #36820

Closed

kbecciv mentioned this pull request Feb 20, 2024

mWeb - Chat - LHN is displayed instead of the opened chat #36926

Closed

2 of 6 tasks

Conversation

HezekielT commented Feb 15, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Feb 15, 2024

Uh oh!

rushatgabhane Feb 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rushatgabhane commented Feb 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

rushatgabhane commented Feb 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HezekielT commented Feb 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HezekielT commented Feb 16, 2024

Uh oh!

hayata-suenaga commented Feb 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HezekielT commented Feb 16, 2024

Uh oh!

rushatgabhane commented Feb 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hayata-suenaga commented Feb 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rushatgabhane commented Feb 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hayata-suenaga commented Feb 16, 2024

Uh oh!

github-actions Bot commented Feb 16, 2024

Uh oh!

hayata-suenaga commented Feb 16, 2024

Uh oh!

hayata-suenaga left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Feb 16, 2024

Uh oh!

OSBotify commented Feb 19, 2024

Uh oh!

kbecciv commented Feb 20, 2024

Uh oh!

hayata-suenaga commented Feb 20, 2024

Uh oh!

OSBotify commented Feb 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rushatgabhane Feb 16, 2024 •

edited

Loading

rushatgabhane commented Feb 16, 2024 •

edited

Loading

rushatgabhane commented Feb 16, 2024 •

edited

Loading

HezekielT commented Feb 16, 2024 •

edited

Loading

hayata-suenaga commented Feb 16, 2024 •

edited

Loading

rushatgabhane commented Feb 16, 2024 •

edited

Loading

hayata-suenaga commented Feb 16, 2024 •

edited

Loading

rushatgabhane commented Feb 16, 2024 •

edited

Loading