Skip to content

[NoQA] [Audit][Implementation] getOrderedReportIDs - iouReportAmount removal #36566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 2 commits into from
Feb 16, 2024
Merged

[NoQA] [Audit][Implementation] getOrderedReportIDs - iouReportAmount removal #36566

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbb3f5e
remove iouReportAmount computation
kacper-mikolajczak Feb 12, 2024
a792fe8
mrege main
kacper-mikolajczak Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/libs/SidebarUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,6 @@ function getOrderedReportIDs(
// eslint-disable-next-line no-param-reassign
report.displayName = ReportUtils.getReportName(report);

// eslint-disable-next-line no-param-reassign
report.iouReportAmount = ReportUtils.getMoneyRequestSpendBreakdown(report, allReports).totalDisplaySpend;

const isPinned = report.isPinned ?? false;
const reportAction = ReportActionsUtils.getReportAction(report.parentReportID ?? '', report.parentReportActionID ?? '');
if (isPinned || ReportUtils.requiresAttentionFromCurrentUser(report, reportAction)) {
Expand Down Expand Up @@ -269,7 +266,6 @@ function getOptionData({
isPinned: false,
hasOutstandingChildRequest: false,
isIOUReportOwner: null,
iouReportAmount: 0,
isChatRoom: false,
isArchivedRoom: false,
shouldShowSubscript: false,
Expand Down Expand Up @@ -416,7 +412,6 @@ function getOptionData({
}

result.isIOUReportOwner = ReportUtils.isIOUOwnedByCurrentUser(result as Report);
result.iouReportAmount = ReportUtils.getMoneyRequestSpendBreakdown(result as Report).totalDisplaySpend;

if (!hasMultipleParticipants) {
result.accountID = personalDetail?.accountID;
Expand Down