Skip to content

Reattempt: Fix doing text selection on money request amount input swipes the tab #36463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
francoisl merged 3 commits into from
Feb 17, 2024
Merged

Reattempt: Fix doing text selection on money request amount input swipes the tab #36463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02d31b1
prevent swipe when selecting text
bernhardoj Feb 14, 2024
44106ac
remove intercept swipe from native input
bernhardoj Feb 14, 2024
f98c998
lint
bernhardoj Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/AmountTextInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ function AmountTextInput(
disableKeyboard
autoGrow
hideFocusedState
shouldInterceptSwipe
inputStyle={[styles.iouAmountTextInput, styles.p0, styles.noLeftBorderRadius, styles.noRightBorderRadius, style]}
textInputContainerStyles={[styles.borderNone, styles.noLeftBorderRadius, styles.noRightBorderRadius]}
onChangeText={onChangeAmount}
Expand Down
8 changes: 1 addition & 7 deletions src/components/TextInput/BaseTextInput/index.native.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import Icon from '@components/Icon';
import * as Expensicons from '@components/Icon/Expensicons';
import PressableWithoutFeedback from '@components/Pressable/PressableWithoutFeedback';
import RNTextInput from '@components/RNTextInput';
import SwipeInterceptPanResponder from '@components/SwipeInterceptPanResponder';
import Text from '@components/Text';
import * as styleConst from '@components/TextInput/styleConst';
import TextInputLabel from '@components/TextInput/TextInputLabel';
Expand Down Expand Up @@ -52,7 +51,6 @@ function BaseTextInput(
onInputChange = () => {},
shouldDelayFocus = false,
multiline = false,
shouldInterceptSwipe = false,
autoCorrect = true,
prefixCharacter = '',
inputID,
Expand Down Expand Up @@ -264,11 +262,7 @@ function BaseTextInput(

return (
<>
<View
style={[containerStyles]}
// eslint-disable-next-line react/jsx-props-no-spreading
{...(shouldInterceptSwipe && SwipeInterceptPanResponder.panHandlers)}
>
<View style={[containerStyles]}>
<PressableWithoutFeedback
role={CONST.ROLE.PRESENTATION}
onPress={onPress}
Expand Down