Skip to content

Change the global create and DM create tooltips to read Create #36242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youssef-lr merged 5 commits into from
Feb 16, 2024
Merged

Change the global create and DM create tooltips to read Create #36242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6e08aef
Change the global create and DM create tooltips to read Create
esh-g Feb 9, 2024
290cf70
Additional modifications
esh-g Feb 11, 2024
cf7ceae
Merge branch 'main' into tooltip-create
esh-g Feb 14, 2024
73062ce
Merge branch 'main' into tooltip-create
esh-g Feb 15, 2024
4122e53
Fix tests
esh-g Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/FloatingActionButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ function FloatingActionButton({onPress, isActive, accessibilityLabel, role}: Flo
};

return (
<Tooltip text={translate('common.new')}>
<Tooltip text={translate('common.create')}>
<PressableWithoutFeedback
style={styles.h100}
accessibilityLabel={accessibilityLabel}
Expand Down
2 changes: 1 addition & 1 deletion src/languages/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ export default {
next: 'Next',
previous: 'Previous',
goBack: 'Go back',
create: 'Create',
add: 'Add',
resend: 'Resend',
save: 'Save',
Expand Down Expand Up @@ -425,7 +426,6 @@ export default {
oneMoment: "One moment while we redirect you to your company's single sign-on portal.",
},
reportActionCompose: {
addAction: 'Actions',
dropToUpload: 'Drop to upload',
sendAttachment: 'Send attachment',
addAttachment: 'Add attachment',
Expand Down
2 changes: 1 addition & 1 deletion src/languages/es.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ export default {
searchWithThreeDots: 'Buscar...',
select: 'Seleccionar',
next: 'Siguiente',
create: 'Crear',

@aimane-chnaif aimane-chnaif Feb 11, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

match position with English, between goBack and add

previous: 'Anterior',
goBack: 'Volver',
add: 'Añadir',
Expand Down Expand Up @@ -416,7 +417,6 @@ export default {
oneMoment: 'Un momento mientras te redirigimos al portal de inicio de sesión único de tu empresa.',
},
reportActionCompose: {
addAction: 'Acción',
dropToUpload: 'Suelta el archivo aquí para compartirlo',
sendAttachment: 'Enviar adjunto',
addAttachment: 'Añadir archivo adjunto',
Expand Down
4 changes: 2 additions & 2 deletions src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ function AttachmentPickerWithMenuItems({
</PressableWithFeedback>
</Tooltip>
)}
<Tooltip text={translate('reportActionCompose.addAction')}>
<Tooltip text={translate('common.create')}>
<PressableWithFeedback
ref={actionButtonRef}
onPress={(e) => {
Expand All @@ -293,7 +293,7 @@ function AttachmentPickerWithMenuItems({
style={styles.composerSizeButton}
disabled={isBlockedFromConcierge || disabled}
role={CONST.ROLE.BUTTON}
accessibilityLabel={translate('reportActionCompose.addAction')}
accessibilityLabel={translate('common.create')}
>
<Icon
fill={theme.icon}
Expand Down
2 changes: 1 addition & 1 deletion tests/perf-test/ReportActionCompose.perf-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ test('[ReportActionCompose] should render Composer with text input interactions'
test('[ReportActionCompose] should press add attachemnt button', async () => {
const scenario = async () => {
// Query for the attachment button
const hintAttachmentButtonText = Localize.translateLocal('reportActionCompose.addAction');
const hintAttachmentButtonText = Localize.translateLocal('common.create');
const attachmentButton = await screen.findByLabelText(hintAttachmentButtonText);

fireEvent.press(attachmentButton, mockEvent);
Expand Down