Skip to content

fix android picker text color in light theme #35032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thienlnam merged 1 commit into from
Jan 24, 2024
+4 −4
Merged

fix android picker text color in light theme #35032

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/components/Picker/BasePicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,6 @@ function BasePicker<TPickerValue>(
// reference to @react-native-picker/picker
const picker = useRef<RNPickerSelect>(null);

// Windows will reuse the text color of the select for each one of the options
// so we might need to color accordingly so it doesn't blend with the background.
const pickerPlaceholder = Object.keys(placeholder).length > 0 ? {...placeholder, color: theme.text} : {};

useEffect(() => {
if (!!value || !items || items.length !== 1 || !onInputChange) {
return;
Expand Down Expand Up @@ -152,6 +148,10 @@ function BasePicker<TPickerValue>(
return theme.text;
}, [theme]);

// Windows will reuse the text color of the select for each one of the options
// so we might need to color accordingly so it doesn't blend with the background.
const pickerPlaceholder = Object.keys(placeholder).length > 0 ? {...placeholder, color: itemColor} : {};

const hasError = !!errorText;

if (isDisabled) {
Expand Down