Repository navigation

Extract gesture logic from `MultiGestureCanvas` to hooks and improve code - #33756

Merged

pecanoro merged 144 commits into

Expensify:mainfrom

margelo:@chrispader/restructure-multi-gesture-canvas

Jan 29, 2024

Merged

Extract gesture logic from `MultiGestureCanvas` to hooks and improve code#33756
pecanoro merged 144 commits into
Expensify:mainfrom
margelo:@chrispader/restructure-multi-gesture-canvas

Commits on Dec 14, 2023
- start migration
  chrispader
  committed
  15b35b3
- continue
  chrispader
  committed
  83df849
- further type stuff
  chrispader
  committed
  3a8a606
Commits on Dec 28, 2023
- fix: better gestures
  Christoph Pader
  committed
  1da2e9a
Commits on Dec 29, 2023
- further improve variable names
  Christoph Pader
  committed
  3d1691d
- extract gesture code to hooks
  Christoph Pader
  committed
  4c0d2c5
- further simplify
  Christoph Pader
  committed
  2632f75
- improve styles in Lightbox
  Christoph Pader
  committed
  1413871
- rename "isScrolling" prop
  Christoph Pader
  committed
  dae44fc
- add more docs
  Christoph Pader
  committed
  7bcf3f5
- further improve component
  Christoph Pader
  committed
  a08e2bb
Commits on Jan 3, 2024
- add and improve comments
  chrispader
  committed
  8755916
- remove "swipe down to close gesture"
  chrispader
  committed
  0e7fe03
- remove unused props
  chrispader
  committed
  70bd5b7
- rename variable
  chrispader
  committed
  f95f9c6
- simplify pinch gesture
  chrispader
  committed
  610f59f
- fix: variable names
  chrispader
  committed
  730a998
- fix: calculation of total pinch translation
  chrispader
  committed
  0b20554
- rename variables
  chrispader
  committed
  9483b8f
- improve comments and remove aliases
  chrispader
  committed
  16f2497
- improve pan gesture code
  chrispader
  committed
  ba75ac9
- fix: pinch gesture
  chrispader
  committed
  1de9b25
- improve pan gesture code and remove inter-depdendencies of gestures
  chrispader
  committed
  3d93b5e
- improve pan gesture code
  chrispader
  committed
  f0c542b
- simplify pinch gesture callback
  chrispader
  committed
  58fe25b
- improve comments
  chrispader
  committed
  60b6404
- add more comments
  chrispader
  committed
  b1b592a
- Merge branch 'main' into @chrispader/attachment-gallery-ts-migration
  chrispader
  committed
  55c2662
- fix: types
  chrispader
  committed
  4b48f28
- Merge branch 'main' into @chrispader/attachment-gallery-ts-migration
  chrispader
  committed
  103e1b2
- fix: eslint
  chrispader
  committed
  8856caf
- fix: eslint
  chrispader
  committed
  b6bbdec
Commits on Jan 4, 2024
- Merge branch 'main' into @chrispader/attachment-gallery-ts-migration
  chrispader
  committed
  330c1a8
- remove pager ref
  chrispader
  committed
  f8445e4
- update comments
  Christoph Pader
  committed
  937b4b1
- improve lightbox styles
  Christoph Pader
  committed
  7e148ee
- Merge branch 'main' into @chrispader/restructure-multi-gesture-canvas
  Christoph Pader
  committed
  da5dca5
- remove onPinchGestureChange callback
  Christoph Pader
  committed
  9b6c8fe
- fix: carousel arrows
  Christoph Pader
  committed
  351eb53
Commits on Jan 5, 2024
- Merge branch 'main' into @chrispader/restructure-multi-gesture-canvas
  Christoph Pader
  committed
  fe9f43b
- Merge branch 'main' into @chrispader/attachment-gallery-ts-migration
  chrispader
  committed
  91b1e17
- Merge branch '@chrispader/restructure-multi-gesture-canvas' into @chrispader/attachment-gallery-ts-migration
  chrispader
  committed
  39bcb22
- migrate hooks
  chrispader
  committed
  fcfa059
Commits on Jan 7, 2024
- Merge branch 'main' into @chrispader/attachment-gallery-ts-migration
  chrispader
  committed
  2b1793a
- move types
  chrispader
  committed
  945fd35
- migrate Lightbox
  chrispader
  committed
  369d61d
- restructure
  chrispader
  committed
  d209ac2
- add back propTypes
  chrispader
  committed
  24d34a5
- simplify props
  chrispader
  committed
  083f37c
- improve Lightbox
  chrispader
  committed
  5953370
- Merge branch 'main' into @chrispader/restructure-multi-gesture-canvas
  Christoph Pader
  committed
  8715d7c
- Merge branch '@chrispader/restructure-multi-gesture-canvas' into @chrispader/attachment-gallery-ts-migration
  chrispader
  committed
  818f797
- Merge branch 'main' into @chrispader/restructure-multi-gesture-canvas
  Christoph Pader
  committed
  9c393c4
- Merge branch 'main' into @chrispader/attachment-gallery-ts-migration
  chrispader
  committed
  d55844b
Commits on Jan 8, 2024
- remove comment
  chrispader
  committed
  616e8cb
- update error supression
  chrispader
  committed
  3055579
- Merge branch 'main' into @chrispader/restructure-multi-gesture-canvas
  Christoph Pader
  committed
  1f6db1e
- revert Lightbox changes
  chrispader
  committed
  0b741dd
- fix: revert changes
  chrispader
  committed
  9429921
- fix: hook deps
  chrispader
  committed
  a869e63
- more fixes
  chrispader
  committed
  b42422b
- Merge branch 'main' into @chrispader/restructure-multi-gesture-canvas
  Christoph Pader
  committed
  7214c92
- update propTypes
  Christoph Pader
  committed
  b10e600
- fix: import
  chrispader
  committed
  f1a6f9b
Commits on Jan 12, 2024
- Merge branch 'main' into @chrispader/restructure-multi-gesture-canvas
  Christoph Pader
  committed
  22ce23e
- Merge branch 'main' into @chrispader/attachment-gallery-ts-migration
  chrispader
  committed
  f9ae229
- Merge branch '@chrispader/attachment-gallery-ts-migration' into @chrispader/restructure-multi-gesture-canvas
  chrispader
  committed
  a003b32
- remove propTypes
  chrispader
  committed
  95b2e84
Commits on Jan 15, 2024
- Update src/components/MultiGestureCanvas/useTapGestures.ts
  
  chrispader
  and
  blazejkustra
  authored
  b21c8a7
- Merge branch 'main' into @chrispader/restructure-multi-gesture-canvas
  chrispader
  committed
  6651977
- address GH comments
  chrispader
  committed
  e944dc2
Commits on Jan 16, 2024
- Merge branch 'main' into @chrispader/restructure-multi-gesture-canvas
  chrispader
  committed
  ac5dff2
- improve and clean up PR
  chrispader
  committed
  905ba17
- more improvements
  chrispader
  committed
  71135aa
- rename context type
  chrispader
  committed
  397c1aa
- further address comments
  chrispader
  committed
  993afa8
- simplify Lightbox from https://github.com/Expensify/App/pull/34080
  chrispader
  committed
  74343c5
- fix: arrow buttons
  chrispader
  committed
  27aeea9
- fix: pager not swiping
  chrispader
  committed
  6d92147
- remove undefined
  chrispader
  committed
  710a3fb
Commits on Jan 17, 2024
- Merge branch 'main' into @chrispader/restructure-multi-gesture-canvas
  chrispader
  committed
  c338116
- fix: problems
  chrispader
  committed
  5d8799f
- fix: arrows not showable
  chrispader
  committed
  c06219a
- fix: callback deps
  chrispader
  committed
  19350f9
Commits on Jan 18, 2024
- fix: pdf; don't allow tap when zoomed in
  chrispader
  committed
  05ade3c
- fix: callback prop
  chrispader
  committed
  fcee0f2
- move style
  chrispader
  committed
  395e25c
- memoize style
  chrispader
  committed
  8164ff5
- fix: wrong condition
  chrispader
  committed
  5cba6a8
- Merge branch 'main' into @chrispader/restructure-multi-gesture-canvas
  chrispader
  committed
  ef114a0
- fix: arrows not shown after pdf is unzoomed
  chrispader
  committed
  e90de14
- improve style memo
  chrispader
  committed
  773b4dc
Commits on Jan 19, 2024
- Merge branch 'main' into @chrispader/restructure-multi-gesture-canvas
  chrispader
  committed
  5a988f6
- fix: arrows in pdf delayed
  chrispader
  committed
  b61949d
- improve Lightbox on Android
  chrispader
  committed
  1049b84
- fix: lightbox flashing
  chrispader
  committed
  5221cff
- simplify lightbox concurrency
  chrispader
  committed
  2dc798d
- add comment
  chrispader
  committed
  08a6c41
Commits on Jan 22, 2024
- Merge branch 'main' into @chrispader/restructure-multi-gesture-canvas
  Christoph Pader
  committed
  0c0e157
- improve
  Christoph Pader
  committed
  0446a6d
- improve types
  Christoph Pader
  committed
  acadc33
Commits on Jan 23, 2024
- Merge branch 'main' into @chrispader/restructure-multi-gesture-canvas
  Christoph Pader
  committed
  e07475e
- fix: pdf scroll
  Christoph Pader
  committed
  6d21d62
- fix: worklet error
  Christoph Pader
  committed
  c8770bb
- improve pdf
  Christoph Pader
  committed
  f3b7de5
- Merge branch 'main' into @chrispader/restructure-multi-gesture-canvas
  Christoph Pader
  committed
  c3d1443
- remove unused prop
  Christoph Pader
  committed
  cc5bb33
- fix: console errors
  Christoph Pader
  committed
  4b8f183
- Merge branch 'main' into @chrispader/restructure-multi-gesture-canvas
  Christoph Pader
  committed
  7db6a92
- Merge branch 'main' into @chrispader/restructure-multi-gesture-canvas
  Christoph Pader
  committed
  7e1e2b3
- remove redundant isScrollEnabled change
  Christoph Pader
  committed
  4d00c87
- remove round function
  Christoph Pader
  committed
  5f17f2b
- Merge branch 'main' into @chrispader/restructure-multi-gesture-canvas
  chrispader
  committed
  5ad1817
- move logic to AttachmenCarouselPager
  chrispader
  committed
  80bf0ad
- remove unusedProp
  chrispader
  committed
  a83a16e
- fix: onScaleChanged prop
  chrispader
  committed
  aff821c
- fix: prop types
  chrispader
  committed
  1ea4d70
- fix: pager
  chrispader
  committed
  8c6cb24
- fix: wrong condition
  chrispader
  committed
  d8d4a29
- improve readability
  chrispader
  committed
  bb91b85
Commits on Jan 24, 2024
- fix: state setter
  chrispader
  committed
  f54a4b9
- Merge branch 'main' into @chrispader/restructure-multi-gesture-canvas
  chrispader
  committed
  fce6a6f
- Merge branch 'main' into @chrispader/restructure-multi-gesture-canvas
  chrispader
  committed
  2a254de
- fix: loading issues
  chrispader
  committed
  2a2f007
- remove unused code
  chrispader
  committed
  33dea64
- simplify condition
  chrispader
  committed
  a058e3b
Commits on Jan 25, 2024
- Merge branch 'main' into @chrispader/restructure-multi-gesture-canvas
  chrispader
  committed
  8fec0d5
- Merge branch 'main' into @chrispader/restructure-multi-gesture-canvas
  Christoph Pader
  committed
  49a6469
- Merge branch 'main' into @chrispader/restructure-multi-gesture-canvas
  Christoph Pader
  committed
  7bc6f98
Commits on Jan 26, 2024
- Merge branch 'main' into @chrispader/restructure-multi-gesture-canvas
  Christoph Pader
  committed
  3a7b24c
- add comment
  Christoph Pader
  committed
  57d1f7e
- remove empty line?
  Christoph Pader
  committed
  1594b72
- add comment
  Christoph Pader
  committed
  d6da8e9
- add comment
  Christoph Pader
  committed
  f2e4057
- simplify usePageScrollHandler
  Christoph Pader
  committed
  3817512
- rename type
  Christoph Pader
  committed
  6aae70b
- add cp,,emt
  Christoph Pader
  committed
  62c1d4f
- improve
  Christoph Pader
  committed
  2d5eb62
- remove empty line
  Christoph Pader
  committed
  4eaad5a
- rename variable
  Christoph Pader
  committed
  9a5a833
- add comment
  Christoph Pader
  committed
  55d36a6
- add comment
  Christoph Pader
  committed
  9a53061
Commits on Jan 27, 2024
- Merge branch 'main' into @chrispader/restructure-multi-gesture-canvas
  Christoph Pader
  committed
  718acf0
Commits on Jan 29, 2024
- Merge branch 'main' into @chrispader/restructure-multi-gesture-canvas
  Christoph Pader
  committed
  8ddbf36

Commits

Commits on Dec 14, 2023

Commits on Dec 28, 2023

Commits on Dec 29, 2023

Commits on Jan 3, 2024

Commits on Jan 4, 2024

Commits on Jan 5, 2024

Commits on Jan 7, 2024

Commits on Jan 8, 2024

Commits on Jan 12, 2024

Commits on Jan 15, 2024

Commits on Jan 16, 2024

Commits on Jan 17, 2024

Commits on Jan 18, 2024

Commits on Jan 19, 2024

Commits on Jan 22, 2024

Commits on Jan 23, 2024

Commits on Jan 24, 2024

Commits on Jan 25, 2024