Detect split request based on the route params by bernhardoj · Pull Request #33482 · Expensify/App

bernhardoj · 2023-12-22T08:28:17Z

Details

After the money request was refactored, we lost the split request flag. This flag is used to change the title to Split if it's a split request and allow the user to split with 1 participant. In this PR, we update the iouType params everytime we do a split request.

Fixed Issues

$ #32912
PROPOSAL: #32912 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Open the money request page and switch to the manual tab
Enter any amount and press Next
Press "Split" on any user to add them as a split participant
Verify the page title change to Split and the "Add to split" button shows
Press "Add to split"
Verify the confirmation page shows a split confirmation
Go back to the first money request page
Switch to another tab and switch back to manual
Verify the title changes back to Request Money
Enter any amount and press Next again
Verify the title shows Manual
Select any participant directly
Verify the confirmation page shows a request confirmation

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2023-12-22.at.16.18.36.mov

Android: mWeb Chrome

Screen.Recording.2023-12-22.at.16.13.43.mov

iOS: Native

Screen.Recording.2023-12-22.at.16.12.42.mov

iOS: mWeb Safari

Screen.Recording.2023-12-22.at.16.14.34.mov

MacOS: Chrome / Safari

Screen.Recording.2023-12-22.at.16.10.43.mov

MacOS: Desktop

Screen.Recording.2023-12-22.at.16.11.55.mov

melvin-bot · 2023-12-22T08:28:22Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2023-12-22T08:30:44Z

+        }
+        IOU.updateMoneyRequestTypeParams(routes, newIouType.current);
+        newIouType.current = null;
+    }, [routes, participants]);


I decided to update the route params, ONLY after the participant onyx is updated.

Are you safe guarding the case where participants are failed to update in Onyx due to some unexpected reason?

Nope. This is to help reduce the lag where the participant Onyx is late to update, so I want to make sure the participant is updated first. But somehow, this morning I retested it (updating both params and participant at the same time), and the flow works really smoothly and fast.

I don't know exactly what happened with the performance when I worked on the PR, but I think we can keep this.

Let's add a comment explaining the logic purpose.

// Participants can be added as normal or split participants. We want to wait for the participants' data to be updated before // updating the money request type route params reducing the amount of work at the same time.

Do you think this is enough?

@parasharrajat looks like we got no answer from the internal team yet, but let's say we are not allowed to do it, I have another alternative.

We will use the useEffect back. Then, how do we fix the case where the selected participants are the same? We can update the params immediately knowing the participants' onyx won't be updated.

What do you think?

@parasharrajat So, the conclusion is we are not allowed to do the promise chaining. This left us with the alternate option above

That looks feasible to me. let's do it. I wasn't sure of action chaining but had doubts. Thanks for bringing this to Slack, it will help us keep code clear and minimize refactor efforts.

let's reset the newIouType after calling the updateRouteParams in addparticipant and keep updateRouteParams clean.

bernhardoj · 2024-01-01T14:46:07Z

Unit test failing on main too

parasharrajat · 2024-01-02T10:56:07Z

@bernhardoj Please merge the main when you can. I think those tests are fixed now.

bernhardoj · 2024-01-02T10:59:41Z

Done

bernhardoj · 2024-01-04T08:32:30Z

@parasharrajat I found an issue, please hold

bernhardoj · 2024-01-04T15:01:15Z

@parasharrajat In case you missed it, here is the issue that I mean

parasharrajat · 2024-01-04T15:28:22Z

Thanks for sharing. I was about to ask that.

bernhardoj · 2024-02-27T11:30:35Z

to be more consistent with the other request types on the first page.

I actually still don't understand which part is not consistent. Can you explain it more? Maybe we have a different understanding.

Not updating the iouType of the first page will not show the selected participant when visiting the participant page again, which broke the current behavior on prod.

akinwale · 2024-02-27T11:33:20Z

I actually still don't understand which part is not consistent. Can you explain it more? Maybe we have a different understanding.

On the first page of Request money with the tab switcher, whenever we switch to Manual, Scan or Distance, the title remains "Request money" regardless of which tab is active.

Since this is the case for all the tabs, it's more consistent to keep the title as "Request money" before the user moves on to the next page with the participants selector, where the title can change to "Split" for split request, or remain as "Manual" for a regular manual request.

Hope this makes sense.

akinwale · 2024-02-27T11:55:35Z

@bernhardoj For additional context, this is the page I'm referring to. If I return to this page while a split participant is still selected, the title changes to "Split bill", but it should remain "Request money" since the other tabs maintain the same title as well.

bernhardoj · 2024-02-27T12:01:34Z

whenever we switch to Manual, Scan or Distance, the title remains "Request money" regardless of which tab is active.

The title is not the tab title, but the start page title.

App/src/pages/iou/request/IOURequestStartPage.js

Lines 147 to 150 in cfa0ae3

    
           <HeaderWithBackButton 
        
               title={tabTitles[iouType]} 
        
               onBackButtonPress={navigateBack} 
        
           />

When you switch tabs, we reset the data (and params), so you see "Request money" again.
https://github.com/Expensify/App/pull/33482/files#diff-9fd7de5c6297b35051f97572bc4cf6e43ce907fb7a7b2e3bc1f7bec03246308fR122-R124

This will happen if we change that behavior.

Screen.Recording.2024-02-27.at.19.56.51.mov

akinwale · 2024-02-27T12:21:32Z

@bernhardoj I see. I realise the tab titles are from the previous flow prior to the money request tabs being added ("Split bill" used to be a separate menu item in the FAB iirc).

One feasible approach would be to set the corresponding start page title for CONST.IOU.TYPE.SPLIT to translate('iou.requestMoney'). I don't think we need to block on this, however.

App/src/pages/iou/request/IOURequestStartPage.js

Lines 74 to 78 in cfa0ae3

    
           const tabTitles = { 
        
               [CONST.IOU.TYPE.REQUEST]: translate('iou.requestMoney'), 
        
               [CONST.IOU.TYPE.SEND]: translate('iou.sendMoney'), 
        
               [CONST.IOU.TYPE.SPLIT]: translate('iou.splitBill'), 
        
           };

akinwale · 2024-02-27T12:40:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

33482-android-native.mp4

Android: mWeb Chrome

33482-android-chrome.mp4

iOS: Native

33482-ios-native.mp4

iOS: mWeb Safari

33482-ios-safari.mp4

MacOS: Chrome / Safari

33482-web.mp4

MacOS: Desktop

33482-desktop.mp4

akinwale

LGTM.

youssef-lr · 2024-02-28T03:03:15Z

BUG: Clicking on 'Split bill' from a room then navigating to Scan opens 'Hmm not found' page, Manual works fine. I can't reproduce in main.

Screen.Recording.2024-02-28.at.04.02.22.mov

bernhardoj · 2024-02-28T03:06:15Z

Checking

bernhardoj · 2024-02-28T03:16:35Z

Fixed. The problem is we reset the iouType params to REQUEST when switching tabs, but group chat doesn't support REQUEST.

I decided to only reset the iouType when the request is coming from global create (FAB +).

youssef-lr · 2024-02-28T03:47:17Z

-        Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_CONFIRMATION.getRoute(nextStepIOUType, transactionID, selectedReportID.current || reportID));
-    }, [iouType, transactionID, reportID]);
+    const goToNextStep = useCallback(
+        (isSplit) => {


Is this param really needed? It seems like iouType gets updated from the route once we tab 'split' on a participant. Simply using iouType here seems to work fine. Can you double check pelase?

I think it would be nice if we removed it, or find a way to make this onFinish(true); less ambiguous, it's not immediately obvious what the boolean is doing there.

Basically this seems to work fine, but I might be missing something

It's to cover a case where the iouType is not updated yet when goToNextStep is called.

Add a participant to split. At this point, iouType is split

Press the participant. When goToNextStep is called, iouType is still split, but it should be a request.

find a way to make this onFinish(true); less ambiguous,

addParticipant also has isSplit on the param, maybe we can pass the iou type instead of boolean?

const goToNextStep = useCallback( (selectedIouType) => { const isSplit = selectedIouType === CONST.IOU.TYPE.SPLIT;

Add a participant to split. At this point, iouType is split

Press the participant. When goToNextStep is called, iouType is still split, but it should be a request.

Nice, yeah I knew I was missing something :D.

addParticipant also has isSplit on the param, maybe we can pass the iou type instead of boolean?

Yeah this looks better, thanks!

youssef-lr · 2024-02-28T03:51:07Z

Fixed. The problem is we reset the iouType params to REQUEST when switching tabs, but group chat doesn't support REQUEST.

Nice thanks, that fixed it.

youssef-lr

Thanks for the changes!

OSBotify · 2024-02-28T05:05:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-29T00:06:19Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.4.45-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Gonals · 2024-02-29T14:27:48Z

This seems to have introduced this issue

It also seems it is not possible to request splits twice from the same user when it is a new user, as the app tries to generate a new chat and it errors out

OSBotify · 2024-02-29T23:30:47Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.45-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

shubham1206agra · 2024-03-29T15:44:08Z

            {({didScreenTransitionEnd}) => (
                <MoneyRequestParticipantsSelector
-                    participants={participants}
+                    participants={isSplitRequest ? participants : []}


Mark for reference.

shubham1206agra · 2024-03-29T15:45:40Z

-            // When going back to the participants step, if the iou is a "request" (not a split), then the participants need to be cleared from the
-            // transaction so that the participant can be selected again.
-            if (iouType === CONST.IOU.TYPE.REQUEST) {
-                IOU.setMoneyRequestParticipants_temporaryForRefactor(transactionID, []);
-            }


Mark for reference.

shubham1206agra · 2024-03-29T15:48:31Z

    );

-    const goToNextStep = useCallback(() => {
-        const nextStepIOUType = numberOfParticipants.current === 1 ? iouType : CONST.IOU.TYPE.SPLIT;


This is only mark for reference (Not for this PR author).

nextStepIOUType will not be relevant now. Please use iouType directly for navigation to confirmation page.

bernhardoj added 4 commits December 22, 2023 16:08

update ioutype params when selecting a split participant

2a4d712

allow to split with 1 person

35d1ad8

don't include selected participant if not split

91c0b69

reset ioutype if tab changed

c4232f3

bernhardoj requested a review from a team as a code owner December 22, 2023 08:28

melvin-bot Bot removed the request for review from a team December 22, 2023 08:28

melvin-bot Bot requested a review from parasharrajat December 22, 2023 08:28

bernhardoj commented Dec 22, 2023

View reviewed changes

Comment thread src/pages/iou/request/step/IOURequestStepParticipants.js Outdated

parasharrajat reviewed Dec 28, 2023

View reviewed changes

Comment thread src/pages/iou/request/step/IOURequestStepParticipants.js

Merge branch 'main' into fix/32912-split-based-on-route

f8701c3

parasharrajat reviewed Dec 30, 2023

View reviewed changes

Comment thread src/pages/iou/request/step/IOURequestStepParticipants.js

bernhardoj added 4 commits December 31, 2023 14:49

Merge branch 'main' into fix/32912-split-based-on-route

0f081e1

add more comment

b34854f

Merge branch 'main' into fix/32912-split-based-on-route

679457d

prettier

756c002

bernhardoj added 2 commits January 2, 2024 18:58

Merge branch 'main' into fix/32912-split-based-on-route

7d4c9cc

remove unnecessary logic

15fb5de

add more comment

9f93e08

parasharrajat reviewed Jan 3, 2024

View reviewed changes

Comment thread src/libs/actions/IOU.js Outdated

bernhardoj added 2 commits January 4, 2024 10:30

Merge branch 'main' into fix/32912-split-based-on-route

ca1d747

update iou type for all money request page

2c34c91

remove unused import

ccbc27e

akinwale approved these changes Feb 27, 2024

View reviewed changes

melvin-bot Bot requested a review from youssef-lr February 27, 2024 12:41

Merge branch 'main' into fix/32912-split-based-on-route

005580d

only reset params if coming from global create

989da96

prettier

b4cc17f

youssef-lr reviewed Feb 28, 2024

View reviewed changes

update params

07ebdf0

youssef-lr approved these changes Feb 28, 2024

View reviewed changes

youssef-lr merged commit e5b3eb2 into Expensify:main Feb 28, 2024

github-actions Bot mentioned this pull request Feb 28, 2024

Deploy Checklist: New Expensify 2024-02-28 #37459

Closed

91 tasks done

This was referenced Feb 29, 2024

Split - User can split bill with only one user and billable option is present in split menu #37488

Closed

[ON HOLD] [MEDIUM] [Splits] [$250] Split bill - Split amount is lost when adding receipt and splitting bill #37491

Closed

shubham1206agra reviewed Mar 29, 2024

View reviewed changes

truph01 mentioned this pull request Oct 22, 2025

[Due for Payment 2026-05-26][$250] No checkmark displayed for selected recipient in choose recipient page #72129

Closed

4 of 16 tasks

Conversation

bernhardoj commented Dec 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Dec 22, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bernhardoj commented Jan 1, 2024

Uh oh!

parasharrajat commented Jan 2, 2024

Uh oh!

bernhardoj commented Jan 2, 2024

Uh oh!

Uh oh!

bernhardoj commented Jan 4, 2024

Uh oh!

bernhardoj commented Jan 4, 2024

Uh oh!

parasharrajat commented Jan 4, 2024

Uh oh!

bernhardoj commented Feb 27, 2024

Uh oh!

akinwale commented Feb 27, 2024

Uh oh!

akinwale commented Feb 27, 2024

Uh oh!

bernhardoj commented Feb 27, 2024

Uh oh!

akinwale commented Feb 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akinwale commented Feb 27, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

akinwale left a comment

Choose a reason for hiding this comment

Uh oh!

youssef-lr commented Feb 28, 2024

Uh oh!

bernhardoj commented Feb 28, 2024

Uh oh!

bernhardoj commented Feb 28, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

bernhardoj commented Dec 22, 2023 •

edited

Loading

akinwale commented Feb 27, 2024 •

edited

Loading